Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030869Retail ModulesWeb POSpublic2015-09-18 10:032015-11-16 17:11
Reportermalsasua 
Assigned Toguilleaer 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product VersionRR15Q3 
Target VersionFixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket38178
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030869: Terminal authentication is allowing to connect from two distinct devices
DescriptionThere is one way to link two devices to the same terminal
Steps To Reproduce. configure to enable terminal authentication
 . in backoffice, as system administrator, change the preference "enable authention" to Y
. in backoffice, in POS Terminal -> VBS-1
    Terminal Key Identifier: 123

. in device1:
  . go to WEBPOS, to terminal VBS-1
  . popup with the next fields are displayed:
   Terminal Key Identifier: 123
   user: vallblanca
   pass: openbravo
  . login is done

. go to backoffice
 . check "is link to device" is checked
 . click button "unlink device"
 . check "is link to device" is unchecked

. in device2:
  . go to WEBPOS, to terminal VBS-1
  . popup with the next fields are displayed:
   Terminal Key Identifier: 123
   user: vallblanca
   pass: openbravo
  . login is done

. in device1:
  . go to webpos, with link: hosted/context/web/org.openbravo.retail.posterminal/#
  . login is done
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0031497RR15Q4.1 closed guilleaer Terminal authentication is allowing to connect from two distinct devices 
depends on backport 0031498RR15Q3.3 closed guilleaer Terminal authentication is allowing to connect from two distinct devices 
related to defect 0031423RR16Q1 closed guilleaer Include cache session id in log messages 
related to defect 0031426RR16Q1 closed guilleaer Warn is shown in log when Process POS Terminal Unlink is used 
related to defect 0031431RR16Q1 closed guilleaer When terminal authentication is enabled orders, customers, cashups can be sent to the backend 
related to feature request 0031569RR16Q1 closed guilleaer Terminal authentication should be enabled for new instances 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-18 10:03malsasuaNew Issue
2015-09-18 10:03malsasuaAssigned To => Retail
2015-09-18 10:03malsasuaOBNetwork customer => Yes
2015-09-18 10:03malsasuaSupport ticket => 38178
2015-09-18 10:03malsasuaResolution time => 1444946400
2015-09-18 10:03malsasuaTriggers an Emergency Pack => No
2015-10-05 12:20OrekariaSummaryauthentication manager is allowing to connect from two distinct devices => Terminal authentication is allowing to connect from two distinct devices
2015-10-05 12:20OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9597#r9597
2015-10-05 12:42OrekariaStatusnew => acknowledged
2015-10-21 16:51guilleaerAssigned ToRetail => guilleaer
2015-11-09 09:49hgbotCheckin
2015-11-09 09:49hgbotNote Added: 0081607
2015-11-09 09:49hgbotStatusacknowledged => resolved
2015-11-09 09:49hgbotResolutionopen => fixed
2015-11-09 09:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4c55341720182737a661e17ff09d70898ba07c8 [^]
2015-11-10 13:30hgbotCheckin
2015-11-10 13:30hgbotNote Added: 0081649
2015-11-11 11:01guilleaerRelationship addedrelated to 0031423
2015-11-11 11:09guilleaerRelationship addedrelated to 0031426
2015-11-11 16:44guilleaerRelationship addedrelated to 0031431
2015-11-16 09:17hgbotCheckin
2015-11-16 09:17hgbotNote Added: 0081859
2015-11-16 09:18hgbotCheckin
2015-11-16 09:18hgbotNote Added: 0081860
2015-11-16 10:10OrekariaReview Assigned To => marvintm
2015-11-16 13:18marvintmStatusresolved => new
2015-11-16 13:18marvintmResolutionfixed => open
2015-11-16 13:19marvintmStatusnew => scheduled
2015-11-16 13:19marvintmStatusscheduled => resolved
2015-11-16 13:19marvintmFixed in Version => RR16Q1
2015-11-16 13:19marvintmResolutionopen => fixed
2015-11-16 13:19marvintmStatusresolved => closed
2015-11-16 17:11hgbotCheckin
2015-11-16 17:11hgbotNote Added: 0081895
2015-11-25 16:53guilleaerRelationship addedrelated to 0031569
2015-12-02 18:46guilleaerNote Edited: 0081607bug_revision_view_page.php?bugnote_id=0081607#r10392

Notes
(0081607)
hgbot   
2015-11-09 09:49   
(edited on: 2015-12-02 18:46)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c4c55341720182737a661e17ff09d70898ba07c8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Nov 09 09:48:26 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4c55341720182737a661e17ff09d70898ba07c8 [^]

Fixed issue 30869: Terminal authemntication improvements have been added:

- Unique id for each cache session has been added
- When a terminal is linked cache session id is stores at terminal level
- Once a terminal try to link the cache session id is checked

---
M src-db/database/model/tables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/CheckTerminalAuth.java
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M web/org.openbravo.retail.posterminal/js/components/modalselectterminal.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0081649)
hgbot   
2015-11-10 13:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bc976572e6b259e32b2e9f52def0933b4d561886
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Nov 10 13:29:48 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bc976572e6b259e32b2e9f52def0933b4d561886 [^]

Related to issue 30869: Cache id should be null when terminal is unlinked

---
M src/org/openbravo/retail/posterminal/process/UnlinkDeviceActionHandler.java
---
(0081859)
hgbot   
2015-11-16 09:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7d30d146e93204184740fcc55e3748e97af672b6
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 12 16:53:27 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7d30d146e93204184740fcc55e3748e97af672b6 [^]

Related to issue 30869: Set current window when terminal authentication windows is shown

---
M web/org.openbravo.retail.posterminal/js/components/modalselectterminal.js
---
(0081860)
hgbot   
2015-11-16 09:18   
Repository: tools/automation/pi-mobile
Changeset: f41f8f804cda35dd8fa2130004ffe2756365bfeb
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 12 16:56:26 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f41f8f804cda35dd8fa2130004ffe2756365bfeb [^]

Related to issue 30869: Modify old test and add new one

An old test has been modified to cover new features. Therefore a new test has been added to test the whole flow related to terminal authentication, cache session id and log client

---
M src-test/org/openbravo/test/mobile/common/selenium/MobileCoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/common/selenium/utils/OBConstants.java
M src-test/org/openbravo/test/mobile/common/selenium/utils/OBUtils.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/SecureTerminalConfChange.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/TerminalAuthenticationAndCacheSession.java
---
(0081895)
hgbot   
2015-11-16 17:11   
Repository: tools/automation/pi-mobile
Changeset: 80c5ff6f1d7741e0bbf2f2b50dfbde8e1962d799
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Nov 16 17:10:32 2015 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/80c5ff6f1d7741e0bbf2f2b50dfbde8e1962d799 [^]

Related to issue 30869: Revert unwanted changes accidentaly done

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/OBConstants.java
---