Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030859Openbravo ERPZ. Otherspublic2015-09-17 13:292016-02-02 09:42
Reportermaite 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-08-22
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/main/rev/705e724737c0 [^]
Triggers an Emergency PackNo
Summary0030859: Include option to match transactions with higher date than bank statement line date (and update transaction date to bsl date)
DescriptionBefore Match Statement refactor, option to "Hide transactions after statement date" exists, so user was able to uncheck it and select transactions with higher date than statemen's date and run matching process. This option is not available any more after Match Statement refactor
Steps To Reproduce1. Access Cuenta de Banco financial account
2. Access Imported bank statement tab and create record with dates=09/09/2015
3. Add line with date 09/09/2015 and any amount
4. Access Transactions tab and create new register for 15/09/2015 and same amount. Process transaction
5. Run Match Statement process and realize that you are not able to find transaction when pressing "search" (magnifying glass) button from bank statement line
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00308653.0PR15Q3.2 closed vmromanos Include option to match transactions with higher date than bank statement line date (and update transaction date to bsl date) 
depends on backport 00308663.0PR15Q2.6 closed vmromanos Include option to match transactions with higher date than bank statement line date (and update transaction date to bsl date) 
caused by feature request 00293903.0PR14Q4 closed Sandrahuguet Reconciliation refactor project 
related to feature request 0031029 new Triage Omni OMS Transaction statement date not updated to bank statement line date 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-17 13:29maiteNew Issue
2015-09-17 13:29maiteAssigned To => Triage Finance
2015-09-17 13:29maiteModules => Advanced Payables and Receivables Mngmt
2015-09-17 13:29maiteResolution time => 1445464800
2015-09-17 13:29maiteTriggers an Emergency Pack => No
2015-09-17 13:29maiteIssue Monitored: networkb
2015-09-17 16:45vmromanosAssigned ToTriage Finance => vmromanos
2015-09-17 16:45vmromanosStatusnew => acknowledged
2015-09-18 08:53vmromanosRelationship addedcaused by 0029390
2015-09-18 09:02vmromanosRegression level => Production - Confirmed Stable
2015-09-18 09:02vmromanosRegression date => 2014-08-22
2015-09-18 09:02vmromanosRegression introduced in release => 3.0PR14Q4
2015-09-18 09:02vmromanosRegression introduced by commit => https://code.openbravo.com/erp/devel/main/rev/705e724737c0 [^]
2015-09-18 09:08vmromanosNote Added: 0080482
2015-09-18 09:17vmromanosNote Edited: 0080482bug_revision_view_page.php?bugnote_id=0080482#r9458
2015-09-18 09:20vmromanosNote Added: 0080483
2015-09-18 09:21vmromanosStatusacknowledged => scheduled
2015-09-21 10:46hgbotCheckin
2015-09-21 10:46hgbotNote Added: 0080519
2015-09-21 10:46hgbotStatusscheduled => resolved
2015-09-21 10:46hgbotResolutionopen => fixed
2015-09-21 10:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4df08b1bcccd12c8eb7cccaf59dde971ce7cad10 [^]
2015-09-21 10:46dmiguelezReview Assigned To => dmiguelez
2015-09-21 10:46dmiguelezNote Added: 0080520
2015-09-21 10:46dmiguelezStatusresolved => closed
2015-09-21 17:14hudsonbotCheckin
2015-09-21 17:14hudsonbotNote Added: 0080540
2015-10-02 13:18maiteRelationship addedrelated to 0031029
2016-02-02 09:42hgbotCheckin
2016-02-02 09:42hgbotNote Added: 0083829

Notes
(0080482)
vmromanos   
2015-09-18 09:08   
(edited on: 2015-09-18 09:17)
Test plan:

1. Access Cuenta de Banco financial account
2. Access Imported bank statement tab and create record with dates=09/09/2015
3. Add line with date 09/09/2015 and any amount
4. Process it
5. Access Transactions tab and create new register for 15/09/2015 and same amount. Process transaction
6. Run Match Statement process and do not run automatic algorithm. Press the "search" (magnifying glass) button from bank statement line
7. Verify the previous transaction is not shown by default
8. Verify a new filter is automatically applied to the window [Transactions prior to Bank Statement Line's Transaction Date]
9. Remove the filter and verify the transaction is shown
(0080483)
vmromanos   
2015-09-18 09:20   
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8623 [^]
(0080519)
hgbot   
2015-09-21 10:46   
Repository: erp/devel/pi
Changeset: 4df08b1bcccd12c8eb7cccaf59dde971ce7cad10
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Sep 18 11:31:27 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4df08b1bcccd12c8eb7cccaf59dde971ce7cad10 [^]

Fixed bug 30859: Match Statement Transactions prior to Bank Statement Line date

When searching for transactions, the HQL query transformer added a where clause to get only the transactions prior or equal to the bank statement line's transaction date.
There are cases where you want to match to transactions registered after the bank statement line's transaction date.
Before the refactor, there was a flag to hide/show transactions in the future. With the refactor that functionality was lost.

To implement it again, we have moved that restriction from the hql query transformer to a new default filter for this tab. Thus the user can remove the filter to show all the transactions regardless the transaction date.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/TransactionsToMatchTransformer.java
---
(0080520)
dmiguelez   
2015-09-21 10:46   
Code Review + Testing Ok
(0080540)
hudsonbot   
2015-09-21 17:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6f65b2541f60 [^]
Maturity status: Test
(0083829)
hgbot   
2016-02-02 09:42   
Repository: tools/automation/int
Changeset: 8696601ed8f93a9c529555ee9703fa7ca300b1e9
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Nov 26 19:17:44 2015 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/8696601ed8f93a9c529555ee9703fa7ca300b1e9 [^]

Related to issue 30859: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/APRIn_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APROut_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/APRRegression30859In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APRRegression30859Out.java
---