Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030851Retail ModulesWeb POSpublic2015-09-16 23:162015-10-15 13:26
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7aea6130ad12b3a1168401d74db25d80d03ce22c [^]
Triggers an Emergency PackNo
Summary0030851: Stabilization: When the order is cancelled the callback is not executed
DescriptionStabilization: When the order is cancelled the callback is not executed
Steps To ReproduceVerify that in the dataordersave.js file, when the args.cancellation === true, the callback is not executed
---
Install org.openbravo.retail.trainingmode module
Click the menu and click start training mode
Add a product and close the order
You will see an scrim
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030972RR15Q3.2 closed Orekaria Stabilization: When the order is cancelled the callback is not executed 
depends on backport 0030973RR15Q2.6 closed Orekaria Stabilization: When the order is cancelled the callback is not executed 
caused by defect 0025940RR14Q2 closed guilleaer Payment flow doesn't works fine if asynchrony is introduced using hook 'OBPOS_PreOrderSave' 
has duplicate defect 0030969 closed Retail The cancellation of the preOrderSave Hook creates an Scrim that is not possible to hide 
Attached Filespng Screenshot+from+2015-09-29+16-55-48.png (102,217) 2015-09-30 16:45
https://issues.openbravo.com/file_download.php?file_id=8498&type=bug
png

diff issue30851_forQ2.diff (5,882) 2015-10-15 13:26
https://issues.openbravo.com/file_download.php?file_id=8570&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-09-16 23:16OrekariaNew Issue
2015-09-16 23:16OrekariaAssigned To => Orekaria
2015-09-16 23:16OrekariaOBNetwork customer => No
2015-09-16 23:16OrekariaTriggers an Emergency Pack => No
2015-09-16 23:16OrekariaRelationship addedcaused by 0025940
2015-09-16 23:17OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7aea6130ad12b3a1168401d74db25d80d03ce22c [^]
2015-09-16 23:17OrekariaRegression level => Automated tests
2015-09-16 23:17OrekariaRegression levelAutomated tests => Code review
2015-09-16 23:36OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9451#r9451
2015-09-17 23:12hgbotCheckin
2015-09-17 23:12hgbotNote Added: 0080471
2015-09-17 23:12hgbotStatusnew => resolved
2015-09-17 23:12hgbotResolutionopen => fixed
2015-09-17 23:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bba53cbe859c2cfa7eefb5dc6df0336daf873a2f [^]
2015-09-19 10:09OrekariaReview Assigned To => guilleaer
2015-09-29 08:43guilleaerNote Added: 0080680
2015-09-29 08:43guilleaerStatusresolved => closed
2015-09-29 08:43guilleaerFixed in Version => RR15Q4
2015-09-29 18:39OrekariaRelationship addedhas duplicate 0030969
2015-09-29 18:52OrekariaStatusclosed => new
2015-09-29 18:52OrekariaResolutionfixed => open
2015-09-29 18:52OrekariaFixed in VersionRR15Q4 =>
2015-09-29 18:52OrekariaStatusnew => scheduled
2015-09-29 18:52OrekariaStatusscheduled => resolved
2015-09-29 18:52OrekariaFixed in Version => RR15Q4
2015-09-29 18:52OrekariaResolutionopen => fixed
2015-09-29 18:52OrekariaStatusresolved => closed
2015-09-30 16:44plujanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9544#r9544
2015-09-30 16:45plujanFile Added: Screenshot+from+2015-09-29+16-55-48.png
2015-09-30 17:05OrekariaRegression levelCode review => Production - Confirmed Stable
2015-09-30 17:05OrekariaRegression introduced in release => RR15Q2.4
2015-10-02 10:43OrekariaRegression introduced in releaseRR15Q2.4 => RR14Q2
2015-10-15 13:26marvintmFile Added: issue30851_forQ2.diff

Notes
(0080471)
hgbot   
2015-09-17 23:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bba53cbe859c2cfa7eefb5dc6df0336daf873a2f
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Thu Sep 17 23:10:38 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bba53cbe859c2cfa7eefb5dc6df0336daf873a2f [^]

Fixes issue 30851: Execute the cancelled callback when the receipt is cancelled

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0080680)
guilleaer   
2015-09-29 08:43   
code reviewed and tested