Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030842Openbravo ERPZ. Otherspublic2015-09-16 17:132015-11-23 21:16
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030842: GL Item combo not working when using saved view which does not have Organization field shown in grid
DescriptionGL Item combo not working when using saved view which does not have Organization field shown in grid
Steps To Reproduce1. Access Financial Account window, hide Organization field from grid and click on "view" toolbar button to saved it as a personal view. Check "Default view" and save
2. Access Imported Bank Statement tan, create new header and line and process.
3. Close financial account window
4. Access Financial Account window again (realize that your view is used so Organization field is not shown)
5. Select Cuenta de Banco and run "Match Statement" process. Cancel automatic match and press + button to add a transaction
6. Drop down GL Item combo and realize that no data is shown
Proposed SolutionProblem is in "GLItemSelectorFilterExpression" file, in the way used to load "OrgId" value. In case organization is not shown in grid mode, it has not value in session so it is not properly loaded.

Not sure if this is proper solution, but in case orgId value is loaded as "requestMap.get("inpadOrgId")" then combo works properly.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-16 17:13maiteNew Issue
2015-09-16 17:13maiteAssigned To => Triage Finance
2015-09-16 17:13maiteModules => Advanced Payables and Receivables Mngmt
2015-09-16 17:13maiteTriggers an Emergency Pack => No
2015-09-16 17:14maiteResolution time => 1445292000
2015-09-16 17:14maiteTarget Version => 3.0PR15Q4
2015-09-28 11:17vmromanosTarget Version3.0PR15Q4 => 3.0PR16Q1
2015-10-06 09:30AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-10-06 09:30AtulOpenbravoStatusnew => scheduled
2015-10-08 07:12AtulOpenbravoNote Added: 0080874
2015-10-08 12:54psanjuanNote Edited: 0080874bug_revision_view_page.php?bugnote_id=0080874#r9637
2015-10-08 12:56psanjuanNote Added: 0080885
2015-10-08 13:52psanjuanNote Edited: 0080885bug_revision_view_page.php?bugnote_id=0080885#r9643
2015-10-08 13:52psanjuanNote Added: 0080887
2015-10-08 15:55hgbotCheckin
2015-10-08 15:55hgbotNote Added: 0080890
2015-10-08 15:55hgbotStatusscheduled => resolved
2015-10-08 15:55hgbotResolutionopen => fixed
2015-10-08 15:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f396fccd99e9d711f8707108e96132193c1622ea [^]
2015-10-08 15:55hgbotCheckin
2015-10-08 15:55hgbotNote Added: 0080891
2015-10-08 15:56vmromanosReview Assigned To => vmromanos
2015-10-08 15:56vmromanosNote Added: 0080892
2015-10-08 15:56vmromanosStatusresolved => closed
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082120
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082121

Notes
(0080874)
AtulOpenbravo   
2015-10-08 07:12   
(edited on: 2015-10-08 12:54)
Test Plan
- Login as F&B International Group Admin.
- Navigate to Financial Account window, hide Organization field from grid and click on "view" toolbar button to saved it as a personal view. Check "Default view" and save.
- Select Cuenta de Banco Financial Account, go to Imported Bank Statement tab, create new header and line with glitem and process it.
3. Close financial account window.
4. Again access Financial Account window again (realize that your view is used so Organization field is not shown).
5. Select Cuenta de Banco Financial Account and run "Match Statement" process. Cancel automatic match and press + button to add a transaction.
6. Drop down GL Item combo and check that list of applicable GLItems is shown properly.
(0080885)
psanjuan   
2015-10-08 12:56   
(edited on: 2015-10-08 13:52)
Test Plan

1.Login as F&B International Group Admin.

2.Navigate to Financial Account window, hide Organization field from grid view and click on "Save View" toolbar button to saved it as a personal view. Select "Save View" and enter below data:

Save as = FA
Level = User
Value = Openbravo
Check "Set as Default" and save.

3.Select Cuenta de Banco Financial Account, go to Imported Bank Statement tab, create new header and line with glitem and process it.

4. Close financial account window.

5. Again access Financial Account window again (realize that your view is used so Organization field is not shown).

6 Select Cuenta de Banco Financial Account and run "Match Statement" process. Cancel automatic match and press + button to add a transaction.

7. Drop down GL Item combo and check that list of applicable GLItems is shown properly.
(0080887)
psanjuan   
2015-10-08 13:52   
Test Plan above verified before/after applying the patch.
Issue can be closed
(0080890)
hgbot   
2015-10-08 15:55   
Repository: erp/devel/pi
Changeset: f396fccd99e9d711f8707108e96132193c1622ea
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Oct 08 10:24:55 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f396fccd99e9d711f8707108e96132193c1622ea [^]

Fixes Issue 30842: GL Item combo not working when using saved view which does
not have Organization field shown in grid

If session attribute Organization of financial window is not available due to
grid column visible option then get it from requestMap.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/GLItemSelectorFilterExpression.java
---
(0080891)
hgbot   
2015-10-08 15:55   
Repository: erp/devel/pi
Changeset: e8e697041a8e20dd8c9ca768a3e23c15f21ef200
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Oct 08 15:55:09 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e8e697041a8e20dd8c9ca768a3e23c15f21ef200 [^]

Related to issue 30842: updated copyright

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/GLItemSelectorFilterExpression.java
---
(0080892)
vmromanos   
2015-10-08 15:56   
Code review OK
(0082120)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082121)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test