Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030833Openbravo ERP08. Project and service managementpublic2015-09-16 12:252015-09-19 18:59
ReporterVictorVillar 
Assigned Todmiguelez 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket33757
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030833: Create Sales Orders from Expenses is not working fine with Business Partner with Price list defined as 'Price Including Taxes'
DescriptionCreate Sales Orders from Expenses is not working fine with Business Partner with Price list defined as 'Price Including Taxes'
Steps To ReproduceAs Group Admin role,
Go to Product window:
   create a new Expense Product
Go to Price List window,
   Select General Sales and define it as 'Price Including Taxes'

 Go to Expense Sheet
    create a new one for US organization
  Add the product created before in the Lines tab.
  Reinvoicing: Yes
  Select Healthy Food Supermarkets, Co.
  Qty: 200
  Net unit price: 500
Process the expense.

Go to Create Sales Orders from Expenses.
  Date ordered: today
Process it.

 Go to the Sales Order window and realize that the new order created has not Total Gross amount, net unit price.....
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00305043.0PR15Q4 closed AtulOpenbravo "Gross List Price" information is not copied to invoice when using Generate Invoice from Receipt process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-16 12:25VictorVillarNew Issue
2015-09-16 12:25VictorVillarAssigned To => Triage Finance
2015-09-16 12:25VictorVillarOBNetwork customer => Yes
2015-09-16 12:25VictorVillarModules => Core
2015-09-16 12:25VictorVillarSupport ticket => 33757
2015-09-16 12:25VictorVillarResolution time => 1442613600
2015-09-16 12:25VictorVillarTriggers an Emergency Pack => No
2015-09-17 12:38vmromanosRelationship addedrelated to 0030504
2015-09-17 12:39vmromanosStatusnew => scheduled
2015-09-17 12:39vmromanosAssigned ToTriage Finance => dmiguelez
2015-09-18 11:38dmiguelezNote Added: 0080489
2015-09-18 19:08hgbotCheckin
2015-09-18 19:08hgbotNote Added: 0080503
2015-09-18 19:08hgbotStatusscheduled => resolved
2015-09-18 19:08hgbotResolutionopen => fixed
2015-09-18 19:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1cf343c5c0ef78497a68b4b1e0eda653948432fd [^]
2015-09-18 19:08hgbotCheckin
2015-09-18 19:08hgbotNote Added: 0080504
2015-09-18 19:08vmromanosReview Assigned To => vmromanos
2015-09-18 19:08vmromanosNote Added: 0080505
2015-09-18 19:08vmromanosStatusresolved => closed
2015-09-19 18:59hudsonbotCheckin
2015-09-19 18:59hudsonbotNote Added: 0080514
2015-09-19 18:59hudsonbotCheckin
2015-09-19 18:59hudsonbotNote Added: 0080515

Notes
(0080489)
dmiguelez   
2015-09-18 11:38   
As Group Admin role,
Go to Product window:
   Create a new Expense Product
     * Organization: España
     * Tax Category: IVA Normal
     * Product Type: Expense type
   In Price Tab create a new record for
     * Price List Version: Tarifa de Ventas
     * Unit Price: 10
     * List Price: 10
Go to Price List window,
   Select Tarifa de Ventas and check it as 'Price Including Taxes'

 Go to Expense Sheet
    create a new one for España organization
  Add the product created before in the Lines tab.
  Reinvoicing: Yes
  Select Alimentos y Supermercados as the Business Partner
  Qty: 200
  Net unit price: 500
Process the expense.

Go to Create Sales Orders from Expenses.
  Date ordered: today
Process it.

Check the Order created and verify that
  In the Header:
    * Total Gross Amount: 90.000
    * Total Net Amount: 74.379,54
  In the Line:
    * Line Gross Amount: 100.000
    * Line Net Amount: 82.644
    * Discount: -4.900
(0080503)
hgbot   
2015-09-18 19:08   
Repository: erp/devel/pi
Changeset: 1cf343c5c0ef78497a68b4b1e0eda653948432fd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Sep 17 18:04:32 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1cf343c5c0ef78497a68b4b1e0eda653948432fd [^]

Fixes Issue 30833. When generating a Sales Order from an Expense
it takes into account if the Price List defined is a Price List
that includes Taxes. In that case it sets grossPrice and grossLinePrice
 instead of netPrice and netLinePrice. Triggers in OrderLine will
take care of setting the correct values for the other fields.

---
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.java
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder_data.xsql
---
(0080504)
hgbot   
2015-09-18 19:08   
Repository: erp/devel/pi
Changeset: 24be1a7ebba08b5543f89bee097257eb9d05ac90
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Sep 18 19:04:58 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/24be1a7ebba08b5543f89bee097257eb9d05ac90 [^]

Related to issue 30833: code review improvements

Populate sales order line GROSSPRICELIST and GROSSPRICESTD columns

---
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder.java
M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder_data.xsql
---
(0080505)
vmromanos   
2015-09-18 19:08   
Code review + testing OK
(0080514)
hudsonbot   
2015-09-19 18:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8da5a852c979 [^]
Maturity status: Test
(0080515)
hudsonbot   
2015-09-19 18:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8da5a852c979 [^]
Maturity status: Test