Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0030815 | Openbravo ERP | 04. Warehouse management | public | 2015-09-14 12:56 | 2016-02-17 11:38 |
|
| Reporter | VictorVillar | |
| Assigned To | vmromanos | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | 3.0PR16Q1 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | dmiguelez |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | 38230 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0030815: It should not be possible to define the Costing background process for Organizations not Legal |
| Description | It should not be possible to define the Costing background process for Organizations not Legal |
| Steps To Reproduce | As Admin role,
Go to Process Request window:
create a new register for España Región Norte.
This is wrong behavior which could cause inconsistent cost values. It should be possible only for Legals or any ancestor (not children organizations) |
| Proposed Solution | Define an EntityEventObserver to avoid saving (insert and update) the record when the process is the Costing background and the organization has an ancestor which is a legal entity
Add a similar validation in the costing background process itself for the context organization |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0031088 | 3.0PR15Q4 | closed | vmromanos | It should not be possible to define the Costing background process for Organizations not Legal |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-09-14 12:56 | VictorVillar | New Issue | |
| 2015-09-14 12:56 | VictorVillar | Assigned To | => Triage Finance |
| 2015-09-14 12:56 | VictorVillar | OBNetwork customer | => Yes |
| 2015-09-14 12:56 | VictorVillar | Modules | => Core |
| 2015-09-14 12:56 | VictorVillar | Support ticket | => 38230 |
| 2015-09-14 12:56 | VictorVillar | Resolution time | => 1444687200 |
| 2015-09-14 12:56 | VictorVillar | Triggers an Emergency Pack | => No |
| 2015-09-14 12:56 | VictorVillar | Issue Monitored: networkb | |
| 2015-09-14 17:09 | vmromanos | Proposed Solution updated | |
| 2015-09-28 11:17 | vmromanos | Target Version | 3.0PR15Q4 => 3.0PR16Q1 |
| 2015-09-29 13:56 | vmromanos | Status | new => feedback |
| 2015-09-29 17:09 | vmromanos | Assigned To | Triage Finance => vmromanos |
| 2015-09-29 17:09 | vmromanos | Status | feedback => scheduled |
| 2015-09-29 17:09 | vmromanos | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9519#r9519 |
| 2015-09-29 17:09 | vmromanos | Proposed Solution updated | |
| 2015-09-30 16:23 | vmromanos | Note Added: 0080754 | |
| 2015-10-01 13:39 | psanjuan | Note Edited: 0080754 | bug_revision_view_page.php?bugnote_id=0080754#r9568 |
| 2015-10-01 14:08 | psanjuan | Note Added: 0080788 | |
| 2015-10-07 16:47 | hgbot | Checkin | |
| 2015-10-07 16:47 | hgbot | Note Added: 0080864 | |
| 2015-10-07 16:47 | hgbot | Status | scheduled => resolved |
| 2015-10-07 16:47 | hgbot | Resolution | open => fixed |
| 2015-10-07 16:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/9bcc5cdaf9996b5bb29aee3422f66f79c589f039 [^] |
| 2015-10-07 16:49 | dmiguelez | Status | resolved => new |
| 2015-10-07 16:49 | dmiguelez | Resolution | fixed => open |
| 2015-10-07 16:49 | dmiguelez | Status | new => scheduled |
| 2015-10-07 16:49 | dmiguelez | Status | scheduled => resolved |
| 2015-10-07 16:49 | dmiguelez | Resolution | open => fixed |
| 2015-10-07 16:50 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-10-07 16:50 | dmiguelez | Note Added: 0080865 | |
| 2015-10-07 16:50 | dmiguelez | Status | resolved => closed |
| 2015-11-23 21:16 | hudsonbot | Checkin | |
| 2015-11-23 21:16 | hudsonbot | Note Added: 0082116 | |
|
Notes |
|
|
(0080754)
|
|
vmromanos
|
2015-09-30 16:23
(edited on: 2015-10-01 13:39) |
|
Test plan:
As F&B International Group Admin
In an environment without the fix:
Go to Process request
Create a new record
Select España Región Norte org
Select Costing Background Process.
Save it.
Now apply the fix and continue with the testing
Go to Process request
Create a new record
Select España Región Norte org
Select Costing Background Process
Try to save. An error is displayed
Select España org
Try to save. Verify you can save it
Create a new record
Select FB Group org
Select Costing Background Process
Try to save. Verify you can save it
Create a new record
Select * org
Select Costing Background Process
Try to save. Verify you can save it
Create a new record
Select España Región Norte org
Select Log Cleanup Process
Try to save. Verify you can save it
Go to Process Group
Create a new record. Org *, Name="GR"
Go to Process Group List
Create a new record. Select Costing Background Process. Save it
Go to Process request
Create a new record
Select España Región Norte org
Select Group flag.
Select previous GR group
Try to save. An error is displayed
Change the organization to FB España.
Try to save. Verify you can save it
Search for the Process Request created at the beginning of the test plan before applying the fix.
Set Run immediately
Schedule the process.
Verify an error is shown in the Process Monitor.
|
|
|
|
|
Test Plan above verified.
Issue can be closed after tech review. |
|
|
|
(0080864)
|
|
hgbot
|
|
2015-10-07 16:47
|
|
Repository: erp/devel/pi
Changeset: 9bcc5cdaf9996b5bb29aee3422f66f79c589f039
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Sep 30 16:13:10 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9bcc5cdaf9996b5bb29aee3422f66f79c589f039 [^]
Fixed bug 30815: Scheduled Organization for Costing background process
The Costing Background Process should only be scheduled for a legal entity or any of its ancestor.
The fix adds a validation in both the ProcessRequestEventHandler, so each time a record is saved/updated the validation is run, and in the CostingBackground class itself to control wrong process request scheduled before this validation.
---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/event/ProcessRequestEventHandler.java
---
|
|
|
|
|
|
|
|
|
|