0030807: review login in AdvancedQueryBuilder.substituteContextParameters

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030807

Openbravo ERP

A. Platform

public

2015-09-09 17:10

2022-02-01 08:09

Reporter

alostale

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0030807: review login in AdvancedQueryBuilder.substituteContextParameters

Description

Logic in org.openbravo.service.json.AdvancedQueryBuilder.substituteContextParameters method should be reviewed.

There are 2 cases where might be incorrect:

1. Value is tried to be obtained first from session and after from request, request should be more specific than session so it should be done in the other way around. Though this change needs to be carefully verified from the functional point of view.
2. In case it is used for a wherclause in a selector invoked from a P&E opened from a window, tab and window ids are incorrectly obtained (they should be retrieved from inpTabId and inpWindowId request parameters instead of from tabId and windowId ones), this makes that when the value is tried to be obtained from session to be got always from session context not being able to check stored in session fields in the opening tab. Doing this change is not trivial because some values (such as isSoTrx used in Action Regading Document field in Add Payment P&E) to be changed from true to Y making the selector not to show the proper values

Steps To Reproduce

Case 1 cannot be reproduced within current distribution
Case 2 was reproducible before fix for 0030623

Proposed Solution

Additional Information