Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030804Retail ModulesWeb POSpublic2015-09-09 15:592015-10-19 18:32
Reporteraaroncalero 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression levelCoding ( Testing )
Regression date2015-07-16
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f829ed7fe8cc [^]
Triggers an Emergency PackNo
Summary0030804: The sales representative combo on the receipt properties popup is never loaded
DescriptionWhen the Web POS Use Modal instead of dropdown in Sales Reprentative property is set to N (and, until the issue 0030803, the user role is manual), the sales representative selection is done via a combo field.
However this field is never loaded and it is not possible to assign a sales representative to the ticket.
Steps To ReproduceEnsure in backend that the Web POS Use Modal instead of dropdown in Sales Reprentative property is set to N.
Login in web pos with an automatic-role user.
Open the receipt properties popup (Menu > Receipt Properties).
Verify that the sales representative combo is empty.
Verify in local database that the ad_sales_representative table is not empty.

The loadValue() function of the salesRepresentativeBox component (modalreceiptproperties.js file) has been purposedly overrided to prevent data to be loaded.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030806 closed jorge-garcia The default sales representative is by default the current logged user, even if it not a Sales representative 
related to defect 0032230 closed Sandrahuguet [HGVOL] Wrong requests to SalesRepresentative model 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-09 15:59aaroncaleroNew Issue
2015-09-09 15:59aaroncaleroAssigned To => Retail
2015-09-09 15:59aaroncaleroOBNetwork customer => No
2015-09-09 15:59aaroncaleroTriggers an Emergency Pack => No
2015-09-15 11:54aaroncaleroRegression level => Coding ( Testing )
2015-09-15 11:54aaroncaleroRegression date => 2015-07-16
2015-09-15 11:54aaroncaleroRegression introduced in release => pi
2015-09-15 11:54aaroncaleroRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f829ed7fe8cc [^]
2015-09-16 10:38guillermogilOBNetwork customerNo => Yes
2015-09-16 10:38guillermogilResolution time => 1442872800
2015-09-21 23:45mtaalAssigned ToRetail => mtaal
2015-09-23 12:53hgbotCheckin
2015-09-23 12:53hgbotNote Added: 0080576
2015-09-23 12:53hgbotStatusnew => resolved
2015-09-23 12:53hgbotResolutionopen => fixed
2015-09-23 12:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/938e86e58134784639f08e06ac35481d8f09091d [^]
2015-09-23 12:54hgbotCheckin
2015-09-23 12:54hgbotNote Added: 0080582
2015-09-23 12:54hgbotCheckin
2015-09-23 12:54hgbotNote Added: 0080584
2015-09-23 12:54hgbotCheckin
2015-09-23 12:54hgbotNote Added: 0080586
2015-09-23 12:54hgbotCheckin
2015-09-23 12:54hgbotNote Added: 0080588
2015-09-25 11:07OrekariaReview Assigned To => guilleaer
2015-09-29 09:15guilleaerNote Added: 0080683
2015-09-29 09:15guilleaerStatusresolved => closed
2015-09-29 09:15guilleaerFixed in Version => RR15Q4
2015-10-19 18:32OrekariaRelationship addedrelated to 0030806
2016-02-15 13:22SandrahuguetRelationship addedrelated to 0032230

Notes
(0080576)
hgbot   
2015-09-23 12:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 938e86e58134784639f08e06ac35481d8f09091d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:19:19 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/938e86e58134784639f08e06ac35481d8f09091d [^]

Fixes issue 30804: The sales representative combo on the receipt properties popup is never loaded
Load the values when the combo is shown

---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
---
(0080582)
hgbot   
2015-09-23 12:54   
Repository: tools/automation/pi-mobile
Changeset: f6898a68253f4b252980884f5fbe8a0d3531b7db
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:12:20 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f6898a68253f4b252980884f5fbe8a0d3531b7db [^]

Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Added test for showing modal and combo and setting sales rep

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
(0080584)
hgbot   
2015-09-23 12:54   
Repository: tools/automation/pi-mobile
Changeset: d99250add999dc8e8b1b93cd5932ef6c7fc7678d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:35:19 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d99250add999dc8e8b1b93cd5932ef6c7fc7678d [^]

Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Remove system.err, check import entries

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
(0080586)
hgbot   
2015-09-23 12:54   
Repository: tools/automation/pi-mobile
Changeset: 705f14a67f202ff9dafd5666888a082df86d52c3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 07:24:14 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/705f14a67f202ff9dafd5666888a082df86d52c3 [^]

Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Moved test, changes to handle oracle, adapted rejectquotations to handle returned value from getcontent

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30804_SetSalesRepCombo.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
(0080588)
hgbot   
2015-09-23 12:54   
Repository: tools/automation/pi-mobile
Changeset: 48807c49debff424da91cd61ee04e6be04530b39
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 10:32:24 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/48807c49debff424da91cd61ee04e6be04530b39 [^]

Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Change as for combos the value is returned not the label text

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
---
(0080683)
guilleaer   
2015-09-29 09:15   
code reviewed and tested