Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0030803 | Retail Modules | Web POS | public | 2015-09-09 15:49 | 2015-09-29 09:24 |
|
| Reporter | aaroncalero | |
| Assigned To | mtaal | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | RR15Q4 | |
| Merge Request Status | |
| Review Assigned To | guilleaer |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0030803: The Web POS Use Modal instead of dropdown in Sales Reprentative preference cannot be used with automatic roles |
| Description | The Web POS Use Modal instead of dropdown in Sales Reprentative preference controls if the field to add a sales representative to a ticket in WebPOS is done via a combo box or a modal popup.
When the role of the logged user is an automatic role, the preference is always considered to be true and the modal popup is used. |
| Steps To Reproduce | Login in https://livebuilds.openbravo.com/retail_pi_pgsql/ [^] and verify that the value of the preference is N for the White Valley client.
Login in WebPOS with an automatic-role user (vallblanca, Openbravo, demoUser) and verify that, on the receipt properties popup (Menu > Receipt Properties) a button to display the modal popup is shown on the Sales Representative field, even if the preference is set to N. |
| Proposed Solution | The code using the preference is the following:
if (!OB.MobileApp.model.hasPermission(this.permissionOption)) {
this.parent.parent.parent.hide();
}
Which doesn't check if the role of the user is manual or not. Change it with:
if (!OB.MobileApp.model.hasPermission(this.permissionOption, true)) {
this.parent.parent.parent.hide();
}
To verify the preference even if the role is automatic. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-09-09 15:49 | aaroncalero | New Issue | |
| 2015-09-09 15:49 | aaroncalero | Assigned To | => Retail |
| 2015-09-09 15:49 | aaroncalero | Triggers an Emergency Pack | => No |
| 2015-09-09 15:50 | aaroncalero | Reproducibility | have not tried => always |
| 2015-09-16 10:38 | guillermogil | Resolution time | => 1442872800 |
| 2015-09-21 23:57 | mtaal | Assigned To | Retail => mtaal |
| 2015-09-23 12:53 | hgbot | Checkin | |
| 2015-09-23 12:53 | hgbot | Note Added: 0080577 | |
| 2015-09-23 12:53 | hgbot | Status | new => resolved |
| 2015-09-23 12:53 | hgbot | Resolution | open => fixed |
| 2015-09-23 12:53 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5338904fa44ea9b5362f0eac3a64d8986231e89b [^] |
| 2015-09-23 12:53 | hgbot | Checkin | |
| 2015-09-23 12:53 | hgbot | Note Added: 0080578 | |
| 2015-09-23 12:54 | hgbot | Checkin | |
| 2015-09-23 12:54 | hgbot | Note Added: 0080583 | |
| 2015-09-23 12:54 | hgbot | Checkin | |
| 2015-09-23 12:54 | hgbot | Note Added: 0080585 | |
| 2015-09-23 12:54 | hgbot | Checkin | |
| 2015-09-23 12:54 | hgbot | Note Added: 0080587 | |
| 2015-09-23 12:54 | hgbot | Checkin | |
| 2015-09-23 12:54 | hgbot | Note Added: 0080589 | |
| 2015-09-26 23:43 | Orekaria | Review Assigned To | => guilleaer |
| 2015-09-29 09:24 | guilleaer | Note Added: 0080684 | |
| 2015-09-29 09:24 | guilleaer | Status | resolved => closed |
| 2015-09-29 09:24 | guilleaer | Fixed in Version | => RR15Q4 |
|
Notes |
|
|
(0080577)
|
|
hgbot
|
|
2015-09-23 12:53
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5338904fa44ea9b5362f0eac3a64d8986231e89b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:20:30 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5338904fa44ea9b5362f0eac3a64d8986231e89b [^]
Fixes issue 30803: The Web POS Use Modal instead of dropdown in Sales Reprentative preference cannot be used with automatic roles
Handle automatic roles also in showing the combo
---
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
M web/org.openbravo.retail.posterminal/js/components/salesrepresentative.js
---
|
|
|
|
(0080578)
|
|
hgbot
|
|
2015-09-23 12:53
|
|
|
|
|
(0080583)
|
|
hgbot
|
|
2015-09-23 12:54
|
|
Repository: tools/automation/pi-mobile
Changeset: f6898a68253f4b252980884f5fbe8a0d3531b7db
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:12:20 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f6898a68253f4b252980884f5fbe8a0d3531b7db [^]
Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Added test for showing modal and combo and setting sales rep
---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/EnyoNode.java
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
|
|
|
|
(0080585)
|
|
hgbot
|
|
2015-09-23 12:54
|
|
Repository: tools/automation/pi-mobile
Changeset: d99250add999dc8e8b1b93cd5932ef6c7fc7678d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 00:35:19 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d99250add999dc8e8b1b93cd5932ef6c7fc7678d [^]
Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Remove system.err, check import entries
---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
|
|
|
|
(0080587)
|
|
hgbot
|
|
2015-09-23 12:54
|
|
Repository: tools/automation/pi-mobile
Changeset: 705f14a67f202ff9dafd5666888a082df86d52c3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 07:24:14 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/705f14a67f202ff9dafd5666888a082df86d52c3 [^]
Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Moved test, changes to handle oracle, adapted rejectquotations to handle returned value from getcontent
---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30804_SetSalesRepCombo.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30804_SetSalesRepCombo.java
---
|
|
|
|
(0080589)
|
|
hgbot
|
|
2015-09-23 12:54
|
|
Repository: tools/automation/pi-mobile
Changeset: 48807c49debff424da91cd61ee04e6be04530b39
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 23 10:32:24 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/48807c49debff424da91cd61ee04e6be04530b39 [^]
Related to issue 30804, related to issue 30803: The sales representative combo on the receipt properties popup is never loaded
Change as for combos the value is returned not the label text
---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
---
|
|
|
|
|
|