Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030802Retail ModulesWeb POSpublic2015-09-09 13:512015-09-16 22:40
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030802: When a service name content is in executed service name(different from compared service) fails
DescriptionIn ob-requestrouter.js

when looking for the service, we are looking for the contain of the name instead of comparing the whole name.

See:

service = _.filter(OB.RR.RequestRouter.availableServices.models, function (srvc) {
          return serviceName.indexOf(srvc.get('name')) !== -1;
        })[0];

Steps To ReproduceCreate a servlet with the name org.openbravo.retail.posterminal.ProcessCashCloseSlave.

You will see that org.openbravo.retail.posterminal.ProcessCashClose is executed instead of org.openbravo.retail.posterminal.ProcessCashCloseSlave.
Proposed Solutionuse === instead of indexOf
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0030778 closed jorge-garcia Cash UP Partial crashes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-09 13:51migueldejuanaNew Issue
2015-09-09 13:51migueldejuanaAssigned To => migueldejuana
2015-09-09 13:51migueldejuanaTriggers an Emergency Pack => No
2015-09-09 13:56jorge-garciaRelationship addeddepends on 0030778
2015-09-11 12:27hgbotCheckin
2015-09-11 12:27hgbotNote Added: 0080335
2015-09-11 12:27hgbotStatusnew => resolved
2015-09-11 12:27hgbotResolutionopen => fixed
2015-09-11 12:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1eed1fe046f420911f0a74bf8ecec3dddfeb00d1 [^]
2015-09-15 14:09mtaalReview Assigned To => mtaal
2015-09-16 22:40mtaalNote Added: 0080446
2015-09-16 22:40mtaalStatusresolved => closed
2015-09-16 22:40mtaalFixed in Version => RR15Q4

Notes
(0080335)
hgbot   
2015-09-11 12:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1eed1fe046f420911f0a74bf8ecec3dddfeb00d1
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 11 09:21:03 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1eed1fe046f420911f0a74bf8ecec3dddfeb00d1 [^]

Fixed issue 0030802: When a service name content is in executed service name(different from compared service) fails

In case of having more than one service, get longest name service. Longest name service will be the most similar to serviceName

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0080446)
mtaal   
2015-09-16 22:40   
Tested and reviewed