0030783: reduce the number of clicks to print documents - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0030783

Openbravo ERP

A. Platform

public

2015-09-07 15:51

2015-11-23 21:16

Reporter

alostale

Assigned To

NaroaIriarte

Priority

urgent

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Target Version

Fixed in Version

3.0PR16Q1

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

38182

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0030783: reduce the number of clicks to print documents

Description

When printing documents (ie. Sales Order) several clicks need to be performed in order to get the final printed document.

This can be annoying when it needs to be repeated quite often.

Steps To Reproduce

Open a Sales Order:

1. Click on print button in toolbar
2. Decide whether document is going to be saved as attachment
3. Open downloaded document with a pdf viewer
4. Open print dialog
5. Click on print option

Proposed Solution

Define 2 new preferences:

1. Save as attachment. When it is defined (Y/N), popup asking if the document will be attached will be bypassed, so 2nd click will be saved.
2. Direct print. When it is defined, the document will not be downloaded but instead the browser's print dialog will be shown allowing to print the document.

Having these 2 new preferences configured the flow to print would be reduced to 2 clicks:

1. Click on print button in toolbar
2. Click print in the browser's print dialog

Additional Information

Tags

No tags attached.

Relationships

has duplicate	feature request	0025722		closed	AugustoMauch	Ability to hide the previous pop-up when printing a document
related to	feature request	0023249		new	Triage Platform Base	It would be great to have the possibility of printing the reports directly to a printer
related to	defect	0031317		closed	NaroaIriarte	Unexpected error thrown in the log having the Direct Print preference enabled
related to	defect	0031397		closed	platform	Direct Print is not working on MS Edge
causes	defect	0031344		closed	NaroaIriarte	The email option does not work if the Attach by default preference is set.
causes	defect	0032541		closed	caristu	invoice report can not be printed by manual roles
causes	defect	0033222		closed	caristu	ConcatPDFReport has a null pointer exception if is used without reportConfiguration parameter

Attached Files

diff

issue30783.diff (17,073) 2015-09-25 09:50
https://issues.openbravo.com/file_download.php?file_id=8483&type=bug

Issue History

Date Modified

Username

Field

Change

2015-09-07 15:51

New Issue

2015-09-07 15:51

Assigned To

=> platform

2015-09-07 15:51

OBNetwork customer

=> Yes

2015-09-07 15:51

Modules

=> Core

2015-09-07 15:51

Triggers an Emergency Pack

=> No

2015-09-07 15:51

Status

new => scheduled

2015-09-07 15:51

Assigned To

platform => NaroaIriarte

2015-09-08 12:01

Support ticket

=> 38182

2015-09-08 12:01

Resolution time

=> 1442527200

2015-09-08 12:01

Reproducibility

N/A => always

2015-09-14 17:24

Issue Monitored: ngarcia

2015-09-14 17:24

Relationship added

related to 0023249

2015-09-25 09:50

File Added: issue30783.diff

2015-09-25 09:51

Note Added: 0080635

2015-09-28 17:07

Note Added: 0080671

2015-10-27 15:03

Checkin

2015-10-27 15:03

Note Added: 0081353

2015-10-27 15:03

Status

scheduled => resolved

2015-10-27 15:03

Resolution

open => fixed

2015-10-27 15:03

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/cbf2d65774b8afda5265c76b78642271a0a7246a [^]

2015-10-28 08:16

Review Assigned To

=> alostale

2015-10-28 08:29

Note Edited: 0080671

bug_revision_view_page.php?bugnote_id=0080671#r9945

2015-10-28 08:32

Note Added: 0081361

2015-10-28 08:32

Status

resolved => closed

2015-10-28 08:32

Fixed in Version

=> 3.0PR16Q1

2015-10-28 09:08

Relationship added

has duplicate 0025722

2015-10-28 09:24

Note Added: 0081364

2015-10-30 14:26

Relationship added

related to 0031317

2015-11-03 17:41

Relationship added

causes 0031344

2015-11-06 15:18

Relationship added

related to 0031397

2015-11-23 21:16

Checkin

2015-11-23 21:16

Note Added: 0082161

2016-03-23 15:57

Relationship added

causes 0032541

2016-06-13 08:52

Relationship added

causes 0033222

Notes

Repository: erp/devel/pi
Changeset: cbf2d65774b8afda5265c76b78642271a0a7246a
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Oct 27 11:20:34 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cbf2d65774b8afda5265c76b78642271a0a7246a [^]

Fixed issue 30783: Reduce the number of clicks to print Documents.

Before, when a document was going to be printed, several clicks were needed.
That was because when you click on the print button, a popup which asks if
you wanted to attach the document or just print it appear, and after it was possible to print.

The number of clicks needed for that task could be bothering if it was often repeated:.

To fix this two new preferences have been added.
The first one "Attach by default": If this preference is set to "N" then, the popup is not
shown when clicking the print button, and the document is not attached.
If this preference is set to "Y" then, the popup is not shown when clicking the print button
and the document is attached.
If this preference is undefined, then, the popup which asks for attaching the document or just printing
it appears when clicking the print button.

The other preference "Direct Print": If this is set as "Y" then the printing popup will be
opened.
If this is set as "N" or undefined, then the document is downloaded, but the printing popup is not shown.
The "ReportingUtils.java" has been modified, now if the direct print preference is set, the "this.print()" js function
is executed.
The "PrinterReports.java" has been modified for handling the new functionality with the preference which
attaches the documents directly.
The "PrintController.java" has been modified for handling the new functionality with the Direct print
preference.

The index.jsp has been changed because there was a problem with some browsers and the "Direct print" preference
it was not possible to display the printer popup in Internet Explorer nor Firefox.
This was because we were using a hidden frame for putting the pdf there. Chrome was able to take what there was in
that frame, but Firefox and Internet Explorer were not able.
To fix this the style="display:none" of the frame "background_target" has been removed.
Now, it is possible to use the Direct Print preference in the Firefox, Safari, Internet Explorer and Chrome browsers.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/index.jsp
M src/org/openbravo/erpCommon/businessUtility/PrinterReports.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---