Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030768Retail ModulesWeb POSpublic2015-09-04 16:012015-09-18 16:39
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date2015-08-22
Regression introduced in releasepi
Regression introduced by commit9a602b16dabd
Triggers an Emergency PackNo
Summary0030768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
DescriptionWhen creating a new customer the locId field in the customer gets a strange uuid like this:
"C587.F61CF569.FAB15F75.ED6D45CA.3F1F530F.D9A6DDA5.C8B171BF.5B5F570C.5B2D"

This is caused by a change done in this commit, line:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9a602b16dabd#l1.7 [^]

The UUID generated is wrong as it is not 32 characters anymore.
Steps To ReproduceCreate a new customer, check the c_bpartnerlocation_id in the websql database.

Notice also that there are 2 get_uuid functions in the system. We should only have one implementation.
Proposed SolutionCreate one version of the get_uuid method.
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0030450RR15Q4 closed Orekaria Stabilization: RR15Q4 jsLint related fixes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-04 16:01mtaalNew Issue
2015-09-04 16:01mtaalAssigned To => mtaal
2015-09-04 16:01mtaalRegression date => 2015-08-22
2015-09-04 16:01mtaalRegression introduced in release => pi
2015-09-04 16:01mtaalRegression introduced by commit => 9a602b16dabd
2015-09-04 16:01mtaalTriggers an Emergency Pack => No
2015-09-04 16:10mtaalRelationship addedcaused by 0030450
2015-09-08 08:51hgbotCheckin
2015-09-08 08:51hgbotNote Added: 0080226
2015-09-08 08:51hgbotStatusnew => resolved
2015-09-08 08:51hgbotResolutionopen => fixed
2015-09-08 08:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b70a1ab96f2fcdd9cee9f55fb5a7e4d7ffc2f34b [^]
2015-09-08 08:51hgbotCheckin
2015-09-08 08:51hgbotNote Added: 0080230
2015-09-08 08:52hgbotCheckin
2015-09-08 08:52hgbotNote Added: 0080234
2015-09-12 00:55hgbotCheckin
2015-09-12 00:55hgbotNote Added: 0080352
2015-09-16 21:01OrekariaNote Added: 0080442
2015-09-16 21:01OrekariaStatusresolved => new
2015-09-16 21:01OrekariaResolutionfixed => open
2015-09-16 21:01OrekariaNote Edited: 0080442bug_revision_view_page.php?bugnote_id=0080442#r9446
2015-09-16 21:01OrekariaNote Edited: 0080442bug_revision_view_page.php?bugnote_id=0080442#r9447
2015-09-16 21:02OrekariaNote Edited: 0080442bug_revision_view_page.php?bugnote_id=0080442#r9448
2015-09-16 21:02OrekariaNote Edited: 0080442bug_revision_view_page.php?bugnote_id=0080442#r9449
2015-09-18 08:59hgbotCheckin
2015-09-18 08:59hgbotNote Added: 0080480
2015-09-18 08:59hgbotStatusnew => resolved
2015-09-18 08:59hgbotResolutionopen => fixed
2015-09-18 08:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b70a1ab96f2fcdd9cee9f55fb5a7e4d7ffc2f34b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3a28c7fb2ee8862d4e3a467ca80c9e068830c04b [^]
2015-09-18 09:00hgbotCheckin
2015-09-18 09:00hgbotNote Added: 0080481
2015-09-18 16:39OrekariaReview Assigned To => Orekaria
2015-09-18 16:39OrekariaStatusresolved => closed
2015-09-18 16:39OrekariaFixed in Version => RR15Q4

Notes
(0080226)
hgbot   
2015-09-08 08:51   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b70a1ab96f2fcdd9cee9f55fb5a7e4d7ffc2f34b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 04 16:35:24 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b70a1ab96f2fcdd9cee9f55fb5a7e4d7ffc2f34b [^]

Fixes issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
Deprecate OB.Dal.get_uuid, use OB.UTIL.get_UUID, repair wrong expression use | instead of ||

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-filterbuilder.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0080230)
hgbot   
2015-09-08 08:51   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1107e2ac87f975c247b040bffeb3e2b8d8e9a64e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Sep 07 12:43:38 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1107e2ac87f975c247b040bffeb3e2b8d8e9a64e [^]

Related to issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
Added comment in the code and jslint directive

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0080234)
hgbot   
2015-09-08 08:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cdd3917c7890a4bb4d43e58b89df742307614bdf
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 04 16:19:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cdd3917c7890a4bb4d43e58b89df742307614bdf [^]

Related to issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
Change call to OB.dal.get_uuid to OB.UTIL.get_UUID

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0080352)
hgbot   
2015-09-12 00:55   
Repository: tools/automation/pi-mobile
Changeset: ee9ac7fd53773f08e0f5b3241b3e7ddfa315eb4c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 09 23:25:24 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ee9ac7fd53773f08e0f5b3241b3e7ddfa315eb4c [^]

Related to issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
Added automated testcase

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I30768_CheckUUIDGeneration.java
---
(0080442)
Orekaria   
2015-09-16 21:01   
(edited on: 2015-09-16 21:02)
The OB.UTIL.get_UUID is defined after it can be used: verify that in the generated javascript the OB.UTIL.get_UUID line is present in the line 8958 but there are references to it before it is defined. e.g: OB.Dal.get_uuid, line 2207

This could lead to an undefined value returned by the function and empty uuids being used, e.g for new database records

Action: move the logic to the OB.Dal.get_uuid method or check the 'MobileCoreComponentProvider.java' file and be sure that the function is defined before 'ob.dal.js'
(0080480)
hgbot   
2015-09-18 08:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3a28c7fb2ee8862d4e3a467ca80c9e068830c04b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 16 23:19:44 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3a28c7fb2ee8862d4e3a467ca80c9e068830c04b [^]

Fixes issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
load ob-utilities before ob-dal to ensure that get_UUID function is available

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0080481)
hgbot   
2015-09-18 09:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 04343b99bbedb683fe3959d1dbc8b625c60f2ceb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Sep 17 19:06:58 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/04343b99bbedb683fe3959d1dbc8b625c60f2ceb [^]

Related to issue 30768: OB.Util.get_UUID method returns strange UUIDs, causes errors when saving addresses, resolve duplicate code
Add deprecation code for the OB.Dal.get_uuid method

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/main.js
---