Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030761Openbravo ERPA. Platformpublic2015-09-04 09:532015-11-23 21:16
Reporteralostale 
Assigned ToNaroaIriarte 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030761: product characteristics popup shows all values without filtering out previous filters
DescriptionWhen using any FK filter, the values displayed in the drop down are restricted by the other filters applied in the current grid.

This is not the case for product characteristics where the whole tree is always shown.

In environments with a big number of characteristics this becomes a usability issue.
Steps To ReproduceUse case:

1. Configuration
1.1. Define a Color variant characteristic
1.2. Add 1K values to this charcateristic
1.3. Create a generic product A using this characteristic
1.4. Create products based on generic A for only 20 values of the 1K list
1.5. Create a generic product B using this characteristic
1.6. Create products based on generic 6 for only 20 values of the 1K list (different ones than the used in step 1.4)

2. Usage
2.1. Go to Product window
2.2. Filter by Generic Product A
2.3. Open Product Characteristics popup to filter by Color
  -> Note there are 1K nodes which makes very hard to find the correct one, mainly taking into account that only 20 of them are applicable
Proposed SolutionProduct Characteristics filter popup should behave in the same way the rest of FK filters do, restricting the values to the previously applied filters.

Feature 0029612 should be taken into account allowing to configure this field to behave as it currently does displaying all values.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0029612 closed AugustoMauch Extend the grid configuration to improve the performance of the population of foreign key dropdowns 
related to feature request 0030763 new Triage Platform Base unusable product characteristics popup when having many characteristics 
related to defect 0038422 closed jarmendariz Characteristic description selector included in a process definition not showing values when a filter is set 
Attached Files? issue30761.export (17,718) 2015-09-04 13:51
https://issues.openbravo.com/file_download.php?file_id=8421&type=bug
diff relatedIssue30761.diff (2,011) 2015-09-04 14:16
https://issues.openbravo.com/file_download.php?file_id=8423&type=bug
? 30761-custom-hql-selector.export (13,204) 2015-09-07 09:58
https://issues.openbravo.com/file_download.php?file_id=8427&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-09-04 09:53alostaleNew Issue
2015-09-04 09:53alostaleAssigned To => platform
2015-09-04 09:53alostaleModules => Core
2015-09-04 09:53alostaleTriggers an Emergency Pack => No
2015-09-04 09:53alostaleStatusnew => scheduled
2015-09-04 09:53alostaleAssigned Toplatform => NaroaIriarte
2015-09-04 09:54alostaleTarget Version => 3.0PR16Q1
2015-09-04 10:02alostaleRelationship addedrelated to 0030763
2015-09-04 10:15alostaleRelationship addedrelated to 0029612
2015-09-04 10:16alostaleProposed Solution updated
2015-09-04 13:51NaroaIriarteFile Added: issue30761.export
2015-09-04 13:52NaroaIriarteNote Added: 0080123
2015-09-04 14:16NaroaIriarteFile Added: relatedIssue30761.diff
2015-09-04 14:18NaroaIriarteNote Added: 0080125
2015-09-04 14:27NaroaIriarteNote Edited: 0080123bug_revision_view_page.php?bugnote_id=0080123#r9362
2015-09-07 09:58alostaleFile Added: 30761-custom-hql-selector.export
2015-09-07 10:03alostaleNote Added: 0080172
2015-10-19 10:43alostaleReview Assigned To => AugustoMauch
2015-10-19 10:43hgbotCheckin
2015-10-19 10:43hgbotNote Added: 0081065
2015-10-19 10:43hgbotCheckin
2015-10-19 10:43hgbotNote Added: 0081066
2015-10-19 10:43hgbotCheckin
2015-10-19 10:43hgbotNote Added: 0081067
2015-10-19 10:43hgbotStatusscheduled => resolved
2015-10-19 10:43hgbotResolutionopen => fixed
2015-10-19 10:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7adf844c1fb504476fd44cafdb34100f3687cae3 [^]
2015-10-20 16:44AugustoMauchNote Added: 0081140
2015-10-20 16:44AugustoMauchStatusresolved => closed
2015-10-20 16:44AugustoMauchFixed in Version => 3.0PR16Q1
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082131
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082132
2015-11-23 21:16hudsonbotCheckin
2015-11-23 21:16hudsonbotNote Added: 0082133
2018-04-26 16:45jarmendarizRelationship addedrelated to 0038422

Notes
(0080123)
NaroaIriarte   
2015-09-04 13:52   
(edited on: 2015-09-04 14:27)
The export for the issue has been attached "issue30761.export".
(0080125)
NaroaIriarte   
2015-09-04 14:18   
A diff called "relatedIssue30761.diff" has been attached, the aim of this fix is to be able to take into account the grid configuration project regarding to the filtering of foreign key combos.
(0080172)
alostale   
2015-09-07 10:03   
30761-custom-hql-selector.export takes into account parent grid for selectors based on a custom HQL
(0081065)
hgbot   
2015-10-19 10:43   
Repository: erp/devel/pi
Changeset: d4876fe991ad90afe2580a1d629d4183efa2fd2e
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Sep 04 13:43:38 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d4876fe991ad90afe2580a1d629d4183efa2fd2e [^]

related to issue 30761: Product characteristics popup does not work properly

If any FK filter is used, the values shown in the other filters are restricted by them. This was not
happening with the product characteristics popu. In this case the whole tree was shown.

To fix this some steps have been done.
First of all it was necessary to change the where clause to take into account the filters applied in the grid.
On the other hand it has been necessary to take into account when a filter was applied in the "Product Characteristics"
column, because if at first you choose a value of a product characteristic, the second time you open the popup of
product characteristics, it is not possible to see any other product characteristic but the one previously chosen. That
was not working fine, it only has to take into account the filters applied in the grid.
To fix this, the product characteristics criteria has been removed if it existed one, and these all changes make possible to
have the values of the product characteristics filtered applying the filters of the grid but not taking into account the value
chosen in the first moment in the product characteristics popup.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-characteristics.js
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataEntityQueryService.java
M src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java
---
(0081066)
hgbot   
2015-10-19 10:43   
Repository: erp/devel/pi
Changeset: 5392e884b08e472d4c3044abd8d1a75cca1a93ba
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Oct 19 09:41:59 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5392e884b08e472d4c3044abd8d1a75cca1a93ba [^]

related to issue 30761: improved product characteristics selector

  Take into account grid configuration in product characteristics selector, to
  make it work in the same manner other selectors do:
   - By default grid filter critieria is applied
   - It can be configured not to apply any criteria

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-characteristics.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/CharacteristicsUIDefinition.java
---
(0081067)
hgbot   
2015-10-19 10:43   
Repository: erp/devel/pi
Changeset: 7adf844c1fb504476fd44cafdb34100f3687cae3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 07 09:58:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7adf844c1fb504476fd44cafdb34100f3687cae3 [^]

fixed issue 30761: product characteristics popup shows all values

  Filter out values in product characteristics popup when the parent grid is a
  selector based on a custom HQL query.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-characteristics.js
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
M src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java
---
(0081140)
AugustoMauch   
2015-10-20 16:44   
Code reviewed and verified in pi@7adf844c1fb5
(0082131)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082132)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082133)
hudsonbot   
2015-11-23 21:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test