Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030738Retail ModulesWeb POSpublic2015-09-02 12:412016-02-01 09:37
Reporteradrianromero 
Assigned Tomtaal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelCoding ( Testing )
Regression date
Regression introduced in releasepi
Regression introduced by commit459d9e531882
Triggers an Emergency PackNo
Summary0030738: Creating a new customer and assigning to the current receipt raises an error in taxes calculation
DescriptionIn a new receipt a new customer created in POS and adding a product generates an error in taxes calculation.

This only happens in https://livebuilds.openbravo.com/retail_stable_pgsql_pi [^] .
3.0RR15Q3 works OK
Steps To Reproduce* login into https://livebuilds.openbravo.com/retail_stable_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
* Tap on the Customer button
* Tap on * New Customer
* Fill in the required data and assign the new customer created to the receipt.
* Add a new product to the receipt
* Observe that an error is raised: Cannot calculate receipt taxes
Cannot find taxes for FF80818123B7FC160123B804AB88000B. The line affected will be deleted. Please ensure that there is at least one tax rate and tax rate zone configured for the partner address.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030691RR15Q4 closed mtaal Saving customer address not possible 
caused by defect 0030229 closed guilleaer JS error when location is updated 
blocks defect 0030794 closed Retail It is possible to create a business partner in a higher organization 
Attached Filespng Captura de pantalla de 2015-09-02 17:40:39.png (243,599) 2015-09-02 17:43
https://issues.openbravo.com/file_download.php?file_id=8416&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-09-02 12:41adrianromeroNew Issue
2015-09-02 12:41adrianromeroAssigned To => Retail
2015-09-02 12:41adrianromeroRegression level => Coding ( Testing )
2015-09-02 12:41adrianromeroRegression introduced in release => pi
2015-09-02 12:41adrianromeroTriggers an Emergency Pack => No
2015-09-02 12:47adrianromeroRelationship addedrelated to 0030691
2015-09-02 17:43adrianromeroFile Added: Captura de pantalla de 2015-09-02 17:40:39.png
2015-09-02 17:46adrianromeroNote Added: 0080027
2015-09-04 14:02mtaalAssigned ToRetail => mtaal
2015-09-04 15:52hgbotCheckin
2015-09-04 15:52hgbotNote Added: 0080139
2015-09-04 15:53OrekariaNote Added: 0080140
2015-09-04 16:01mtaalReview Assigned To => guilleaer
2015-09-04 16:01mtaalRegression introduced by commit => 459d9e531882
2015-09-04 16:01mtaalNote Added: 0080141
2015-09-04 16:02mtaalRelationship addedcaused by 0030229
2015-09-07 09:10adrianromeroIssue Monitored: adrianromero
2015-09-07 09:11adrianromeroIssue End Monitor: adrianromero
2015-09-08 08:51hgbotCheckin
2015-09-08 08:51hgbotNote Added: 0080233
2015-09-08 08:51hgbotStatusnew => resolved
2015-09-08 08:51hgbotResolutionopen => fixed
2015-09-08 08:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2228ca97e35122e7525b17186581e8940de1d18 [^]
2015-09-08 13:45OrekariaRelationship addedblocks 0030794
2015-09-08 14:10hgbotCheckin
2015-09-08 14:10hgbotNote Added: 0080244
2015-09-16 14:36guilleaerNote Added: 0080433
2015-09-16 14:36guilleaerNote Deleted: 0080433
2015-09-16 14:37guilleaerNote Added: 0080434
2015-09-16 14:37guilleaerStatusresolved => closed
2015-09-16 14:37guilleaerFixed in Version => RR15Q4
2016-01-22 11:52hgbotCheckin
2016-01-22 11:52hgbotNote Added: 0083559
2016-01-22 11:52hgbotStatusclosed => resolved
2016-01-22 11:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2228ca97e35122e7525b17186581e8940de1d18 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a647b65c57dae85f14c9304f1d4fd8bb4c6650fe [^]
2016-02-01 09:36guilleaerStatusresolved => closed

Notes
(0080027)
adrianromero   
2015-09-02 17:46   
See attached screenshot.

It seems the problem is because the business partner location is stored in the database without 'c_bpartner_id'. The 'c_bpartner_location' record is not related with 'c_bpartner' record.

See other fields are also empty.
(0080139)
hgbot   
2015-09-04 15:52   
Repository: tools/automation/pi-mobile
Changeset: aefb72f76abfc7a5a8ea79f30a506ef2b616e62b
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Sep 04 15:51:47 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/aefb72f76abfc7a5a8ea79f30a506ef2b616e62b [^]

Verifies issue 30738: Added the 'I30738_NewCustomerAddProduct' test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30738_NewCustomerAddProduct.java
---
(0080140)
Orekaria   
2015-09-04 15:53   
The test will be automatically activated when the fix is ready.
Verify that it passes.
(0080141)
mtaal   
2015-09-04 16:01   
Seems to be caused by this line commit:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/459d9e531882#l1.7 [^]

the id and bpartner set was removed.
(0080233)
hgbot   
2015-09-08 08:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e2228ca97e35122e7525b17186581e8940de1d18
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 04 16:02:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e2228ca97e35122e7525b17186581e8940de1d18 [^]

Fixes issue 30738: Creating a new customer and assigning to the current receipt raises an error in taxes calculation
Set the id and bpartner of the location when it is created from the customer save

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0080244)
hgbot   
2015-09-08 14:10   
Repository: tools/automation/pi-mobile
Changeset: 5ce2b4eae16b8a37294e092d62a6f17cb04db943
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Sep 08 13:51:18 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5ce2b4eae16b8a37294e092d62a6f17cb04db943 [^]

Related to issue 30738: The test uses another user

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30738_NewCustomerAddProductUserAccessRights.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30738_NewCustomerAddProduct.java
---
(0080434)
guilleaer   
2015-09-16 14:37   
Tested and Verified
(0083559)
hgbot   
2016-01-22 11:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a647b65c57dae85f14c9304f1d4fd8bb4c6650fe
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 04 16:02:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a647b65c57dae85f14c9304f1d4fd8bb4c6650fe [^]

Fixes issue 30738: Creating a new customer and assigning to the current receipt raises an error in taxes calculation
Set the id and bpartner of the location when it is created from the customer save

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---