Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030698Openbravo ERP07. Sales managementpublic2015-08-28 15:202015-09-01 00:02
ReporterVictorVillar 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket37932
Regression levelPre packaging ( pi )
Regression date2015-07-07
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f893e3c2c041 [^]
Triggers an Emergency PackNo
Summary0030698: It is not possible to add the lines to a Reversal Sales Invoice
DescriptionIt is not possible to add the lines to a Reversal Sales Invoice
Steps To ReproduceAs group admin role,
 Go to Return From Customer window,
   create a new one selecting one Goods shipment. The return qty is: all
   
Complete it
 Go to Return Material Receipt
   select the Return Customer document created before and complete it

Go to Sales Invoice window,
   select the ES Return Material Sales Invoice document.
   Using the Create Lines From, select the Return Material created before.
Realise that is not possible. An error message appears: Process Run Error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0030073 closed AtulOpenbravo Different Alternate Tax Base Amount in a partial invoice from order depending on the process used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-28 15:20VictorVillarNew Issue
2015-08-28 15:20VictorVillarAssigned To => Triage Finance
2015-08-28 15:20VictorVillarOBNetwork customer => Yes
2015-08-28 15:20VictorVillarModules => Core
2015-08-28 15:20VictorVillarSupport ticket => 37932
2015-08-28 15:20VictorVillarRegression level => Pre packaging ( pi )
2015-08-28 15:20VictorVillarTriggers an Emergency Pack => No
2015-08-28 15:20VictorVillarIssue Monitored: networkb
2015-08-28 15:22VictorVillarResolution time => 1440972000
2015-08-31 08:27aferrazAssigned ToTriage Finance => aferraz
2015-08-31 08:28aferrazStatusnew => scheduled
2015-08-31 08:45aferrazRegression date => 2015-07-07
2015-08-31 08:45aferrazRegression introduced in release => pi
2015-08-31 08:45aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f893e3c2c041 [^]
2015-08-31 08:45aferrazRelationship addedcaused by 0030073
2015-08-31 09:50aferrazNote Added: 0079824
2015-08-31 09:50aferrazNote Edited: 0079824bug_revision_view_page.php?bugnote_id=0079824#r9292
2015-08-31 11:42hgbotCheckin
2015-08-31 11:42hgbotNote Added: 0079827
2015-08-31 11:42hgbotStatusscheduled => resolved
2015-08-31 11:42hgbotResolutionopen => fixed
2015-08-31 11:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/65bc9818a9d8854bec417382e13ac733b05ed0b7 [^]
2015-08-31 11:43vmromanosReview Assigned To => vmromanos
2015-08-31 11:43vmromanosNote Added: 0079828
2015-08-31 11:43vmromanosStatusresolved => closed
2015-09-01 00:02hudsonbotCheckin
2015-09-01 00:02hudsonbotNote Added: 0079910

Notes
(0079824)
aferraz   
2015-08-31 09:50   
Test plan 1:

As group admin role,
 Go to Return From Customer window,
   create a new one selecting one Goods shipment. The return qty is: all
   
Complete it
 Go to Return Material Receipt
   select the Return Customer document created before and complete it

Go to Sales Invoice window,
   select the ES Return Material Sales Invoice document.
   Using the Create Lines From, select the Return Material created before.

Realise that process is completed succesfully with Alternate Taxable Amount = Line Net Amount

Test plan 2:

- Login as Group Admin role.
- Set the Entregas IVA 21% as Base Amount = Alternate Tax Base Amount.
- Create a Sales Order with Invoice Terms = After Delivery
- Add two units of a product, change the Alternate Taxable Amount and book it
- Create a Goods Shipment from it and update the quantity received to 1
- Launch the Create Invoice From Orders process for that order and check that Alternate Taxable Amount in Invoice is in proportion of Alternate Taxable Amount of Sales Order Line with respect to the quantity being invoiced.
- Check that if you create the invoice with the Create Lines from process, the Alternate Taxable Amount is same as in the previous step.

Test plan 3:

- Login as Group Admin role.
- Set the Entregas IVA 21% as Base Amount = Alternate Tax Base Amount.
- Create a Sales Order with Invoice Terms = After Delivery
- Add two units of a product, change the Alternate Taxable Amount and book it
- Create a Goods Shipment from it and update the quantity received to 1
- Launch the Generate Invoices process for that order and check that Alternate Taxable Amount in Invoice is in proportion of Alternate Taxable Amount of Sales Order Line with respect to the quantity being invoiced.
- Check that if you create the invoice with the Create Lines from process, the Alternate Taxable Amount is same as in the previous step.
(0079827)
hgbot   
2015-08-31 11:42   
Repository: erp/devel/pi
Changeset: 65bc9818a9d8854bec417382e13ac733b05ed0b7
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Aug 31 09:44:52 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/65bc9818a9d8854bec417382e13ac733b05ed0b7 [^]

Fixes issue 30698: Not possible to add lines to a Reversal Sales Invoice

Related order line getTaxableAmount() is different from null will be checked in CreateFrom to avoid NPE.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
---
(0079828)
vmromanos   
2015-08-31 11:43   
Code review + testing OK
(0079910)
hudsonbot   
2015-09-01 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/880a20775a45 [^]
Maturity status: Test