Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030680Openbravo ERPA. Platformpublic2015-08-26 14:282016-06-17 19:37
Reportercaristu 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Versionpi 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030680: Weld module does not pass 'ant validate.modules'
DescriptionRunning this command in pi shows errors in that module:

ant validate.modules -Dmodule=org.openbravo.base.weld

[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Errors for Validation type: MODULE_ERROR
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] The source directory of the Module JBoss Weld is invalid, it contains directories/files (META-INF) which are not part of the javaPackage of the module: org.openbravo.base.weld
Steps To Reproduceant validate.modules -Dmodule=org.openbravo.base.weld
Proposed SolutionAdd a new validation rule to accept files inside META-INF directory of a module
Additional Information
TagsNo tags attached.
Relationships
related to defect 00298543.0PR15Q4 closed caristu Weld,integration.google & json modules does not pass 'ant validate.modules' 
related to defect 0029855 closed shuehner ant validate modules reads excludeFilter.xml from wrong folder 
related to defect 0033032 closed alostale SystemValidatorTest is executed only for modules in developement 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-26 14:28caristuNew Issue
2015-08-26 14:28caristuAssigned To => platform
2015-08-26 14:28caristuModules => Core
2015-08-26 14:28caristuTriggers an Emergency Pack => No
2015-08-26 14:29caristuDescription Updatedbug_revision_view_page.php?rev_id=9274#r9274
2015-08-26 14:29caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9276#r9276
2015-08-26 14:30caristuRelationship addedrelated to 0029854
2015-08-26 14:34caristuRelationship addedrelated to 0029855
2015-11-10 14:59alostaleStatusnew => acknowledged
2015-11-11 11:37alostalePriorityhigh => normal
2016-04-19 10:00alostaleTarget Version => 3.0PR16Q3
2016-05-24 10:05alostaleStatusacknowledged => scheduled
2016-05-24 10:05alostaleAssigned Toplatform => alostale
2016-05-24 10:05alostaleReview Assigned To => caristu
2016-05-24 10:07hgbotCheckin
2016-05-24 10:07hgbotNote Added: 0086696
2016-05-24 10:07hgbotStatusscheduled => resolved
2016-05-24 10:07hgbotResolutionopen => fixed
2016-05-24 10:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dd83dab87b9ad9fbea7671b2c16ed2af8296e395 [^]
2016-05-24 10:12hgbotCheckin
2016-05-24 10:12hgbotNote Added: 0086697
2016-05-24 11:26alostaleRelationship addedrelated to 0033032
2016-05-26 18:08caristuNote Added: 0086769
2016-05-26 18:08caristuStatusresolved => closed
2016-05-26 18:08caristuFixed in Version => pi
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087560
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087561

Notes
(0086696)
hgbot   
2016-05-24 10:07   
Repository: erp/devel/pi
Changeset: dd83dab87b9ad9fbea7671b2c16ed2af8296e395
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 24 10:04:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dd83dab87b9ad9fbea7671b2c16ed2af8296e395 [^]

fixed issue 30680: Weld module does not pass 'ant validate.modules'

  Created blacklist that allows to define a META-INF directory inside src.

---
M src/org/openbravo/service/system/ModuleValidator.java
---
(0086697)
hgbot   
2016-05-24 10:12   
Repository: erp/devel/pi
Changeset: 22873b1a8ca5e08d835004172bcd3484153dd30c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 24 10:12:04 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/22873b1a8ca5e08d835004172bcd3484153dd30c [^]

related to issue 30680: clean up SystemValidatorTest

  Removed unused (ignored) test cases

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0086769)
caristu   
2016-05-26 18:08   
Code review + testing OK: validation is now successful for Weld module.

Tested on pi@6b69927ae231
(0087560)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087561)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test