Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0030677 | Modules | Add Payment from menu | public | 2015-08-26 12:46 | 2015-11-24 11:26 |
|
| Reporter | maite | |
| Assigned To | aferraz | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | dmiguelez |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0030677: "Display logic for grid column" not working for accounting dimensions |
| Description | "Display logic for grid column" not working for accounting dimensions |
| Steps To Reproduce | 1. Access "Client" window an verify that Business Partner and Project dimensions are configured to be shown in Header and Line
2. Access "Dimensions" tab, search by "AR Payment" and "Business Partner" and delete record (to ensure that is configured similar to Project dimension)
3. Logout / login
4. Access "Add Payment" window and "GL Item" section and realize that Business Partner dimension and Project dimension don't directly appear in grid |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0029767 | 3.0PR15Q3 | closed | aferraz | Openbravo ERP | "Display logic for grid column" not working for Organization, Business Partner and Product dimensions | | depends on | feature request | 0031152 | 3.0PR16Q1 | closed | alostale | Openbravo ERP | It would be fine if context could be initialized with a parameter in case FIC has not been executed | | has duplicate | design defect | 0030678 | | closed | platform | Openbravo ERP | "Display logic for grid column" not working when opening a Process Definition directly from Menu |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-08-26 12:46 | maite | New Issue | |
| 2015-08-26 12:46 | maite | Assigned To | => Triage Finance |
| 2015-08-26 12:46 | maite | Resolution time | => 1444946400 |
| 2015-08-26 12:47 | maite | Relationship added | related to 0029767 |
| 2015-08-26 12:47 | maite | Issue Monitored: networkb | |
| 2015-08-26 12:55 | maite | Relationship added | related to 0030678 |
| 2015-08-31 14:53 | aferraz | Assigned To | Triage Finance => aferraz |
| 2015-08-31 14:53 | aferraz | Status | new => scheduled |
| 2015-10-15 10:41 | aferraz | Relationship added | depends on 0031152 |
| 2015-10-20 13:05 | alostale | Note Added: 0081133 | |
| 2015-10-22 08:57 | alostale | Relationship replaced | has duplicate 0030678 |
| 2015-10-22 09:16 | aferraz | Note Added: 0081186 | |
| 2015-10-22 09:33 | hgbot | Checkin | |
| 2015-10-22 09:33 | hgbot | Note Added: 0081189 | |
| 2015-10-22 09:33 | hgbot | Status | scheduled => resolved |
| 2015-10-22 09:33 | hgbot | Resolution | open => fixed |
| 2015-10-22 09:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.finance.addpaymentcreditpaymentsgrid/rev/6bf8dcb163c483da84d33c6fb2006a25a40727eb [^] |
| 2015-10-22 11:38 | psanjuan | Note Edited: 0081186 | bug_revision_view_page.php?bugnote_id=0081186#r9811 |
| 2015-10-22 12:44 | psanjuan | Note Added: 0081204 | |
| 2015-10-26 14:19 | aferraz | Note Added: 0081312 | |
| 2015-10-26 14:20 | aferraz | Note Edited: 0081312 | bug_revision_view_page.php?bugnote_id=0081312#r9872 |
| 2015-10-26 14:20 | aferraz | Note Edited: 0081312 | bug_revision_view_page.php?bugnote_id=0081312#r9873 |
| 2015-10-26 17:34 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-10-26 17:34 | dmiguelez | Note Added: 0081320 | |
| 2015-10-26 17:34 | dmiguelez | Status | resolved => closed |
| 2015-11-24 11:26 | hgbot | Checkin | |
| 2015-11-24 11:26 | hgbot | Note Added: 0082283 | |
|
Notes |
|
|
|
After issue 0031152 is fixed, context info should be calculated in backend and display logic can be invoked to take it into account.
Sample code:
(function () {
var originalOnload = OB.APRM.AddPayment.onLoad
// overwrite onLoad function
OB.APRM.AddPayment.onLoad = function (view) {
originalOnload(view)
// fake callback: here ActionHanlder could be invoked
setTimeout(function () {
console.log('do some magic here')
view.additionalContextInfo = {
newValue: true
}
// we have a new context info, let's reevaluate it for display logic
view.handleDisplayLogicForGridColumns();
}, 100);
}
})() |
|
|
|
(0081186)
|
|
aferraz
|
2015-10-22 09:16
(edited on: 2015-10-22 11:38) |
|
Test plan:
1. Access "Client" window an verify that Business Partner and Project dimensions are configured to be shown in Header and Line
2. Access "Dimensions" tab, search by "AR Receipt" and "Business Partner" and delete record (to ensure that is configured similar to Project dimension)
3. Logout / login
4. Access "Add Payment" window and "GL Item" section and realize that Business Partner dimension and Project dimension appear in grid
Check with any other dimension and for AP Payment and AR Receipt payment types.
|
|
|
|
(0081189)
|
|
hgbot
|
|
2015-10-22 09:33
|
|
Repository: erp/mods/org.openbravo.finance.addpaymentcreditpaymentsgrid
Changeset: 6bf8dcb163c483da84d33c6fb2006a25a40727eb
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Oct 22 09:06:34 2015 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.finance.addpaymentcreditpaymentsgrid/rev/6bf8dcb163c483da84d33c6fb2006a25a40727eb [^]
Fixes issue 30677: "Display logic" not working for Add Payment from Menu
When opening Add Payment process definition directly from Menu, FormInitializationComponent was not called and context was not initialized, so dimension display could not be calculated.
In this case, a new ActionHandler will be called to calculate dimension displays in the backend and initialize the context with them.
---
M web/org.openbravo.finance.addpaymentcreditpaymentsgrid/js/ob-aprmcrg-functions.js
A src/org/openbravo/finance/addpaymentcreditpaymentsgrid/actionhandler/MenuAddPaymentDisplayLogicActionHandler.java
---
|
|
|
|
|
Test Plan above verified.
Checked also with Product dimension. It is shown/not shown in GL items section depending on the Client configuration. |
|
|
|
(0081312)
|
|
aferraz
|
2015-10-26 14:19
(edited on: 2015-10-26 14:20) |
|
New module version with new dependency to core (to include platform fix) will be published as soon as issue 0031152 is promoted to main.
|
|
|
|
|
|
|
|
(0082283)
|
|
hgbot
|
|
2015-11-24 11:26
|
|
|