Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030663Openbravo ERP09. Financial managementpublic2015-08-25 12:182015-09-01 00:02
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030663: Error Reseting Accounting if a table without processing column or with acctdate_column_id null is included in GL configuration
DescriptionError Reseting Accounting if a table without processing column or with acctdate_column_id null is included in GL configuration
Steps To ReproduceAs group admin role:
   Go to General Ledger Configuration and set as Active the ProjectIssue tables for F&B España, S.A. US/A/Euro
   Launch Reset Accounting Process for F&B España, S.A.
   Check the Error Reseting Accounting message is shown and the log raises:
      ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: column "processing" of relation "c_projectissue" does not exist
      
   Go to General Ledger Configuration and set as Active the APRM_Finacc_Transaction_v table for F&B España, S.A. US/A/Euro
   Launch Reset Accounting Process for F&B España, S.A.
   Check the Error Reseting Accounting message is shown, no log is shown
      
      
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028330 closed reinaldoguerra "java.lang.IllegalArgumentException: node to traverse cannot be null!" error when executing Reset Accounting 
related to defect 00281633.0PR15Q1 closed reinaldoguerra "java.lang.IllegalArgumentException: node to traverse cannot be null!" error when trying to Unpost an Order 
related to defect 0023527 closed Sandrahuguet Reset Accounting process is not work properly when Starting and ending dates are filled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-25 12:18ngarciaNew Issue
2015-08-25 12:18ngarciaAssigned To => Triage Finance
2015-08-25 12:18ngarciaOBNetwork customer => Yes
2015-08-25 12:18ngarciaModules => Core
2015-08-25 12:18ngarciaResolution time => 1440626400
2015-08-25 12:18ngarciaTriggers an Emergency Pack => No
2015-08-25 12:18ngarciaIssue Monitored: networkb
2015-08-25 12:33ngarciaRelationship addedrelated to 0028330
2015-08-25 12:34ngarciaRelationship addedrelated to 0028163
2015-08-25 12:34ngarciaRelationship addedrelated to 0023527
2015-08-26 16:54AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-08-27 17:34AtulOpenbravoStatusnew => scheduled
2015-08-27 17:40AtulOpenbravoNote Added: 0079783
2015-08-28 14:45hgbotCheckin
2015-08-28 14:45hgbotNote Added: 0079797
2015-08-28 14:45hgbotStatusscheduled => resolved
2015-08-28 14:45hgbotResolutionopen => fixed
2015-08-28 14:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/48f64615eb3c72ce40fcd72699613cc00784ddfb [^]
2015-08-28 14:46hgbotCheckin
2015-08-28 14:46hgbotNote Added: 0079798
2015-08-28 14:46vmromanosReview Assigned To => vmromanos
2015-08-28 14:46vmromanosNote Added: 0079799
2015-08-28 14:46vmromanosStatusresolved => closed
2015-09-01 00:02hudsonbotCheckin
2015-09-01 00:02hudsonbotNote Added: 0079908
2015-09-01 00:02hudsonbotCheckin
2015-09-01 00:02hudsonbotNote Added: 0079909

Notes
(0079783)
AtulOpenbravo   
2015-08-27 17:40   
Test Plan
- Login as F&B International Group Admin role.
- Navigate to General Ledger Configuration and set as Active the ProjectIssue tables for F&B España, S.A. US/A/Euro
- Launch Reset Accounting Process for F&B España, S.A.
- Check that process is executed successfully.

- Go back to General Ledger Configuration and set as Active the APRM_Finacc_Transaction_v table for F&B España, S.A. US/A/Euro
- Launch Reset Accounting Process for F&B España, S.A.
- Check that process is executed successfully.
(0079797)
hgbot   
2015-08-28 14:45   
Repository: erp/devel/pi
Changeset: 48f64615eb3c72ce40fcd72699613cc00784ddfb
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Aug 27 21:06:55 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/48f64615eb3c72ce40fcd72699613cc00784ddfb [^]

Fixes Issue 30663:Error Reseting Accounting if a table without processing
column or table as view is included in GL configuration

Before running reset accounting queries, table is checked whether its not view
and does it have processing column.

---
M src/org/openbravo/financial/ResetAccounting.java
---
(0079798)
hgbot   
2015-08-28 14:46   
Repository: erp/devel/pi
Changeset: 3b6ed2bbbddc2251f949673f6c968e4fd8b7832c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Aug 28 14:41:57 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3b6ed2bbbddc2251f949673f6c968e4fd8b7832c [^]

Related to issue 30663: code review improvements

Replaced usage of size() by isEmpty(), and added setMaxResults(1) to increase performance.
Ensure we only update the table if the table is not a view

---
M src/org/openbravo/financial/ResetAccounting.java
---
(0079799)
vmromanos   
2015-08-28 14:46   
Code review + testing OK
(0079908)
hudsonbot   
2015-09-01 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/880a20775a45 [^]
Maturity status: Test
(0079909)
hudsonbot   
2015-09-01 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/880a20775a45 [^]
Maturity status: Test