Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030652Retail ModulesWeb POSpublic2015-08-24 14:592016-05-09 11:46
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030652: The JSON column in the Log Client table is redundant, and takes too much space
DescriptionCurrently we are saving the full JSON information in the log client table, and this column is redundant (it's information is already present in the rest of the columns). It should be removed so that the table takes less space.

Also, in the request the information seems to be redundant also, and it could be simplified to consume less bandwidth.
Steps To Reproduce- Login in the POS and do some actions to trigger log messages.
- Verify that in the request to the backend, the information is duplicated.
- Verify that the information in the JSON column in the backend, and the information in the rest of the columns is the same, so the JSON column could be deleted.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030650 new Retail Retail Modules Several issues with LogClient functionality 
depends on backport 0032903RR16Q2 closed ranjith_qualiantech_com Retail Modules The JSON column in the Log Client table is redundant, and takes too much space 
related to design defect 0037702 closed cberner Openbravo ERP Hibernate update/insert to tables containing CLOB sometimes fail on Oracle (HHH-4635) 
Attached Filespatch issue 30652 source mobile.core 2017.patch (23,238) 2016-03-28 14:03
https://issues.openbravo.com/file_download.php?file_id=9207&type=bug
patch issue 30652 source posterminal 6241.patch (1,079) 2016-03-28 14:03
https://issues.openbravo.com/file_download.php?file_id=9208&type=bug
patch issue 30652 Test 5218.patch (2,380) 2016-03-28 14:03
https://issues.openbravo.com/file_download.php?file_id=9209&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-08-24 14:59marvintmNew Issue
2015-08-24 14:59marvintmAssigned To => Retail
2015-08-24 14:59marvintmTriggers an Emergency Pack => No
2015-08-24 14:59marvintmRelationship addedrelated to 0030650
2016-02-09 15:02OrekariaStatusnew => acknowledged
2016-03-16 06:20ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-03-16 06:21ranjith_qualiantech_comStatusacknowledged => scheduled
2016-03-28 14:03ranjith_qualiantech_comFile Added: issue 30652 source mobile.core 2017.patch
2016-03-28 14:03ranjith_qualiantech_comFile Added: issue 30652 source posterminal 6241.patch
2016-03-28 14:03ranjith_qualiantech_comFile Added: issue 30652 Test 5218.patch
2016-04-01 14:11hgbotCheckin
2016-04-01 14:11hgbotNote Added: 0085387
2016-04-01 14:11hgbotCheckin
2016-04-01 14:11hgbotNote Added: 0085388
2016-04-01 14:11hgbotCheckin
2016-04-01 14:11hgbotNote Added: 0085389
2016-04-01 14:11hgbotStatusscheduled => resolved
2016-04-01 14:11hgbotResolutionopen => fixed
2016-04-01 14:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/51f93b1cb56ff2bf45c25602211797831ac71a5f [^]
2016-04-25 18:26marvintmReview Assigned To => marvintm
2016-04-25 18:26marvintmStatusresolved => closed
2016-04-25 18:26marvintmFixed in Version => RR16Q3
2016-05-09 11:46marvintmStatusclosed => new
2016-05-09 11:46marvintmResolutionfixed => open
2016-05-09 11:46marvintmFixed in VersionRR16Q3 =>
2016-05-09 11:46marvintmStatusnew => scheduled
2016-05-09 11:46marvintmStatusscheduled => resolved
2016-05-09 11:46marvintmResolutionopen => fixed
2016-05-09 11:46marvintmStatusresolved => closed
2018-08-09 08:24caristuRelationship addedrelated to 0037702

Notes
(0085387)
hgbot   
2016-04-01 14:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2e43e9489583b780d005e25243bbb89b0a97b1fc
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 01 17:38:41 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e43e9489583b780d005e25243bbb89b0a97b1fc [^]

Related to issue 30652 : Renaming Log client column from "online" to "isOnline"

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0085388)
hgbot   
2016-04-01 14:11   
Repository: tools/automation/pi-mobile
Changeset: a770a3efd7a7dc75c0739354f29aaff44c3ced77
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 01 17:38:22 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a770a3efd7a7dc75c0739354f29aaff44c3ced77 [^]

Verifies issue 30652 : Modifies MobileCoreDatabaseHelper, Removed json column from obmobc_logclient

---
M src-test/org/openbravo/test/mobile/common/selenium/database/MobileCoreDatabaseHelper.java
---
(0085389)
hgbot   
2016-04-01 14:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 51f93b1cb56ff2bf45c25602211797831ac71a5f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Apr 01 17:38:17 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/51f93b1cb56ff2bf45c25602211797831ac71a5f [^]

Fixes issue 30652 : Removing "json" column from Mobile Core Log table

---
M src-db/database/model/tables/OBMOBC_LOGCLIENT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
M web/org.openbravo.mobile.core/source/model/logclient.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---