0030647: Prevent NPE in log when shutting down - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030647

Openbravo ERP

A. Platform

public

2015-08-24 13:16

2015-08-24 13:44

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

3.0PR15Q4

Fixed in Version

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0030647: Prevent NPE in log when shutting down

Description

When shutting down the application the following NPE's can be seen in the log:

680677 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
640352 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
980678 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
940352 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
1280678 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
1240386 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
1580709 [Import Entry Manager Main] ERROR org.openbravo.service.importprocess.ImportEntryManager -
java.lang.NullPointerException
at org.openbravo.service.importprocess.ImportEntryManager$ImportEntryManagerThread.run(ImportEntryManager.java:488)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
1477317 [http-bio-8080-exec-28] INFO org.openbravo.mobile.core.MobileStaticResourceComponent - A new javascript file have been created: 7976e358c9acd6d5c8b3907a7175d4fc_WebPOS

Steps To Reproduce

Run retail and enter some tickets, then shut down tomcat. Sometimes the above errors will show up.

Is caused by the fact that the import thread is still running while the executorService is already set to null.

Proposed Solution

When the executorService is null then leave the running thread.

Additional Information