Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030598Retail ModulesWeb POSpublic2015-08-18 22:522015-09-11 11:35
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030598: Stabilization: 'receipt.clearWith' is used when 'OB.UTIL.clone' should
Descriptionreceipt.clearWith should never be used or, at most, only be used with the UI receipt
OB.UTIL.clone should be used

The problem is that the clearWith method triggers events that a clone other that then UI clone should not made use of

Use OB.UTIL.clone instead
Steps To ReproduceActivate in Development mode
Apply the part of the patch that verifies that the clearWith is only used with the UI receipt
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on design defect 0030479RR15Q4 closed Orekaria Stabilization: Creating a clone of an object should not fire any event 
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-18 22:52OrekariaNew Issue
2015-08-18 22:52OrekariaAssigned To => Orekaria
2015-08-18 22:52OrekariaTriggers an Emergency Pack => No
2015-08-18 22:55OrekariaSummaryreceipt.clearWith should only be used with the UI receipt => receipt.clearWith is used when OB.UTIL.clone should be used
2015-08-18 22:55OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9230#r9230
2015-08-18 22:59hgbotCheckin
2015-08-18 22:59hgbotNote Added: 0079414
2015-08-18 23:12OrekariaRelationship addeddepends on 0030479
2015-08-18 23:15hgbotCheckin
2015-08-18 23:15hgbotNote Added: 0079415
2015-08-19 12:34OrekariaRelationship addedblocks 0030603
2015-08-19 18:33OrekariaTarget Version => RR15Q4
2015-08-19 18:33OrekariaSummaryreceipt.clearWith is used when OB.UTIL.clone should be used => Stabilization: receipt.clearWith is used when OB.UTIL.clone should be used
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079606
2015-08-22 20:35hgbotStatusnew => resolved
2015-08-22 20:35hgbotResolutionopen => fixed
2015-08-22 20:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1b62dd31b2e99d74d152a3a9fe10a1061e019e09 [^]
2015-08-22 20:49OrekariaSummaryStabilization: receipt.clearWith is used when OB.UTIL.clone should be used => Stabilization: 'receipt.clearWith' is used when 'OB.UTIL.clone' should
2015-08-22 20:50OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9248#r9248
2015-09-11 11:35marvintmReview Assigned To => marvintm
2015-09-11 11:35marvintmStatusresolved => closed
2015-09-11 11:35marvintmFixed in Version => RR15Q4

Notes
(0079414)
hgbot   
2015-08-18 22:59   
Repository: erp/pmods/org.openbravo.retail.printlast
Changeset: 38c065cd2dbb7e87e45da14f045fc1fde6ca17eb
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 18 22:57:58 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/38c065cd2dbb7e87e45da14f045fc1fde6ca17eb [^]

Related to issue 30598: OB.UTIL.clone is used to clone the receipt

- jsLint

---
M web/org.openbravo.retail.printlast/js/printLastButton.js
---
(0079415)
hgbot   
2015-08-18 23:15   
Repository: erp/pmods/org.openbravo.retail.printlast
Changeset: b6188e290fbd850f2305f7dee17ea188593e64d3
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 18 23:15:21 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/b6188e290fbd850f2305f7dee17ea188593e64d3 [^]

Related to issue 30598: OB.UTIL.clone is used to clone the receipt (II)

---
M web/org.openbravo.retail.printlast/js/printLastButton.js
---
(0079606)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1b62dd31b2e99d74d152a3a9fe10a1061e019e09
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1b62dd31b2e99d74d152a3a9fe10a1061e019e09 [^]

Fixes issue 30598: ClearWith is not used to clone the UI receipt

- its only use is to update and fire events of the UI receipt

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
---