Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030590Retail ModulesWeb POSpublic2015-08-17 15:282015-09-30 16:56
ReporterOrekaria 
Assigned ToOrekaria 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030590: In the WebPOS document sequence table, It is possible to create more than 1 record for a terminal
DescriptionIn the WebPOS document sequence table, It is possible to create more than 1 record for a terminal
Steps To ReproduceClear the cache
Login in the WebPOS
Verify that, in the WebSQL database, c_document_sequence table, 2 records have been created for the same terminal search key (INCORRECT)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030591RR15Q3.1 closed Orekaria In the WebPOS document sequence table, It is possible to create more than 1 record for a terminal 
depends on backport 0030592RR15Q2.4 closed Orekaria In the WebPOS document sequence table, It is possible to create more than 1 record for a terminal 
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
causes defect 0032410 closed jorge-garcia Document sequence is reset when login offline is done 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-17 15:28OrekariaNew Issue
2015-08-17 15:28OrekariaAssigned To => Orekaria
2015-08-17 15:28OrekariaOBNetwork customer => No
2015-08-17 15:28OrekariaTriggers an Emergency Pack => No
2015-08-17 15:28OrekariaRegression level => Automated tests
2015-08-17 15:28OrekariaStatusnew => scheduled
2015-08-17 18:20hgbotCheckin
2015-08-17 18:20hgbotNote Added: 0079394
2015-08-17 18:20hgbotCheckin
2015-08-17 18:20hgbotNote Added: 0079395
2015-08-17 18:20hgbotStatusscheduled => resolved
2015-08-17 18:20hgbotResolutionopen => fixed
2015-08-17 18:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b5ae341b18a353581745f3026d9eca40fa61e37e [^]
2015-08-17 19:52hgbotCheckin
2015-08-17 19:52hgbotNote Added: 0079398
2015-08-20 21:08OrekariaRelationship addedblocks 0030603
2015-08-20 21:08OrekariaNote Added: 0079445
2015-08-20 21:08OrekariaStatusresolved => new
2015-08-20 21:08OrekariaResolutionfixed => open
2015-08-20 21:09OrekariaNote Edited: 0079445bug_revision_view_page.php?bugnote_id=0079445#r9239
2015-08-22 10:12OrekariaTarget Version => RR15Q4
2015-08-22 20:36hgbotCheckin
2015-08-22 20:36hgbotNote Added: 0079620
2015-08-22 20:36hgbotStatusnew => resolved
2015-08-22 20:36hgbotResolutionopen => fixed
2015-08-22 20:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b5ae341b18a353581745f3026d9eca40fa61e37e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96147e032ed3d1efe95842f18f2cce2f0a0d3d3a [^]
2015-08-25 08:41hgbotCheckin
2015-08-25 08:41hgbotNote Added: 0079649
2015-08-25 08:42hgbotCheckin
2015-08-25 08:42hgbotNote Added: 0079651
2015-08-25 08:42hgbotCheckin
2015-08-25 08:42hgbotNote Added: 0079653
2015-08-25 11:22hgbotCheckin
2015-08-25 11:22hgbotNote Added: 0079685
2015-09-01 10:40mtaalNote Added: 0079987
2015-09-01 10:40mtaalStatusresolved => new
2015-09-01 10:40mtaalResolutionfixed => open
2015-09-29 15:20OrekariaStatusnew => scheduled
2015-09-30 10:02hgbotCheckin
2015-09-30 10:02hgbotNote Added: 0080733
2015-09-30 10:02hgbotStatusscheduled => resolved
2015-09-30 10:02hgbotResolutionopen => fixed
2015-09-30 10:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96147e032ed3d1efe95842f18f2cce2f0a0d3d3a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5c4178fdfaba74c358e3ae7162806b8187f56cb8 [^]
2015-09-30 10:21OrekariaReview Assigned To => mtaal
2015-09-30 10:29OrekariaReview Assigned Tomtaal => marvintm
2015-09-30 16:56marvintmStatusresolved => closed
2015-09-30 16:56marvintmFixed in Version => RR15Q4
2016-04-10 17:29dmitry_mezentsevRelationship addedcauses 0032410

Notes
(0079394)
hgbot   
2015-08-17 18:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a325f1e90bdf083db93333efea5c014d24b104c0
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 16:17:57 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a325f1e90bdf083db93333efea5c014d24b104c0 [^]

Related to issue 30590: The pos_search_key is set to be unique

The problem was that some changes in the code were creating more than 1 record, but no error was raised

---
M web/org.openbravo.retail.posterminal/js/model/document-sequence.js
---
(0079395)
hgbot   
2015-08-17 18:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b5ae341b18a353581745f3026d9eca40fa61e37e
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 16:06:02 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b5ae341b18a353581745f3026d9eca40fa61e37e [^]

Fixes issue 30590: Force the saveDocumentSequence when the terminal info fails to be loaded

The problem was that forcing it in the render method, provoked a race condition between that call and the call when the response of the terminal reached the client, creating 2 records

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0079398)
hgbot   
2015-08-17 19:52   
Repository: tools/automation/pi-mobile
Changeset: 5c2355686aebc8bb7e6d28b92f6a12dec6a4b2fa
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 17:18:20 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5c2355686aebc8bb7e6d28b92f6a12dec6a4b2fa [^]

Verifies issue 30590: Added the 'I30590_1DocnoSequenceRecordPerTerminal' test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I30590_1DocnoSequenceRecordPerTerminal.java
---
(0079445)
Orekaria   
2015-08-20 21:08   
(edited on: 2015-08-20 21:09)
A receipt with docno 000000 can be created due to the new lag introduced by the call to the server

To reproduce this:
- refresh with F5
- verify that the docno is 0000000 before being updated
(0079620)
hgbot   
2015-08-22 20:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 96147e032ed3d1efe95842f18f2cce2f0a0d3d3a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96147e032ed3d1efe95842f18f2cce2f0a0d3d3a [^]

Fixes issue 30590: Initialize the document sequence

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0079649)
hgbot   
2015-08-25 08:41   
Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: 7563de118742ec85684ba3749ee540fe058bce41
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 16:17:57 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/7563de118742ec85684ba3749ee540fe058bce41 [^]

Fixes issue 30592, backport of issue 30590: The pos_search_key is set to be unique

The problem was that some changes in the code were creating more than 1 record, but no error was raised

---
M web/org.openbravo.retail.posterminal/js/model/document-sequence.js
---
(0079651)
hgbot   
2015-08-25 08:42   
Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: ad772605a7d4e68f3f3d82d61ee1deac8f6ff82d
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Aug 17 16:06:02 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/ad772605a7d4e68f3f3d82d61ee1deac8f6ff82d [^]

Fixes issue 30592, backport of issue 30590: Force the saveDocumentSequence when the terminal info fails to be loaded

The problem was that forcing it in the render method, provoked a race condition between that call and the call when the response of the terminal reached the client, creating 2 records

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0079653)
hgbot   
2015-08-25 08:42   
Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: 54a8e71c3f32e228321f3e001324a1c646e3686e
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/54a8e71c3f32e228321f3e001324a1c646e3686e [^]

Fixes issue 30592, backport of issue 30590: Initialize the document sequence

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0079685)
hgbot   
2015-08-25 11:22   
Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: 98d68b4fdb887fb9fd053ff2b1083ab1b2c53874
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 25 11:20:53 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/98d68b4fdb887fb9fd053ff2b1083ab1b2c53874 [^]

Fixes issue 30592, backport of issue 30590: Fixed transplant

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0079987)
mtaal   
2015-09-01 10:40   
As discussed, it can be more clear to move this code:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96147e032ed3d1efe95842f18f2cce2f0a0d3d3a#l2.12 [^]

to near where the call is done to the server to obtain the document seq numbers from the server and somehow synchronize the calls (always do the initialization first).

gr. Martin
(0080733)
hgbot   
2015-09-30 10:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5c4178fdfaba74c358e3ae7162806b8187f56cb8
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Sep 29 19:40:51 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5c4178fdfaba74c358e3ae7162806b8187f56cb8 [^]

Fixes issue 30590: There is no longer the necessity to force the creation of the documentSequence table

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---