0030586: Performance issues in IDL for Variants - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030586

Modules

Initial data load

public

2015-08-14 14:04

2015-09-11 06:33

Reporter

gorkaion

Assigned To

aferraz

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

dmiguelez

Support ticket

37273

OBNetwork customer

OBPS

Regression introduced in release

Summary

0030586: Performance issues in IDL for Variants

Description

There are performance issues in the IDL for Variants module when having variant characteristics with a high number of available values.

Having a Color characteristic with ~ 1500 values and a Size characteristic with ~ 20 values.

The import of generic products adding those characteristics as variants takes ~ 15 seconds for each product.
The import of variants for those products also takes several seconds when they shouldn't.

Steps To Reproduce

Create a characteristic color with 1500 values.
Create a characteristic size with 20 values.
Create a csv file with 10 products using those characteristics as variants.
Import the file and check the times.

It might be necessary to add some log information to the ImportProduct class.

Proposed Solution

After a simple research the following issues have been detected:
- For each generic all the available values of the characteristics are loaded in the Characteristic Conf tab. This is managed by the ProductCharacteristicEventHandler event handler. The generation of those records is expected but the flush after this event handler is very slow as all the conf records (~ 1500) are loaded in the session.
- When the variants are created a copy of the generic product is done copying all the children entities. This also copies the Conf values of the generic product. These values should be deleted and removed from the session.

Additional Information