Openbravo Issue Tracking System - Retail Modules
View Issue Details
0030535Retail ModulesQuotationspublic2015-07-23 12:592015-08-12 15:31
lorenzofidalgo 
jorge-garcia 
immediatemajoralways
closedfixed 
5
main 
RR15Q3RR15Q3 
marvintm
Packaging and release
main
No
0030535: [RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed
To create a Sales Order from quotation if "Firm quotation" is unchecked and some prices has been changed induces errors in the final total amount. This error also reaches POS backend data.
This situation is generated if the product selected in the quotation appears in some discount record. It is not necessary that the discount is being applied in this certain receipt.
0-Login POS backend and go to "Discounts and promotions" window. Create a new record in that window with the following data:
--
Organization: The White Valley Group
Discount/Promotion Type: Buy X pay Y of same product
Name: Quotation+Discounts error
Printed Name: Quotation+Discounts error
Active: Checked
Starting date: 01-01-2012
Included Products: Only those defined
Included Organizations: Only those defined
X Units: 3
Y Units: 2

In Products tab, add the following record: Camera bag
In Organization tab, add the following record: Vall Blanca Store
--
Save the record.
1- Login POS in VBS terminal and login with vallblanca//openbravo.
2- In dropdown menu, click Create Quotation option.
3- Then click SEARCH option, search camera bag and add 2x "Camera bag".
4- Click the product line and change its price to 1€ each product.
5- Then tap "total amount" button to get that quotation to be under evaluation.
6- In dropdown menu click "Create Sales Order", "Firm quotation" must be UNCHECKED. Then click "Create Sales Order" button in the popup.
7- Defect: Realize Total Amount is wrong.
No tags attached.
depends on defect 0030564 closed jorge-garcia [RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed 
blocks defect 0030412 closed marvintm [RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed 
diff 30535.diff (643) 2015-08-10 14:42
https://issues.openbravo.com/file_download.php?file_id=8352&type=bug
Issue History
2015-08-10 13:44jorge-garciaTypedefect => backport
2015-08-10 13:44jorge-garciaTarget Version => RR15Q3
2015-08-10 14:42jorge-garciaFile Added: 30535.diff
2015-08-11 08:45hgbotCheckin
2015-08-11 08:45hgbotNote Added: 0079296
2015-08-11 08:45hgbotStatusscheduled => resolved
2015-08-11 08:45hgbotResolutionopen => fixed
2015-08-11 08:45hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/c4fd068a6e7779d494d794388cc4f7d7b34b25a3 [^]
2015-08-12 14:57marvintmNote Added: 0079323
2015-08-12 14:57marvintmStatusresolved => new
2015-08-12 14:57marvintmResolutionfixed => open
2015-08-12 15:30marvintmNote Added: 0079326
2015-08-12 15:30marvintmStatusnew => scheduled
2015-08-12 15:30marvintmStatusscheduled => resolved
2015-08-12 15:30marvintmResolutionopen => fixed
2015-08-12 15:31marvintmReview Assigned To => marvintm
2015-08-12 15:31marvintmStatusresolved => closed
2015-08-12 15:31marvintmFixed in Version => RR15Q3
2015-09-24 10:21OrekariaRelationship addedcauses 0030909
2015-09-24 10:22OrekariaRelationship deletedcauses 0030909

Notes
(0079296)
hgbot   
2015-08-11 08:45   
Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal
Changeset: c4fd068a6e7779d494d794388cc4f7d7b34b25a3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 11 08:43:28 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/c4fd068a6e7779d494d794388cc4f7d7b34b25a3 [^]

Fixed issue 30535: Creating a sales order from quotation with "Firm quotation"

Backport for the issue 30412

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079323)
marvintm   
2015-08-12 14:57   
The fix is not correct. It needs to be reviewed, and repaired.
(0079326)
marvintm   
2015-08-12 15:30   
Finally the fix is correct, so it can be closed. No further change is needed.