|
Notes |
|
|
(0079225)
|
|
alostale
|
2015-08-06 16:26
(edited on: 2015-08-06 16:27) |
|
There are two different issues affecting this tab:
1. When the record identifier of the parent tab is compound by more than one field, being one of them a TableDir and the other translatable, the generated query is fails to execute.
In fact TableDir fields participating in identifiers are always incorrectly generated because they are joining ID with ad_ref_list_value which is incorrect, when compiling a clean Openbravo 3 without forcing 2.50 generation the only affected file is org/openbravo/erpWindows/ProcessPlan/IOProducts_data.xsql with a query:
select ...
(CASE WHEN MA_SequenceProduct.M_Product_Uom_Id IS NULL THEN '' ELSE ( COALESCE(TO_CHAR(list2.name),'') ) END) AS M_Product_Uom_IdR,
...
from SequenceProduct
left join (select M_Product_Uom_Id, C_UOM_ID from M_Product_UOM) table5
on (MA_SequenceProduct.M_Product_Uom_Id = table5.M_Product_Uom_Id)
left join ad_ref_list_v list2
on (table5.C_UOM_ID = list2.value
and list2.ad_reference_id = ''
and list2.ad_language = ?)
...
which is incorrect.
2. When there is in a parent tab an auxiliary input with a parameter based in a field stored in session, the java generated is incorrect. The only occurrence of this case is the new Navigation Rules tab.
Correct implementation is not going to be done for none of these 2 cases because this code is planned to be retired soon, meanwhile a workaround to make it compile will be implemented.
|
|
|
|
(0079226)
|
|
hgbot
|
|
2015-08-06 16:41
|
|
Repository: erp/devel/pi
Changeset: 9d134526fceeb95e137a2863e59bce834ba20736
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Aug 06 16:38:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9d134526fceeb95e137a2863e59bce834ba20736 [^]
related to issue 30505: 2.50 compilation mode fails
TableDir fields participating in identifiers are incorrectly generated because
they are joined by ID with ad_ref_list_value which is incorrect.
This is not a fix but just a workarround to make the code to compile.
---
M src-wad/src/org/openbravo/wad/controls/WADTableDir.java
---
|
|
|
|
(0079227)
|
|
hgbot
|
|
2015-08-06 16:41
|
|
Repository: erp/devel/pi
Changeset: f5cac263bc766a60806d547e06317e1a54adcfa7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Aug 06 16:40:39 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f5cac263bc766a60806d547e06317e1a54adcfa7 [^]
fixed issue 30505: 2.50 compilation mode fails
When there is in a parent tab an auxiliary input with a parameter based in a
field stored in session, the java generated is incorrect.
This is not a fix but a workarround: values are not retrieved by using the java
field but using the FieldProvider.getField method instead.
---
M src-wad/src/org/openbravo/wad/WadUtility.java
---
|
|
|
|
|
Tested:
*changeset 1: http://code.openbravo.com/erp/devel/pi/rev/9d13452 [^]
-Comparing wad generated code after the fix and before the only modified file is ProcessPlan/IOProducts_data.xsql if 2.50 mode is not forced.
-There are few other xsql files modified when forcing 2.50 mode.
-New query does not implement the identifier replacing it with xxx string (note before was not correctly implemented)
*changeset 2: http://code.openbravo.com/erp/devel/pi/rev/f5cac263b [^]
-There are many java files affected in the way auxiliary inputs are retrieved, but the old and new ways are completely interchangeable. |
|
|
|
|
|
checked that window is now properly created and compilation does not fail. |
|
|
|
|
|
|
|
|
|