Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030490Openbravo ERP04. Warehouse managementpublic2015-07-31 12:272015-08-04 12:01
Reporterumartirena 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date2014-06-16
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/05f152469a6a [^]
Triggers an Emergency PackNo
Summary0030490: Return from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned
DescriptionReturn from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned. This happens because the "Returned Quantity other RM" field is showing negative values instead of positive, so this makes the validation on Returned field to perform wrongly.

There is another issue in the pick&edit probably related to the same problem. It shows shipment lines fully returned, when they should not appear.
Steps To ReproduceAs F&B Group Admin:
 * Go to Sales Order window and create a Sales Order with a product with stock for quantity 5.
 * Go to Create Shipments from Orders and create the shipment from the previous Sales Order.
 * Go to Return from Customer Window and create a header for the same Business Partner as previous Order/Shipment.
 * Click on Pick&Edit Lines and select the previous shipment line. Set Returned 3. CLick Done.
 * Book the document.
 * Create a new header of Return from Customer.
 * Click again on Pick&Edit Lines. Realize that the previous shipment line appears with -3 on Returned Quantity other RM field, what is wrong because it should be 3.
 * Check also that it allows to enter a value on Returned field between 0 and 8. when it should be between 0 and 2.
 * At least, if you put a value greater than 3 it will not allow to book the document, it will throw an error.
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0030471 closed AtulOpenbravo Return from Customer Pick&Edit Lines allows to enter more quantity to return than the pending to be returned 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-04 10:25AtulOpenbravoTypedefect => backport
2015-08-04 10:25AtulOpenbravoTarget Version => 3.0PR15Q3
2015-08-04 10:35vmromanosTag Attached: Approved
2015-08-04 11:59hgbotCheckin
2015-08-04 11:59hgbotNote Added: 0079171
2015-08-04 11:59hgbotStatusscheduled => resolved
2015-08-04 11:59hgbotResolutionopen => fixed
2015-08-04 11:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/e9e4169a1f481b21f559c13f4b66de0b32b56b5b [^]
2015-08-04 12:01vmromanosReview Assigned To => vmromanos
2015-08-04 12:01vmromanosNote Added: 0079173
2015-08-04 12:01vmromanosStatusresolved => closed

Notes
(0079171)
hgbot   
2015-08-04 11:59   
Repository: erp/backports/3.0PR15Q3
Changeset: e9e4169a1f481b21f559c13f4b66de0b32b56b5b
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Aug 03 23:08:59 2015 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/e9e4169a1f481b21f559c13f4b66de0b32b56b5b [^]

Fixes Issue 30490: Return from Customer Pick&Edit Lines allows to enter more
quantity to return than the pending to be returned

Return document has negative movementqty so ReturnQtyOtherRM was negative.
It should be postive so unlike ReturnQty it is multiplied with -1 as in prev
Datasource prior to transforming it to HQL PE. Where clause which checks
MovementQty of shipment line with the ReturnQtyOtherRM was missing. Sum of
Shipmentline MovementQty and ReturnQtyOtherRM should not be zero. It is added
to fix the problem.

---
M src-db/database/sourcedata/AD_TABLE.xml
---
(0079173)
vmromanos   
2015-08-04 12:01   
Code review + testing OK

Tested in both Oracle and PostgreSQL