Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030470Openbravo ERP09. Financial managementpublic2015-07-31 10:392015-08-20 23:16
ReporterVictorVillar 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket37623
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030470: Wrong posted status for Bill of Materials Production documents
DescriptionWrong posted status for Bill of Materials Production documents when the cost is not calculated yet and the user is trying to post them
Steps To ReproduceAs group Admin role,
  Go to Process Request window:
     stop the Acct Server process and the Costing background process
 Go to Product window,
   Select Cerveza Ale
   Bill of Materials: Yes
 Go to The BOM tab:
    Add Agua
Click on Verify BOM button

Go to Bill of Materials Production
  select Cerveza Ale
  Add a locator
 Create the Production
Click again, and process the production.

Then Launch the Acct Server. Realisa tha the BOM Production is post: Error but should be Post: Cost Not calculated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-07-31 10:39VictorVillarNew Issue
2015-07-31 10:39VictorVillarAssigned To => Triage Finance
2015-07-31 10:39VictorVillarOBNetwork customer => Yes
2015-07-31 10:39VictorVillarModules => Core
2015-07-31 10:39VictorVillarSupport ticket => 37623
2015-07-31 10:39VictorVillarResolution time => 1441058400
2015-07-31 10:39VictorVillarTriggers an Emergency Pack => No
2015-07-31 10:39VictorVillarIssue Monitored: networkb
2015-08-10 07:03AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-08-10 07:03AtulOpenbravoStatusnew => scheduled
2015-08-10 07:06AtulOpenbravoNote Added: 0079266
2015-08-11 10:01hgbotCheckin
2015-08-11 10:01hgbotNote Added: 0079304
2015-08-11 10:01hgbotStatusscheduled => resolved
2015-08-11 10:01hgbotResolutionopen => fixed
2015-08-11 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ad9fcefd23db7fe5042c4fb3e5d5445594db97f1 [^]
2015-08-11 10:01hgbotCheckin
2015-08-11 10:01hgbotNote Added: 0079305
2015-08-11 10:02vmromanosReview Assigned To => vmromanos
2015-08-11 10:02vmromanosNote Added: 0079306
2015-08-11 10:02vmromanosStatusresolved => closed
2015-08-20 23:16hudsonbotCheckin
2015-08-20 23:16hudsonbotNote Added: 0079540
2015-08-20 23:16hudsonbotCheckin
2015-08-20 23:16hudsonbotNote Added: 0079541

Notes
(0079266)
AtulOpenbravo   
2015-08-10 07:06   
Test Plan
- Login as Group Admin role.
- Go to Process Request window
     Stop the Acct Server process and the Costing background process.
- Go to Product window. Select product Cerveza Ale and set Bill of Materials = Yes.
- Go to The BOM tab. Add product Agua Quantity 1.
- Click on Verify BOM button
- Go to Bill of Materials Production. Select Cerveza Ale, Add a locator.
- Click on Create the Production.
- Click again, for process the production.
- Launch the Acct Server. Check that BOM Production status is Post:Cost Not calculated.
(0079304)
hgbot   
2015-08-11 10:01   
Repository: erp/devel/pi
Changeset: ad9fcefd23db7fe5042c4fb3e5d5445594db97f1
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Sun Aug 09 13:15:35 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ad9fcefd23db7fe5042c4fb3e5d5445594db97f1 [^]

Fixes Issue 30470:Wrong posted status for Bill of Materials Production
documents

Post Error was shown when a non cost calculated production entry
was posted. Now proper status Cost Not Calculated is shown by raising a
OBException and handling properly it properly in AcctServer.

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
M src/org/openbravo/erpCommon/ad_forms/DocProduction.java
---
(0079305)
hgbot   
2015-08-11 10:01   
Repository: erp/devel/pi
Changeset: 3b3aefef0ce70dacd28d0706c3ed295907cfb1d4
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 10 15:03:57 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3b3aefef0ce70dacd28d0706c3ed295907cfb1d4 [^]

Related to issue 30470: code review improvements

The error message when manually posting the record was overwritten by the "@NotCalculatedCost@" string because the catch code always overwrites the message set in the correspondent Doc* class.
This was wrong, as the Doc* class should be in charge of setting the error message.
Now the message is only overwritten if it hasn't previously set by the correspondent Doc* class

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0079306)
vmromanos   
2015-08-11 10:02   
Code review + testing OK
(0079540)
hudsonbot   
2015-08-20 23:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test
(0079541)
hudsonbot   
2015-08-20 23:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test