Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0030337 | Openbravo ERP | A. Platform | public | 2015-07-10 12:14 | 2015-08-20 23:16 |
|
| Reporter | shuehner | |
| Assigned To | alostale | |
| Priority | immediate | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | pi | |
| Merge Request Status | |
| Review Assigned To | shuehner |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | Coding ( Testing ) |
| Regression date | 2015-06-18 |
| Regression introduced in release | pi |
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/0609c9593fc7cd34a25959e41230528685f29578 [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0030337: New pg version check which should only stop old pg versions fails to parse 9.5ahpha1 and also stop using it |
| Description | That new version check if designed to prevent using Q3 and higher with pg versions <9.1
However probably because of some bug it fails also prevent using 9.5alpha1 probably as it is confused with the alhpa1 suffix.
|
| Steps To Reproduce | try install.source on pg9.4alpha1 (note: possible in try)
pg 9.5alpha1 is also already available on the usual apt.postgresql.org repos to easily installable on any debian/ubuntu system |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | feature request | 0030187 | 3.0PR15Q3 | closed | caristu | prevent build in unsupported PG verrsions | | depends on | backport | 0030339 | 3.0PR15Q3 | closed | alostale | New pg version check which should only stop old pg versions fails to parse 9.5ahpha1 and also stop using it |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-07-10 12:14 | shuehner | New Issue | |
| 2015-07-10 12:14 | shuehner | Assigned To | => platform |
| 2015-07-10 12:14 | shuehner | Modules | => Core |
| 2015-07-10 12:14 | shuehner | Regression introduced in release | => pi |
| 2015-07-10 12:14 | shuehner | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/0609c9593fc7cd34a25959e41230528685f29578 [^] |
| 2015-07-10 12:14 | shuehner | Triggers an Emergency Pack | => No |
| 2015-07-10 12:16 | shuehner | Relationship added | related to 0030187 |
| 2015-07-10 13:21 | alostale | Assigned To | platform => alostale |
| 2015-07-10 13:22 | alostale | Regression level | => Coding ( Testing ) |
| 2015-07-10 13:22 | alostale | Regression date | => 2015-06-18 |
| 2015-07-10 13:22 | alostale | Priority | normal => immediate |
| 2015-07-10 13:28 | alostale | Status | new => scheduled |
| 2015-07-10 13:30 | alostale | Review Assigned To | => shuehner |
| 2015-07-13 08:27 | hgbot | Checkin | |
| 2015-07-13 08:27 | hgbot | Note Added: 0078762 | |
| 2015-07-13 08:27 | hgbot | Status | scheduled => resolved |
| 2015-07-13 08:27 | hgbot | Resolution | open => fixed |
| 2015-07-13 08:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/62725e97926dee7ca71a31866ab7bbc0abf9ab36 [^] |
| 2015-07-13 14:47 | shuehner | Note Added: 0078776 | |
| 2015-07-13 14:47 | shuehner | Status | resolved => closed |
| 2015-07-13 14:47 | shuehner | Fixed in Version | => pi |
| 2015-07-16 12:01 | gorka_gil | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/62725e97926dee7ca71a31866ab7bbc0abf9ab36 [^] => http://code.openbravo.com/erp/devel/pi/rev/216cdd3c5a8b [^] |
| 2015-07-16 12:01 | gorka_gil | Note Edited: 0078762 | bug_revision_view_page.php?bugnote_id=0078762#r9044 |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079489 | |
|
Notes |
|
|
(0078762)
|
|
hgbot
|
2015-07-13 08:27
(edited on: 2015-07-16 12:01) |
|
Repository: erp/devel/pi
Changeset: 216cdd3c5a8b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jul 10 13:19:36 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/216cdd3c5a8b [^]
fixed bug 30337: pg version check prevents using 9.5ahpha1
The check compares version with 9.1 but it took 9.5alpha1 as whole version where
alpha1 string part should be removed.
Fixed by removing textual parts of the version (this was already done for Oracle)
---
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DatabaseVersionCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/DatabaseVersionCheck.java
---
|
|
|
|
|
Reviewed & tested.
Tested by running code against manually extract db versions for 8.4.x, 9.1.x, 9.3.x, 9.5alpha1
On top of several more having special non-numeric suffixes found by searching butler-db with:
select distinct db_version from ad_heartbeat where db = 'POSTGRE';
All ok with 1 minor issue:
9.1RC1 formally should not be accepted as some earlier release candidate only.
However people using RC should know better themselves and fine to not cover this corner case in this check. |
|
|
|
|
|