Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030333Openbravo ERP09. Financial managementpublic2015-07-03 14:442015-07-17 15:09
dmiguelez 
dmiguelez 
immediatecriticalalways
closedfixed 
20Community Appliance
 
3.0PR15Q2.3 
Core
Production - Confirmed Stable
2014-10-17
3.0PR15Q1
https://code.openbravo.com/erp/devel/pi/rev/ea8abe653e29 [^]
No
0030333: Costing Process does not process more than 1000 Transactions even if it says so
Costing Process does not process more than 1000 Transactions even if it says so.
It loops through the first 1000 Transactions all the time.
Having an environment with more than 1000 Transactions without a calculated Cost.
Launch Costing Background Process.
Enable the log through the Session Preferences Window, using the Enable Logs button and setting the class CostingBackground.java in debug mode.
In the log, it is possible to see that the process iterates more than 1000 Transactions, until the end.
If the Process is launched again, it is possible to see that only the first 1000 Transactions have been calculated based on the remaining ones.

For example, if the first time there are 5000 Transactions to calculate and the Process goes through all of them, the remaining amount for the next execution should be 0, instead it will be 4000
Approved
blocks defect 0030315 closed dmiguelez Costing Process does not process more than 1000 Transactions even if it says so 
Issue History
2015-07-08 11:34vmromanosTypedefect => backport
2015-07-08 11:34vmromanosTarget Version => 3.0PR15Q2.3
2015-07-08 11:34vmromanosTag Attached: Approved
2015-07-08 11:35vmromanosAssigned ToTriage Finance => dmiguelez
2015-07-16 11:23hgbotCheckin
2015-07-16 11:23hgbotNote Added: 0078849
2015-07-16 11:23hgbotStatusscheduled => resolved
2015-07-16 11:23hgbotResolutionopen => fixed
2015-07-16 11:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q2.3/rev/d0f23399740516e4a5753e89ac5f958335fac55c [^]
2015-07-16 11:26hgbotCheckin
2015-07-16 11:26hgbotNote Added: 0078850
2015-07-16 13:19dmiguelezNote Added: 0078878
2015-07-16 13:19dmiguelezStatusresolved => closed
2015-07-17 15:09hgbotCheckin
2015-07-17 15:09hgbotNote Added: 0078943

Notes
(0078849)
hgbot   
2015-07-16 11:23   
Repository: erp/backports/3.0PR15Q2.3
Changeset: d0f23399740516e4a5753e89ac5f958335fac55c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 16 11:22:51 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.3/rev/d0f23399740516e4a5753e89ac5f958335fac55c [^]

Fixes issue 30333: BackPort from issue 303015.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078850)
hgbot   
2015-07-16 11:26   
Repository: erp/backports/3.0PR15Q3
Changeset: d486b2997ee53a25c4319560cbe4ebe82dd92444
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 16 11:26:34 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/d486b2997ee53a25c4319560cbe4ebe82dd92444 [^]

Fixes issue 30315: BackPort from issue 30333.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078878)
dmiguelez   
2015-07-16 13:19   
Code Review + Testing Ok
(0078943)
hgbot   
2015-07-17 15:09   
Repository: erp/backports/3.0PR15Q2.3
Changeset: caad93739c8be2612473d5d01b7a139802abd8ba
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 17 15:04:27 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2.3/rev/caad93739c8be2612473d5d01b7a139802abd8ba [^]

Related to Issue 30333: Do not take into account Transactions in Skip Status.
Remove them from the queries.
In Costing Server, set all Transactions as isProcessed=Y when they go through
doProcess() method.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---