Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030332Openbravo ERP09. Financial managementpublic2015-07-03 14:442015-07-17 15:09
dmiguelez 
dmiguelez 
immediatecriticalalways
closedfixed 
20Community Appliance
 
3.0PR15Q3 
dmiguelez
Core
Production - Confirmed Stable
2014-10-17
3.0PR15Q1
https://code.openbravo.com/erp/devel/pi/rev/ea8abe653e29 [^]
No
0030332: Costing Process does not process more than 1000 Transactions even if it says so
Costing Process does not process more than 1000 Transactions even if it says so.
It loops through the first 1000 Transactions all the time.
Having an environment with more than 1000 Transactions without a calculated Cost.
Launch Costing Background Process.
Enable the log through the Session Preferences Window, using the Enable Logs button and setting the class CostingBackground.java in debug mode.
In the log, it is possible to see that the process iterates more than 1000 Transactions, until the end.
If the Process is launched again, it is possible to see that only the first 1000 Transactions have been calculated based on the remaining ones.

For example, if the first time there are 5000 Transactions to calculate and the Process goes through all of them, the remaining amount for the next execution should be 0, instead it will be 4000
Approved
blocks defect 0030315 closed dmiguelez Costing Process does not process more than 1000 Transactions even if it says so 
Issue History
2015-07-08 11:34vmromanosTypedefect => backport
2015-07-08 11:34vmromanosTarget Version => 3.0PR15Q3
2015-07-08 11:34vmromanosTag Attached: Approved
2015-07-08 11:35vmromanosAssigned ToTriage Finance => dmiguelez
2015-07-16 11:29hgbotCheckin
2015-07-16 11:29hgbotNote Added: 0078853
2015-07-16 11:29hgbotStatusscheduled => resolved
2015-07-16 11:29hgbotResolutionopen => fixed
2015-07-16 11:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/fbe4acffc34a908a6d6ca58e0fb6b3241b651887 [^]
2015-07-16 13:18dmiguelezReview Assigned To => dmiguelez
2015-07-16 13:18dmiguelezNote Added: 0078876
2015-07-16 13:18dmiguelezStatusresolved => closed
2015-07-17 15:09hgbotCheckin
2015-07-17 15:09hgbotNote Added: 0078944

Notes
(0078853)
hgbot   
2015-07-16 11:29   
Repository: erp/backports/3.0PR15Q3
Changeset: fbe4acffc34a908a6d6ca58e0fb6b3241b651887
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 16 11:28:43 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/fbe4acffc34a908a6d6ca58e0fb6b3241b651887 [^]

Fixes issue 30332: BackPort from issue 30315.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078876)
dmiguelez   
2015-07-16 13:18   
Code Reviewed by Gorka Ion + Testing Ok
(0078944)
hgbot   
2015-07-17 15:09   
Repository: erp/backports/3.0PR15Q3
Changeset: 06c15f9276a7f82d63af91eaffa6dcffb6105fb2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 17 15:04:27 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/06c15f9276a7f82d63af91eaffa6dcffb6105fb2 [^]

Related to Issue 30332: Do not take into account Transactions in Skip Status.
Remove them from the queries.
In Costing Server, set all Transactions as isProcessed=Y when they go through
doProcess() method.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---