Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030329Retail ModulesWeb POSpublic2015-07-08 09:152015-09-23 11:51
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in releaseRR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/542f6f37e91e4a41a9c8346d15819e299847e463 [^]
Triggers an Emergency PackNo
Summary0030329: Error Importing orders caused by the organization of the userContact of the order
DescriptionSometimes some orders are not processed because the organization of the user which is set in the order as userContact is not in the natural tree.
Steps To ReproduceUsing a BP create a contect (user) in a organization which is not in the natural tree.

Then in web pos, create an order for that bp and process it.
The order will appear in "Errors" window.
Proposed SolutionThis value only should be set if the organization of the user is in the natural tree.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030330RR15Q3 closed guilleaer Error Importing orders caused by the organization of the userContact of the order 
depends on backport 0030331RR15Q2.3 closed guilleaer Error Importing orders caused by the organization of the userContact of the order 
Attached Filesdiff diffIssue30329_15Q22.diff (1,715) 2015-07-08 09:19
https://issues.openbravo.com/file_download.php?file_id=8267&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-07-08 09:15guilleaerNew Issue
2015-07-08 09:15guilleaerAssigned To => guilleaer
2015-07-08 09:15guilleaerRegression introduced in release => RR15Q1
2015-07-08 09:15guilleaerRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/542f6f37e91e4a41a9c8346d15819e299847e463 [^]
2015-07-08 09:15guilleaerTriggers an Emergency Pack => No
2015-07-08 09:19guilleaerFile Added: diffIssue30329_15Q22.diff
2015-07-08 09:49guilleaerStatusnew => scheduled
2015-09-04 13:28hgbotCheckin
2015-09-04 13:28hgbotNote Added: 0080115
2015-09-04 13:28hgbotStatusscheduled => resolved
2015-09-04 13:28hgbotResolutionopen => fixed
2015-09-04 13:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1357a7ba48b9e1621afe3b36ada757c736662c0 [^]
2015-09-04 13:29hgbotCheckin
2015-09-04 13:29hgbotNote Added: 0080119
2015-09-04 13:30hgbotCheckin
2015-09-04 13:30hgbotNote Added: 0080121
2015-09-18 11:52guilleaerNote Added: 0080490
2015-09-23 11:26hgbotCheckin
2015-09-23 11:26hgbotNote Added: 0080571
2015-09-23 11:51guilleaerReview Assigned To => guilleaer
2015-09-23 11:51guilleaerNote Added: 0080572
2015-09-23 11:51guilleaerStatusresolved => closed
2015-09-23 11:51guilleaerFixed in Version => RR15Q4

Notes
(0080115)
hgbot   
2015-09-04 13:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f1357a7ba48b9e1621afe3b36ada757c736662c0
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jul 29 11:18:10 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1357a7ba48b9e1621afe3b36ada757c736662c0 [^]

Fixed issue 30329: Fixed the way the user contact is being found for a given business partner.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0080119)
hgbot   
2015-09-04 13:29   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: f0c743afffae94bafe9227e03a77a0b14d350e47
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 04 13:19:15 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/f0c743afffae94bafe9227e03a77a0b14d350e47 [^]

Related to issue 30329: Changes in sampledata for automated test

Changes made in the sampledata:
* Two new Business Partner (Customers)
* Three new Users
  - VBS Customer 2 and VBS Customer 3-2 for White Valley Franchise organization
  - VBS Customer 3-1 for Vall Blanca Store

---
M referencedata/sampledata/The_White_Valley_Group/AD_USER.xml
M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER.xml
M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER_LOCATION.xml
M referencedata/sampledata/The_White_Valley_Group/C_BP_CUSTOMER_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/C_BP_VENDOR_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/C_LOCATION.xml
---
(0080121)
hgbot   
2015-09-04 13:30   
Repository: tools/automation/pi-mobile
Changeset: fc2b45ab532d5537ac3c57691ea1e45d7ec0ecf6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 04 12:51:05 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fc2b45ab532d5537ac3c57691ea1e45d7ec0ecf6 [^]

Verifies issue 30329: Added the 'I30329_ContactFromOtherOrg' test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30329_ContactFromOtherOrg.java
---
(0080490)
guilleaer   
2015-09-18 11:52   
Not closed because test is not OK.

When the first test case is executed we should (and currently we are) have as a result the order created in the previous step. If this order is not there is because something happened when the receipt was created. (this is what the fix avoid).

The test is not giving an error because the content of "TestId.LABEL_RECEIPTLIST_EMPTY" is "No results" even when we have results in the list.

To fix:

For the first test case, the test should verify that the order has been stored fine in the ERP. Also it should verify that the ad_user_id from the order is empty. This is because we cannot use this user because it remains to an other organization.

For the second test case, apart from the current behavior which is OK, the test should verify that the field "ad_user_id" of the created order is not empty and match with the ad_user_id related to the customer.

Not sure if cashup is needed here.
(0080571)
hgbot   
2015-09-23 11:26   
Repository: tools/automation/pi-mobile
Changeset: 750aebabd16774722617765f869b897fa01f9d21
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 22 16:10:32 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/750aebabd16774722617765f869b897fa01f9d21 [^]

Verifies issue 30329: Required changes in the 'I30329_ContactFromOtherOrg' test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I30329_ContactFromOtherOrg.java
---
(0080572)
guilleaer   
2015-09-23 11:51   
Code reviewed and tested