Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030315Openbravo ERP09. Financial managementpublic2015-07-03 14:442015-08-20 23:16
dmiguelez 
dmiguelez 
immediatecriticalalways
closedfixed 
20Community Appliance
 
 
dmiguelez
Core
Production - Confirmed Stable
2014-09-17
3.0PR14Q4
https://code.openbravo.com/erp/devel/pi/rev/ea8abe653e29 [^]
No
0030315: Costing Process does not process more than 1000 Transactions even if it says so
Costing Process does not process more than 1000 Transactions even if it says so.
It loops through the first 1000 Transactions all the time.
Having an environment with more than 1000 Transactions without a calculated Cost.
Launch Costing Background Process.
Enable the log through the Session Preferences Window, using the Enable Logs button and setting the class CostingBackground.java in debug mode.
In the log, it is possible to see that the process iterates more than 1000 Transactions, until the end.
If the Process is launched again, it is possible to see that only the first 1000 Transactions have been calculated based on the remaining ones.

For example, if the first time there are 5000 Transactions to calculate and the Process goes through all of them, the remaining amount for the next execution should be 0, instead it will be 4000
No tags attached.
depends on backport 00303323.0PR15Q3 closed dmiguelez Costing Process does not process more than 1000 Transactions even if it says so 
depends on backport 00303333.0PR15Q2.3 closed dmiguelez Costing Process does not process more than 1000 Transactions even if it says so 
caused by feature request 0022855 closed dmiguelez It would be fine to have the cost adjustment functionality implemented 
Issue History
2015-07-03 14:44dmiguelezNew Issue
2015-07-03 14:44dmiguelezAssigned To => Triage Finance
2015-07-03 14:44dmiguelezModules => Core
2015-07-03 14:44dmiguelezRegression level => Production - Confirmed Stable
2015-07-03 14:44dmiguelezRegression date => 2014-10-17
2015-07-03 14:44dmiguelezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/ea8abe653e29 [^]
2015-07-03 14:44dmiguelezTriggers an Emergency Pack => No
2015-07-08 11:34vmromanosRegression introduced in release => 3.0PR15Q1
2015-07-08 11:34vmromanosStatusnew => scheduled
2015-07-08 11:34vmromanosAssigned ToTriage Finance => dmiguelez
2015-07-10 10:06dmitry_mezentsevRegression date2014-10-17 => 2014-09-17
2015-07-10 10:06dmitry_mezentsevRegression introduced in release3.0PR15Q1 => 3.0PR14Q4
2015-07-10 10:12dmitry_mezentsevRelationship addedcaused by 0022855
2015-07-16 11:04hgbotCheckin
2015-07-16 11:04hgbotNote Added: 0078846
2015-07-16 11:04hgbotStatusscheduled => resolved
2015-07-16 11:04hgbotResolutionopen => fixed
2015-07-16 11:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aa212bef7b447e887511d92d93eece072ef04258 [^]
2015-07-16 11:26hgbotCheckin
2015-07-16 11:26hgbotNote Added: 0078851
2015-07-16 11:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/aa212bef7b447e887511d92d93eece072ef04258 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/d486b2997ee53a25c4319560cbe4ebe82dd92444 [^]
2015-07-16 11:29hgbotCheckin
2015-07-16 11:29hgbotNote Added: 0078852
2015-07-16 13:18dmiguelezReview Assigned To => dmiguelez
2015-07-16 13:18dmiguelezNote Added: 0078877
2015-07-16 13:18dmiguelezStatusresolved => closed
2015-07-17 15:05hgbotCheckin
2015-07-17 15:05hgbotNote Added: 0078941
2015-08-20 23:16hudsonbotCheckin
2015-08-20 23:16hudsonbotNote Added: 0079495
2015-08-20 23:16hudsonbotCheckin
2015-08-20 23:16hudsonbotNote Added: 0079500

Notes
(0078846)
hgbot   
2015-07-16 11:04   
Repository: erp/devel/pi
Changeset: aa212bef7b447e887511d92d93eece072ef04258
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jul 14 17:13:47 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aa212bef7b447e887511d92d93eece072ef04258 [^]

Fixes issue 30315: Sets each Transaction as isProcessed=Y after been processed.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078851)
hgbot   
2015-07-16 11:26   
Repository: erp/backports/3.0PR15Q3
Changeset: d486b2997ee53a25c4319560cbe4ebe82dd92444
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 16 11:26:34 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/d486b2997ee53a25c4319560cbe4ebe82dd92444 [^]

Fixes issue 30315: BackPort from issue 30333.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078852)
hgbot   
2015-07-16 11:29   
Repository: erp/backports/3.0PR15Q3
Changeset: fbe4acffc34a908a6d6ca58e0fb6b3241b651887
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 16 11:28:43 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q3/rev/fbe4acffc34a908a6d6ca58e0fb6b3241b651887 [^]

Fixes issue 30332: BackPort from issue 30315.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0078877)
dmiguelez   
2015-07-16 13:18   
Code Reviewed by Gorka Ion + Testing Ok
(0078941)
hgbot   
2015-07-17 15:05   
Repository: erp/devel/pi
Changeset: f6885205cc8d6234937fea675a1fed1d383f78f5
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 17 15:04:27 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f6885205cc8d6234937fea675a1fed1d383f78f5 [^]

Related to Issue 30315: Do not take into account Transactions in Skip Status.
Remove them from the queries.
In Costing Server, set all Transactions as isProcessed=Y when they go through
doProcess() method.

---
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
---
(0079495)
hudsonbot   
2015-08-20 23:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test
(0079500)
hudsonbot   
2015-08-20 23:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test