Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030274Openbravo ERPA. Platformpublic2015-06-29 13:082015-08-20 23:15
Reporteregoitz 
Assigned Tocaristu 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4Fixed in Version3.0PR15Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36513
Regression levelProduction - Confirmed Stable
Regression date2014-07-04
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/ef7047ab914c [^]
Triggers an Emergency PackNo
Summary0030274: In saved views with multiple criteria in one field, the uuid value is shown in the column header when filtering sometimes
DescriptionIn saved views, when filtering on a FK column with two values, and then on a next column filtering a different FK for a unique value, the value shown on the last column is the uuid
Steps To ReproduceSteps to reproduce:
1. Go to Sales Order window
2. In grid view, filter business partner form the drop-down by "==Hoteles Buenas Noches, S.A. or
==Restaurantes Luna Llena, S.A." and Payment method "==Transferencia"
3. Save view as "test"
4. Reopen sales order window and apply the saved view "test" -> payment method filter shows its
identifier ==A97CFD2AFC234B59BB0A72189BD8FC2A instead of ==Transferencia, making subsequent
filtering actions fail.


Notes:
- If you filter business partner by just one value, behavior is always ok
- If you move the column business partner after the column with a single filter, behavior seems to be OK
too, however if business partner (or the column with several values selected from the drop down) is
before payment method, behavior is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027769 closed AugustoMauch Record id shown in grid filtering, when adding a new column to the grid 
depends on backport 00302953.0PR15Q3 closed caristu  In saved views with multiple criteria in one field, the uuid value is shown in the column header when filtering sometimes 
depends on backport 00302963.0PR15Q2.3 closed caristu In saved views with multiple criteria in one field, the uuid value is shown in the column header when filtering sometimes 
caused by design defect 0025211 closed AugustoMauch Filter by selected value in FK uses identifier instead of ID 
Attached Filesdiff issue30274.diff (1,662) 2015-06-30 17:42
https://issues.openbravo.com/file_download.php?file_id=8253&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-29 13:08egoitzNew Issue
2015-06-29 13:08egoitzAssigned To => platform
2015-06-29 13:08egoitzOBNetwork customer => Yes
2015-06-29 13:08egoitzModules => Core
2015-06-29 13:08egoitzResolution time => 1437343200
2015-06-29 13:08egoitzTriggers an Emergency Pack => No
2015-06-29 13:08egoitzRelationship addedrelated to 0027769
2015-06-29 13:08egoitzSupport ticket => 36513
2015-06-29 13:24eugeniIssue Monitored: eugeni
2015-06-29 15:15alostaleStatusnew => scheduled
2015-06-29 15:15alostaleAssigned Toplatform => caristu
2015-06-30 17:42caristuFile Added: issue30274.diff
2015-06-30 17:42caristuNote Added: 0078597
2015-07-01 12:27caristuStatusscheduled => acknowledged
2015-07-01 12:27caristuStatusacknowledged => scheduled
2015-07-01 12:29alostaleRelationship addedcaused by 0025211
2015-07-01 12:30caristuSummaryThe uuid value is shown in the column header when filtering. => In saved views with multiple criteria in one field, the uuid value is shown in the column header when filtering sometimes
2015-07-01 12:31caristuDescription Updatedbug_revision_view_page.php?rev_id=8959#r8959
2015-07-01 12:32caristuRegression level => Production - Confirmed Stable
2015-07-01 12:32caristuRegression date => 2014-07-04
2015-07-01 12:32caristuRegression introduced in release => 3.0PR14Q4
2015-07-01 12:32caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/ef7047ab914c [^]
2015-07-01 12:32caristuSeveritymajor => minor
2015-07-02 09:36caristuIssue Monitored: alostale
2015-07-02 09:37caristuReview Assigned To => alostale
2015-07-02 09:37caristuTarget Version => 3.0PR15Q4
2015-07-02 09:41hgbotCheckin
2015-07-02 09:41hgbotNote Added: 0078610
2015-07-02 09:41hgbotStatusscheduled => resolved
2015-07-02 09:41hgbotResolutionopen => fixed
2015-07-02 09:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b685cad82eef0fe99f6c75a0e9a60854b75b20ab [^]
2015-07-07 09:44alostaleNote Added: 0078694
2015-07-07 09:44alostaleStatusresolved => closed
2015-07-07 09:44alostaleFixed in Version => 3.0PR15Q4
2015-08-20 23:15hudsonbotCheckin
2015-08-20 23:15hudsonbotNote Added: 0079446

Notes
(0078597)
caristu   
2015-06-30 17:42   
Attached proposed solution
(0078610)
hgbot   
2015-07-02 09:41   
Repository: erp/devel/pi
Changeset: b685cad82eef0fe99f6c75a0e9a60854b75b20ab
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jul 02 09:40:16 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b685cad82eef0fe99f6c75a0e9a60854b75b20ab [^]

Fixes issue 30274: uuid appear in saved views with multiple criteria on a field

When a view is saved while any of its filters are currently using the 'id' filter type, the id and identifier of the selected options are stored in a cache. If we have multiple criteria on one field, an internal loop is executed to retrieve all the criterias in the getFKFilterAuxiliaryCache function.

The problem was that this internal loop was using the same variable as the external one to insert those criterias into the cache. This caused that the subsequent filters for next fields were not being handled properly as the condition of the external loop was not being fulfilled anymore due to the increment done in the internal loop.

This has been solved just using a new variable 'j' in the internal loop.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
---
(0078694)
alostale   
2015-07-07 09:44   
code reviewed

tested:
* Saved view
* Default saved view
* Direct link
(0079446)
hudsonbot   
2015-08-20 23:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^]
Maturity status: Test