Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030266Retail ModulesWeb POSpublic2015-06-29 11:062015-07-27 14:09
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q2.3Fixed in VersionRR15Q2.3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2015-01-29
Regression introduced in releaseRR15Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/93c44f0f6ec9 [^]
Triggers an Emergency PackNo
Summary0030266: Due to a race condition, it could happen that a cash up is processed more than once
DescriptionDue to a problem in the code which manages the locks in the cash up process, it could happen that if the same cash up is sent more than once, it will be processed more than once also, which leads to:
- Duplicated invoices
- Duplicated reconciliations and transactions which move cash from the POS account to the bank account.
Steps To ReproduceSo far we don't have a reliable way to reproduce this problem. It happened several times in a customer, and the problem in the code is clear, but there is no way to reproduce this problem reliably using the functionality.
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0030265RR15Q3 closed marvintm Due to a race condition, it could happen that a cash up is processed more than once 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-29 11:07marvintmTypedefect => backport
2015-06-29 11:07marvintmTarget VersionRR15Q3 => RR15Q2.3
2015-06-29 13:56dmitry_mezentsevTag Attached: Approved
2015-07-15 16:08hgbotCheckin
2015-07-15 16:08hgbotNote Added: 0078815
2015-07-15 16:08hgbotStatusscheduled => resolved
2015-07-15 16:08hgbotResolutionopen => fixed
2015-07-15 16:08hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q2.3/org.openbravo.retail.posterminal/rev/c87925fade935416cb301a91048394247f09aa27 [^]
2015-07-27 14:09OrekariaReview Assigned To => Orekaria
2015-07-27 14:09OrekariaStatusresolved => closed
2015-07-27 14:09OrekariaFixed in Version => RR15Q2.3

Notes
(0078815)
hgbot   
2015-07-15 16:08   
Repository: retail/backports/3.0RR15Q2.3/org.openbravo.retail.posterminal
Changeset: c87925fade935416cb301a91048394247f09aa27
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 15 16:07:26 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.3/org.openbravo.retail.posterminal/rev/c87925fade935416cb301a91048394247f09aa27 [^]

Fixed issue 30266. The commit is not needed, and it unlocks the lock which is needed to ensure the cash up is only processed once in the event of more than one duplicated requests from the client side.

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---