Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030265Retail ModulesWeb POSpublic2015-06-29 11:062015-06-29 13:55
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q3Fixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-01-29
Regression introduced in releaseRR15Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/93c44f0f6ec9 [^]
Triggers an Emergency PackNo
Summary0030265: Due to a race condition, it could happen that a cash up is processed more than once
DescriptionDue to a problem in the code which manages the locks in the cash up process, it could happen that if the same cash up is sent more than once, it will be processed more than once also, which leads to:
- Duplicated invoices
- Duplicated reconciliations and transactions which move cash from the POS account to the bank account.
Steps To ReproduceSo far we don't have a reliable way to reproduce this problem. It happened several times in a customer, and the problem in the code is clear, but there is no way to reproduce this problem reliably using the functionality.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030266RR15Q2.3 closed marvintm Due to a race condition, it could happen that a cash up is processed more than once 
caused by defect 0028804RR15Q1 closed marvintm cashups in "while importing data" window are not working fine 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-29 11:06marvintmNew Issue
2015-06-29 11:06marvintmAssigned To => marvintm
2015-06-29 11:06marvintmRegression level => Production - QA Approved
2015-06-29 11:06marvintmRegression date => 2015-01-29
2015-06-29 11:06marvintmRegression introduced in release => RR15Q2
2015-06-29 11:06marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/93c44f0f6ec9 [^]
2015-06-29 11:06marvintmTriggers an Emergency Pack => No
2015-06-29 11:07marvintmStatusnew => scheduled
2015-06-29 11:09hgbotCheckin
2015-06-29 11:09hgbotNote Added: 0078552
2015-06-29 11:09hgbotStatusscheduled => resolved
2015-06-29 11:09hgbotResolutionopen => fixed
2015-06-29 11:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e75c338cf7dc7660232a90fd1db5db13e1515762 [^]
2015-06-29 13:20migueldejuanaReview Assigned To => migueldejuana
2015-06-29 13:20migueldejuanaNote Added: 0078555
2015-06-29 13:20migueldejuanaStatusresolved => closed
2015-06-29 13:20migueldejuanaFixed in Version => RR15Q3
2015-06-29 13:55dmitry_mezentsevRelationship addedcaused by 0028804

Notes
(0078552)
hgbot   
2015-06-29 11:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e75c338cf7dc7660232a90fd1db5db13e1515762
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jun 29 11:09:11 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e75c338cf7dc7660232a90fd1db5db13e1515762 [^]

Fixed issue 30265. The commit is not needed, and it unlocks the lock which is needed to ensure the cash up is only processed once in the event of more than one duplicated requests from the client side.

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---
(0078555)
migueldejuana   
2015-06-29 13:20   
Tested and reviewed in e75c338cf7dc