Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030231Openbravo ERP09. Financial managementpublic2015-06-18 17:262015-07-08 11:26
ReporterVictorVillar 
Assigned Toaferraz 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q1.6Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-04-07
Regression introduced in release3.0PR15Q1.3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/58b1503188be73811b4885798fae1d31bd337076 [^]
Triggers an Emergency PackYes
Summary0030231: Wrong payment status under some circumstancies
DescriptionWrong payment status under some circumstancies.

If you are using Automatic Deposit: Yes - Execution Type: Automatic and Execution Process: Simple Execution Process in your payment method and you complete a Payment In (the same in Payment Out) the status is Payment Received and it is wrong, it should be Deposited not cleared
Steps To ReproduceConfigure the Payment method: Wire Transfer (see the screenshot attached):
Automatic Deposit: Yes - Execution Type: Automatic and Execution Process: Simple Execution Process

Go to Payment In window:
 Organization: US
 create a new one for Healthy Food Supermarkets
 Amount: 20
Click on Add details button.
   Add a GL Item and received amount: 20
Click on Done

Realise that the payment status is Payment Received and it is wrong, it should be Deposited not cleared.

The same is happening with Payments Outs.


Note: It is working fine with the following configuration:
 * Automatic deposit: Yes - Execution Type: Manual
 * Automatic deposit: Yes - Execution Type: Automatic - Execution process: Simple execution process - Deferred: yes


Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 00302063.0PR15Q3 closed aferraz Wrong payment status under some circumstancies 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-23 12:57aferrazTypedefect => backport
2015-06-23 12:57aferrazTarget Version3.0PR15Q3 => 3.0PR15Q1.6
2015-06-23 15:49dmitry_mezentsevTag Attached: Approved
2015-06-24 10:12hgbotCheckin
2015-06-24 10:12hgbotNote Added: 0078469
2015-06-24 10:12hgbotStatusscheduled => resolved
2015-06-24 10:12hgbotResolutionopen => fixed
2015-06-24 10:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.6/rev/2a87bf3caf4c877d899bf3994d4f99f7be33ab5b [^]
2015-06-24 10:15vmromanosReview Assigned To => vmromanos
2015-06-24 10:15vmromanosNote Added: 0078472
2015-06-24 10:15vmromanosStatusresolved => closed
2015-07-08 11:26vmromanosRegression introduced in releasemain => 3.0PR15Q1.3

Notes
(0078469)
hgbot   
2015-06-24 10:12   
Repository: erp/backports/3.0PR15Q1.6
Changeset: 2a87bf3caf4c877d899bf3994d4f99f7be33ab5b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Jun 23 12:52:47 2015 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.6/rev/2a87bf3caf4c877d899bf3994d4f99f7be33ab5b [^]

Fixes issue 30231: Wrong payment status under some circumstancies

comingFrom internal parameter in FIN_PaymentProcess.java was always setted to "TRANSACTION" instead of using received comingFrom value, when Automatic Deposit/Withdrawn was activated and execution type was Automatic and not Deferred.
Because of that, transaction was not created when creating a payment from Payment In or Payment Out with this configuration.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0078472)
vmromanos   
2015-06-24 10:15   
Code review + testing OK