Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030229Retail ModulesWeb POSpublic2015-06-23 09:432015-07-17 08:38
Reportermalsasua 
Assigned Toguilleaer 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030229: JS error when location is updated
Descriptionwhen a location is updated in web pos using the option: menu -> customer ->edit address, and the location is assigned to the ticket, JS error is returned (see video attached)

In version RR15Q1.5, with the same steps no JS error is returned, but pop up with error message is displayed:
"Cannot calculate receipt taxes
Cannot find taxes for Headlamp ultralight. The line affected will be deleted. Please ensure that there is at least one tax rate and tax rate zone configured for the partner address."
(see screenshot attached)
Steps To Reproducevideo attached
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0030738 closed mtaal Creating a new customer and assigning to the current receipt raises an error in taxes calculation 
Attached Files? issueLocation.ogv (1,955,457) 2015-06-23 09:43
https://issues.openbravo.com/file_download.php?file_id=8225&type=bug
png issueLocation.png (270,783) 2015-06-23 09:43
https://issues.openbravo.com/file_download.php?file_id=8226&type=bug
diff diffIssue30229.diff (7,984) 2015-07-01 12:25
https://issues.openbravo.com/file_download.php?file_id=8255&type=bug
diff diffIssue30299_mobilecore.diff (830) 2015-07-01 12:25
https://issues.openbravo.com/file_download.php?file_id=8256&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-23 09:43malsasuaNew Issue
2015-06-23 09:43malsasuaAssigned To => Retail
2015-06-23 09:43malsasuaFile Added: issueLocation.ogv
2015-06-23 09:43malsasuaResolution time => 1437861600
2015-06-23 09:43malsasuaTriggers an Emergency Pack => No
2015-06-23 09:43malsasuaFile Added: issueLocation.png
2015-06-23 09:43malsasuaDescription Updatedbug_revision_view_page.php?rev_id=8866#r8866
2015-06-23 09:43malsasuaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8868#r8868
2015-06-30 18:41guilleaerAssigned ToRetail => guilleaer
2015-07-01 12:25guilleaerFile Added: diffIssue30229.diff
2015-07-01 12:25guilleaerFile Added: diffIssue30299_mobilecore.diff
2015-07-01 12:26guilleaerNote Added: 0078605
2015-07-02 16:34hgbotCheckin
2015-07-02 16:34hgbotNote Added: 0078627
2015-07-02 16:34hgbotStatusnew => resolved
2015-07-02 16:34hgbotResolutionopen => fixed
2015-07-02 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/459d9e531882d2fe0bd097ea4a4dfbe869006757 [^]
2015-07-02 16:35hgbotCheckin
2015-07-02 16:35hgbotNote Added: 0078628
2015-07-02 16:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/459d9e531882d2fe0bd097ea4a4dfbe869006757 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25fc6c24fa75c19eadba49c63ea10c942aac3a8c [^]
2015-07-17 08:38migueldejuanaReview Assigned To => migueldejuana
2015-07-17 08:38migueldejuanaNote Added: 0078899
2015-07-17 08:38migueldejuanaStatusresolved => closed
2015-07-17 08:38migueldejuanaFixed in Version => RR15Q3
2015-09-04 16:02mtaalRelationship addedcauses 0030738

Notes
(0078605)
guilleaer   
2015-07-01 12:26   
Attached 2 patches to fix the issue.

They will be commited soon.
(0078627)
hgbot   
2015-07-02 16:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 459d9e531882d2fe0bd097ea4a4dfbe869006757
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jul 02 12:04:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/459d9e531882d2fe0bd097ea4a4dfbe869006757 [^]

Fixed issue 30229: BPLocation is wrongly saved when Customer is saved

Before the fix: When a customer was saved a new BP location is created from scratch. Doing it we lost the information of country and region.
After the fix: When a customer is updated the current BPLocation is loaded and then this location is updated.

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0078628)
hgbot   
2015-07-02 16:35   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 25fc6c24fa75c19eadba49c63ea10c942aac3a8c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jul 02 12:11:09 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/25fc6c24fa75c19eadba49c63ea10c942aac3a8c [^]

Fixed issue 30229: OB.Dal.queryUsingCache function should return arguments if they are received.

This function should return arguments when they are received. This is what we do in other functions like OB.Dal.query

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0078899)
migueldejuana   
2015-07-17 08:38   
Tested and reviewed in 976cfed505b7