Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030222Openbravo ERPA. Platformpublic2015-06-22 12:382015-06-23 16:47
AugustoMauch 
inigosanchez 
highminoralways
closedfixed 
5
 
3.0PR15Q33.0PR15Q3 
caristu
Core
Production - Confirmed Stable
2014-09-05
3.0PR14Q4
https://code.openbravo.com/erp/devel/pi/rev/dc8d0777f38d8678aef43fd4044d8801a56f39d8 [^]
No
0030222: Delete popup is not hidden if two or more rows are deleted at the same time
If two or more records are selected and deleted, the records are deleted properly but the "Deleting..." popup is not hidden. The user will not be able to interact with the window until he refreshes it.
As F&B Admin:
- Open the Product Category window
- Create two product categories
- In grid view, select the two product categories you just created and delete them
- Check that the "Deleting..." popup is not hidden

Note that when the Delete toolbar button is pressed this message is shown in the javascript console:

Uncaught TypeError: undefined is not a function
No tags attached.
depends on backport 00302233.0PR15Q2.3 closed inigosanchez Delete popup is not hidden if two or more rows are deleted at the same time 
depends on backport 00302243.0PR15Q1.6 closed inigosanchez Delete popup is not hidden if two or more rows are deleted at the same time 
caused by defect 00263843.0PR14Q4 closed inigosanchez The tree grid view is not refreshed after deleting a record 
png DeletingPopup.png (82,735) 2015-06-22 12:38
https://issues.openbravo.com/file_download.php?file_id=8221&type=bug
png
Issue History
2015-06-22 12:38AugustoMauchNew Issue
2015-06-22 12:38AugustoMauchAssigned To => platform
2015-06-22 12:38AugustoMauchFile Added: DeletingPopup.png
2015-06-22 12:38AugustoMauchModules => Core
2015-06-22 12:38AugustoMauchTriggers an Emergency Pack => No
2015-06-22 13:08AugustoMauchRegression level => Production - Confirmed Stable
2015-06-22 13:08AugustoMauchRegression date => 2014-09-05
2015-06-22 13:08AugustoMauchRegression introduced in release => 3.0PR14Q4
2015-06-22 13:08AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/dc8d0777f38d8678aef43fd4044d8801a56f39d8 [^]
2015-06-22 13:08AugustoMauchRelationship addedcaused by 0026384
2015-06-22 13:09caristuSeveritymajor => minor
2015-06-22 13:09AugustoMauchAssigned Toplatform => inigosanchez
2015-06-22 13:11caristuNote Added: 0078414
2015-06-22 13:12caristuStatusnew => scheduled
2015-06-23 10:16inigosanchezIssue Monitored: caristu
2015-06-23 10:17inigosanchezReview Assigned To => caristu
2015-06-23 10:18hgbotCheckin
2015-06-23 10:18hgbotNote Added: 0078419
2015-06-23 10:18hgbotStatusscheduled => resolved
2015-06-23 10:18hgbotResolutionopen => fixed
2015-06-23 10:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b727e3caf4c29038b59d0f7b84feeaea4c9751d1 [^]
2015-06-23 16:02caristuNote Added: 0078433
2015-06-23 16:02caristuStatusresolved => closed
2015-06-23 16:02caristuFixed in Version => 3.0PR15Q3
2015-06-23 16:08caristuTarget Version => 3.0PR15Q3
2015-06-23 16:47hudsonbotCheckin
2015-06-23 16:47hudsonbotNote Added: 0078441

Notes
(0078414)
caristu   
2015-06-22 13:11   
Updated severity to minor. This issue only affects to those windows that have a tree structure associated to it. The records are removed but the pop-up is not hidden because of the js error.
(0078419)
hgbot   
2015-06-23 10:18   
Repository: erp/devel/pi
Changeset: b727e3caf4c29038b59d0f7b84feeaea4c9751d1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Jun 23 10:14:39 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b727e3caf4c29038b59d0f7b84feeaea4c9751d1 [^]

Fixes issue 30222: delete popup is not hidden under some circumstances

The problem was that if two or more records were selected and deleted, the records were deleted properly but the "Deleting..." popup is not hidden.
The user will not be able to interact with the window until he refreshes it. This happends when in a grid that contains a tree grid view

This happened when a grid contains a treegrid and this one is not open first. In that case this element "view.treeGrid.data.handleUpdate" has not been created yet.

To avoid the problem, it has added a condition that checks whether the properties have been started correctly and thus, if the properties can be accessed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0078433)
caristu   
2015-06-23 16:02   
Code review + tested OK
(0078441)
hudsonbot   
2015-06-23 16:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1697e5e9cd2d [^]
Maturity status: Test