Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030189Openbravo ERPA. Platformpublic2015-06-16 13:152015-06-18 18:32
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030189: Values are overwritten under some circumstances in Modify Payment Plan
DescriptionValues are overwritten under some circumstances in Modify Payment Plan
Steps To Reproduce1) As System Administrator, display "Modify Payment Plan" button in Payment Plan tab of Sales Invoice window
2) As Group Admin, Create new Sales Invoice document. Add line and process
3) Go to Payment Plan tab and click on "Modify Payment Plan" button
4) Create two new lines
5) Edit the Payment Method for the last line
6) Click on the previous line (this is a new created record too). Notice that the values of this record has been replaced with the ones of the record edited in step 5)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030060 closed caristu Select Payments Pick&Edit window is not working properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-16 13:15caristuNew Issue
2015-06-16 13:15caristuAssigned To => platform
2015-06-16 13:15caristuModules => Core
2015-06-16 13:15caristuTriggers an Emergency Pack => No
2015-06-16 13:15caristuRelationship addedrelated to 0030060
2015-06-16 13:15caristuIssue Monitored: networkb
2015-06-16 13:17caristuAssigned Toplatform => caristu
2015-06-16 13:17caristuTarget Version => 3.0PR15Q3
2015-06-16 18:13caristuAssigned Tocaristu => alostale
2015-06-16 18:13caristuAssigned Toalostale => caristu
2015-06-16 18:13caristuIssue Monitored: alostale
2015-06-16 18:13caristuReview Assigned To => alostale
2015-06-16 18:15hgbotCheckin
2015-06-16 18:15hgbotNote Added: 0078328
2015-06-16 18:15hgbotStatusnew => resolved
2015-06-16 18:15hgbotResolutionopen => fixed
2015-06-16 18:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/030458458cf6c0a3762c4889f3cd18118e2ca459 [^]
2015-06-16 18:52hgbotCheckin
2015-06-16 18:52hgbotNote Added: 0078329
2015-06-18 08:48alostaleNote Added: 0078360
2015-06-18 08:48alostaleStatusresolved => closed
2015-06-18 08:48alostaleFixed in Version => 3.0PR15Q3
2015-06-18 18:32hudsonbotCheckin
2015-06-18 18:32hudsonbotNote Added: 0078379
2015-06-18 18:32hudsonbotCheckin
2015-06-18 18:32hudsonbotNote Added: 0078380

Notes
(0078328)
hgbot   
2015-06-16 18:15   
Repository: erp/devel/pi
Changeset: 030458458cf6c0a3762c4889f3cd18118e2ca459
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jun 16 18:13:08 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/030458458cf6c0a3762c4889f3cd18118e2ca459 [^]

Fixes issue 30189: Values could be overwritten in Modify Payment Plan

In the Modify Payment Plan grid an add function is creating an object to set the values for the new records. This function is setting an empty string for the id property, i.e., every new created record is generated with the same id. This causes that the selection record change is not handled properly under some circumstances in the _startEditing method of the ListGrid class.
To avoid this problem, the id property is not included in the object instead of leaving it empty.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0078329)
hgbot   
2015-06-16 18:52   
Repository: erp/devel/pi
Changeset: ef5f37a64b57b02e48ac7dc1430fa04e4180c5ae
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jun 16 18:52:11 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ef5f37a64b57b02e48ac7dc1430fa04e4180c5ae [^]

Related to issue 30189: Adapt process handler to retrieve objects without id

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ModifyPaymentPlanActionHandler.java
---
(0078360)
alostale   
2015-06-18 08:48   
code reviewed + tested
(0078379)
hudsonbot   
2015-06-18 18:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/42df4e2c6b02 [^]
Maturity status: Test
(0078380)
hudsonbot   
2015-06-18 18:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/42df4e2c6b02 [^]
Maturity status: Test