Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030185Openbravo ERPZ. Otherspublic2015-06-15 18:542015-06-24 02:56
Reporterngarcia 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030185: AlertsForWrongOrders modulescript is generating wrong alerts
DescriptionAlertsForWrongOrders modulescript is generating wrong alerts. It is creating an alert for orders with payments in awaiting execution status
Steps To ReproduceAs group admin role:
   Create a Payment Method with automatic execution type
   Add it to a Financial Account
   Create a Purchase Order and add the previously created payment method
   Add a payment to it
   Check the Paid amount in the Sales Order Payment plan is 0 but the Paid Amount in the Payment Details tab is not 0
   Compile the application (ant smartbuild -Dlocal=no) and restart Tomcat
   Check a new alert has been created:
      Wrong Purchase Order Payment Plan
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00301663.0PR15Q3 closed aferraz Wrong order payment plan with isinvoicepaid feature 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-15 18:54ngarciaNew Issue
2015-06-15 18:54ngarciaAssigned To => Triage Finance
2015-06-15 18:54ngarciaModules => Advanced Payables and Receivables Mngmt
2015-06-15 18:54ngarciaResolution time => 1437948000
2015-06-15 18:54ngarciaTriggers an Emergency Pack => No
2015-06-15 18:56ngarciaRelationship addedrelated to 0030166
2015-06-15 19:12ngarciaIssue Monitored: networkb
2015-06-15 19:13ngarciaNote Added: 0078303
2015-06-16 12:13aferrazAssigned ToTriage Finance => aferraz
2015-06-16 17:27aferrazStatusnew => scheduled
2015-06-23 17:04hgbotCheckin
2015-06-23 17:04hgbotNote Added: 0078442
2015-06-23 17:04hgbotStatusscheduled => resolved
2015-06-23 17:04hgbotResolutionopen => fixed
2015-06-23 17:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c85e2fa57fa1c4bc0a4ae825e98fe82c075729c6 [^]
2015-06-23 17:04vmromanosReview Assigned To => vmromanos
2015-06-23 17:04vmromanosNote Added: 0078443
2015-06-23 17:04vmromanosStatusresolved => closed
2015-06-24 02:56hudsonbotCheckin
2015-06-24 02:56hudsonbotNote Added: 0078463

Notes
(0078303)
ngarcia   
2015-06-15 19:13   
The same happens for payments in In Remittance (REM_SENT) status
(0078442)
hgbot   
2015-06-23 17:04   
Repository: erp/devel/pi
Changeset: c85e2fa57fa1c4bc0a4ae825e98fe82c075729c6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 17 19:17:55 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c85e2fa57fa1c4bc0a4ae825e98fe82c075729c6 [^]

Fixes issue 30185: AlertsForWrongOrders modulescript generates wrong alerts

The query of the modulescript did not take into account the isinvoicepaid status (if the payment was paid or not) to check if the amount of the paymentschedule was correct.

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrders_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.java
---
(0078443)
vmromanos   
2015-06-23 17:04   
Code review + testing OK

(verified also with remittance flows)
(0078463)
hudsonbot   
2015-06-24 02:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0a35ad8c7048 [^]
Maturity status: Test