Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030176Retail ModulesDiscounts and Promotionspublic2015-06-15 10:282015-09-04 15:03
Reporterasiermartirena 
Assigned Tojorge-garcia 
PriorityimmediateSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelCode review
Regression date2015-05-05
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1c1c77a3384b2225f92d600ae03073ada0c5c0d [^]
Triggers an Emergency PackNo
Summary0030176: Problem with identifier attribute created to show discounts
DescriptionWhen adding a promotion to a product list, an identifier attribute is generated to show a customized name for that promotion. Then, when rendering the line that identifier value is taken and assigned to show in the discount line.
This identifier is not stored in any column in database, so when someone tries to generate again the ticket (for example when creating a return ticket), the line renderization tries to access to the not stored identifier value. This casuses that 'undefined' value is shown for the recovered discount line.
Steps To ReproduceCreate a ticket and add a discount to a product. Pay the ticket.
Return the ticket and select the product with the discount.

In the order created the discount will be shown with the name 'undefined'.
Proposed SolutionCreate a new column to store the identifier value, and only fill it if the identifier is needed. Then, when creating the discount component don't assign the identifier directly. Check if the identifier is filled, and else assign the name value.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030298RR15Q3 closed Retail Problem with identifier attribute created to show discounts 
related to defect 0030385 scheduled Retail [RR15Q3] Discount label appears as "undefined" if the receipt where discount is applied is chosen in Layaways dropdown menu 
Attached Filesdiff 30176_posterminal.diff (2,795) 2015-07-01 13:10
https://issues.openbravo.com/file_download.php?file_id=8257&type=bug
diff 30176_discounts.diff (5,879) 2015-07-01 13:10
https://issues.openbravo.com/file_download.php?file_id=8258&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-15 10:28asiermartirenaNew Issue
2015-06-15 10:28asiermartirenaAssigned To => Retail
2015-06-15 10:28asiermartirenaRegression level => Code review
2015-06-15 10:28asiermartirenaRegression date => 2015-05-05
2015-06-15 10:28asiermartirenaRegression introduced in release => main
2015-06-15 10:28asiermartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1c1c77a3384b2225f92d600ae03073ada0c5c0d [^]
2015-06-15 10:28asiermartirenaTriggers an Emergency Pack => No
2015-06-29 16:21asiermartirenaFile Added: 30176_discounts.diff
2015-06-29 16:21asiermartirenaFile Added: 30176_posterminal.diff
2015-07-01 13:09asiermartirenaFile Deleted: 30176_discounts.diff
2015-07-01 13:10asiermartirenaFile Deleted: 30176_posterminal.diff
2015-07-01 13:10asiermartirenaFile Added: 30176_posterminal.diff
2015-07-01 13:10asiermartirenaFile Added: 30176_discounts.diff
2015-07-02 10:03marvintmStatusnew => scheduled
2015-07-17 09:08lorenzofidalgoRelationship addedrelated to 0030385
2015-08-14 13:26hgbotCheckin
2015-08-14 13:26hgbotNote Added: 0079358
2015-08-14 13:26hgbotStatusscheduled => resolved
2015-08-14 13:26hgbotResolutionopen => fixed
2015-08-14 13:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa0b535fc3e586c30aee23dbe8665b97736c6c43 [^]
2015-08-14 13:26hgbotCheckin
2015-08-14 13:26hgbotNote Added: 0079360
2015-08-14 13:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa0b535fc3e586c30aee23dbe8665b97736c6c43 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa [^]
2015-08-14 14:26hgbotCheckin
2015-08-14 14:26hgbotNote Added: 0079363
2015-08-14 14:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3037b3f02cf7bca0c99b8a77974782465772108f [^]
2015-08-31 09:19marvintmAssigned ToRetail => jorge-garcia
2015-08-31 09:19marvintmReview Assigned To => marvintm
2015-08-31 09:19marvintmStatusresolved => closed
2015-08-31 09:19marvintmFixed in Version => RR15Q4
2015-09-04 15:03hgbotCheckin
2015-09-04 15:03hgbotNote Added: 0080126

Notes
(0079358)
hgbot   
2015-08-14 13:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aa0b535fc3e586c30aee23dbe8665b97736c6c43
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Aug 11 09:59:45 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa0b535fc3e586c30aee23dbe8665b97736c6c43 [^]

Fixes issue 30176, port of issue 30298: Changed needed in posterminal module

order.js file must be changed too.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079360)
hgbot   
2015-08-14 13:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Aug 07 14:10:39 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/acfc788c2c5ce9401c9fe9a1d1a4e5a30d9082aa [^]

Fixes issue 30176, port of issue 30298: Changed needed in posterminal module

Some changes are required for the implementation of the discounts module
changes.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
---
(0079363)
hgbot   
2015-08-14 14:26   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 3037b3f02cf7bca0c99b8a77974782465772108f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Aug 03 09:46:20 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3037b3f02cf7bca0c99b8a77974782465772108f [^]

Fixes issue 30176, port of issue 30298: Problem with identifier attribute created to show discounts

The problem was that the identifier of the issue is not saved in the database.

The solution is to create a new column that stores the identifier, and retrieve
the discount identifier from the database.

---
M src-db/database/model/modifiedTables/C_ORDERLINE_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
---
(0080126)
hgbot   
2015-09-04 15:03   
Repository: tools/automation/pi-mobile
Changeset: f265fb38240e589f36858e0ea22a5ed334b7bef4
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Sep 04 15:02:58 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f265fb38240e589f36858e0ea22a5ed334b7bef4 [^]

Related to issue 30176: Added the 'I30176_UndefinedDiscountWhenReturning' test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30176_UndefinedDiscountWhenReturning.java
---