0030174: Triggers temporarily disabled for whole application through webpos

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0030174

Retail Modules

Web POS

public

2015-06-13 13:30

2015-06-29 09:36

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q3

Fixed in Version

RR15Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0030174: Triggers temporarily disabled for whole application through webpos

Description

When running webpos in a high load environment it shows that sometimes triggers are enabled in the middle of the cashup backend code, causing the code to fail (see attached stack trace for an example).

What causes this is that the triggers disabled record in AD_SESSION_STATUS gets committed and is visible for other connections, these connections/threads also enable triggers after their work, effectively deleting the AD_SESSION_STATUS record, this again results in the original thread having triggers enabled during processing.

Exact flow:
Thread 1: does cashup by first disabling triggers and creating AD_SESSION_STATUS record, this record should only be visible to thread 1 as the insert should not be committed. But it is...
Thread 1: calls ordergrouping processor which does commit, now everyone sees the new AD_SESSION_STATUS record
Thread 2: was already doing work, disabling triggers in his own connection, and then enabling them again, this removes all AD_SESSION_STATUS records visible to the connection of thread 2, this now also includes the AD_SESSION_STATUS record created for thread 1, so AD_SESSION_STATUS for thread 1 also gets deleted.
Thread 1: tries to do its remaining work but gets an error because triggers are suddenly enabled again because thread 2 deleted it AD_SESSION_STATUS record.

Caused by this change:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4685#l1.361 [^]

Steps To Reproduce

Run stress test simulate business day with 2 nodes and 5 clients each. One run will result in several errors in OBPOS import errors

Proposed Solution

Replace this line:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4685#l1.361 [^]

with OBDal.getInstance().flush()

Also add a check to the SessionHandler commit code to not allow commits when triggers are enabled.

Additional Information

Tags

No tags attached.

Relationships

caused by	defect	0029774	RR15Q3	closed	malsasua	Retail Modules	[cashup refactor] improve the performance of cashup
related to	design defect	0029611		acknowledged	Triage Platform Base	Openbravo ERP	The way we disable triggers with TriggerHandler may lead to leaving the triggers disabled indefinitly