Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030161Retail ModulesWeb POSpublic2015-06-11 17:182015-06-26 09:42
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q3 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030161: Sales Representative is not incrementaly refreshed in some circumstances
DescriptionIf a field of Business partner is updated and this business partner is marked as sales representative, the information about this sales representative which is stored in c_bpartner table is not updated by incremental refresh engine
Steps To Reproduce1. Create a business partner. Don't mark it as employee non as sales representative.
2. Add a contact to the business partner
3. Check that a user has been created
4. Login in Web POS from scratch
5. Check sales representative information(receipt properties -> sales representative button -> search without any filter). The new sales representative will not appear.
6. from backend go to the new business partner and markt it as employee and sales representative
7. wait until incremental refresh is executed
8. Check again sales representative from WEB POS. New sales representative is not there
Proposed SolutionIncremental refresh of BP should be also verified when sales representative information is retrieved.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-11 17:18guilleaerNew Issue
2015-06-11 17:18guilleaerAssigned To => guilleaer
2015-06-11 17:18guilleaerTriggers an Emergency Pack => No
2015-06-11 17:33guilleaerDescription Updatedbug_revision_view_page.php?rev_id=8824#r8824
2015-06-11 17:33guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8826#r8826
2015-06-24 12:18hgbotCheckin
2015-06-24 12:18hgbotNote Added: 0078480
2015-06-24 12:18hgbotStatusnew => resolved
2015-06-24 12:18hgbotResolutionopen => fixed
2015-06-24 12:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d80f8cf8501f34af2476adbc536b83e64956492 [^]
2015-06-25 09:35migueldejuanaNote Added: 0078497
2015-06-25 09:35migueldejuanaStatusresolved => new
2015-06-25 09:35migueldejuanaResolutionfixed => open
2015-06-26 09:34hgbotCheckin
2015-06-26 09:34hgbotNote Added: 0078522
2015-06-26 09:37guilleaerStatusnew => scheduled
2015-06-26 09:37guilleaerNote Added: 0078526
2015-06-26 09:37guilleaerStatusscheduled => resolved
2015-06-26 09:37guilleaerResolutionopen => fixed
2015-06-26 09:42migueldejuanaReview Assigned To => migueldejuana
2015-06-26 09:42migueldejuanaNote Added: 0078527
2015-06-26 09:42migueldejuanaStatusresolved => closed
2015-06-26 09:42migueldejuanaFixed in Version => RR15Q3

Notes
(0078480)
hgbot   
2015-06-24 12:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2d80f8cf8501f34af2476adbc536b83e64956492
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Jun 11 17:42:25 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d80f8cf8501f34af2476adbc536b83e64956492 [^]

Fixed issue 30161: Incremental refresh for sales representative is now taking into account Business Partner Information

After that fix, sales repreentative is updated if some information is changed in the related BP entity.

---
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
---
(0078497)
migueldejuana   
2015-06-25 09:35   
We should attach incremental refresh like this example:

(bp.$incrementalUpdateCriteria) "
        + jsonsent.get("operator") + " (bp.priceAdjustment.$incrementalUpdateCriteria)

If we are doing total refresh, it checks if both are active, so operator=AND. In incremental refresh we check updateDate, so operator=OR.
(0078522)
hgbot   
2015-06-26 09:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9aad970387293d4bc0bed0e537ff1b444881eb91
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Jun 26 09:33:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9aad970387293d4bc0bed0e537ff1b444881eb91 [^]

Related to issue 30161: AND | OR operator are used depending on total or incremental refresh

I need to do that because when total refresh is executed we are checking that both entities are active so we need to use AND operator.
When Incremental update is done we want tu update entities which has changed so we use OR as operator

---
M src/org/openbravo/retail/posterminal/master/SalesRepresentative.java
---
(0078526)
guilleaer   
2015-06-26 09:37   
Resolved again:

http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9aad970387293d4bc0bed0e537ff1b444881eb91 [^]
(0078527)
migueldejuana   
2015-06-26 09:42   
Tested and reviewd in 9aad97038729