Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0030138Openbravo ERP09. Financial managementpublic2015-06-09 13:402016-02-02 09:35
aferraz 
aferraz 
immediatemajoralways
closedfixed 
30Professional Appliance
 
3.0PR15Q3 
vmromanos
Core
Production - Confirmed Stable
2015-03-17
3.0PR15Q1.2
https://code.openbravo.com/erp/devel/pi/rev/fb806ae22a47f529125e7528e58c0985b0238898 [^]
No
0030138: Error in Add Payment when generating credit and adding a negative line
Error in Add Payment when generating credit and adding a negative line
As F&B Admin:

- Create a Payment In from "Alimentos y Supermercados" and amount = 10
  Click on Add Details button
  Uncheck all records in Order/Invoice grid
  Add a G/L Item = "Capital social" and Paid Out = 1
  Set Action Regarding Document = "Process Received Payment(s) and Deposit" and Overpayment Action = "Leave the credit to be used later"
  Realize an error is shown: "Credit amount should not be greater than total amount"
No tags attached.
depends on backport 00301393.0PR15Q2.2 closed aferraz Error in Add Payment when generating credit and adding a negative line 
depends on backport 00301403.0PR15Q1.5 closed aferraz Error in Add Payment when generating credit and adding a negative line 
caused by defect 0029145 closed Sandrahuguet Used credit is not correct under certain circumstances 
blocks defect 00300773.0PR15Q4 closed aferraz Customer Balance not working properly with multicurrency credit 
Issue History
2015-06-09 13:40aferrazNew Issue
2015-06-09 13:40aferrazAssigned To => aferraz
2015-06-09 13:40aferrazModules => Core
2015-06-09 13:40aferrazRegression level => Production - Confirmed Stable
2015-06-09 13:40aferrazRegression date => 2015-03-17
2015-06-09 13:40aferrazRegression introduced in release => 3.0PR15Q2
2015-06-09 13:40aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/fb806ae22a47f529125e7528e58c0985b0238898 [^]
2015-06-09 13:40aferrazTriggers an Emergency Pack => No
2015-06-09 13:41aferrazRelationship addedblocks 0030077
2015-06-09 13:42aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8784#r8784
2015-06-09 13:42aferrazRelationship addedcaused by 0029145
2015-06-09 13:58aferrazStatusnew => scheduled
2015-06-09 14:12aferrazNote Added: 0078158
2015-06-11 16:24hgbotCheckin
2015-06-11 16:24hgbotNote Added: 0078213
2015-06-11 16:24hgbotStatusscheduled => resolved
2015-06-11 16:24hgbotResolutionopen => fixed
2015-06-11 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3eaa0f22f0db3c3bfcb3cfad6abbd8bd0e5b1246 [^]
2015-06-11 16:29vmromanosReview Assigned To => vmromanos
2015-06-11 16:29vmromanosNote Added: 0078216
2015-06-11 16:29vmromanosStatusresolved => closed
2015-06-11 19:59dmitry_mezentsevRegression introduced in release3.0PR15Q2 => 3.0PR15Q1.2
2015-06-11 22:43hudsonbotCheckin
2015-06-11 22:43hudsonbotNote Added: 0078225
2016-02-02 09:35hgbotCheckin
2016-02-02 09:35hgbotNote Added: 0083808

Notes
(0078158)
aferraz   
2015-06-09 14:12   
Test plan:

As F&B Admin:

- Create a Payment In from "Alimentos y Supermercados" and amount = 10
  Click on Add Details button
  Uncheck all records in Order/Invoice grid
  Add a G/L Item = "Capital social" and Paid Out = 1
  Set Action Regarding Document = "Process Received Payment(s) and Deposit" and Overpayment Action = "Leave the credit to be used later"
  Realize no error is shown

- Go to Payment In and create a new payment with this data:
  Paying to: Restaurantes Luna Llena, S.A.
  Amount: 3000.00
  Click Add Details button and complete the pop-up:
  Actual Payment: 3000
  Action Regarding Document: Process Received Payment(s)
  Overpayment Action: Leave the credit to be used later
  Click Done button

- Go to Sales Invoice and create new:
  Organization: F&B España - Región Norte
  Business Partner: Restaurantes Luna Llena, S.A.
  Lines: Cerveza Ale 0,5L ; Qty:1000
  Complete it

- Go to Payment In and create a new payment with this data:
  Paying to: Restaurantes Luna Llena, S.A.
  Amount 0
  Click Add Details button and complete the pop-up:
  Actual Payment: 0.00
  On Credit To Use, check off the credit created in previous step and set payment amount to 3000,00
  In order/invoices grid select the invoice created in previous step (2468.40 amount)
  Action Regarding Document: Process Received Payment(s)
  Overpayment Action: Leave the credit to be used later
  Click Done button
  Realize an error is shown: "Credit amount should not be greater than total amount"

- Repeat the same test with Payment Out flow.
(0078213)
hgbot   
2015-06-11 16:24   
Repository: erp/devel/pi
Changeset: 3eaa0f22f0db3c3bfcb3cfad6abbd8bd0e5b1246
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 10 16:55:01 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3eaa0f22f0db3c3bfcb3cfad6abbd8bd0e5b1246 [^]

Fixes issue 30138: Error when generating credit and adding a negative line

Add Payment was raising an error if credit used was greater than total amount.
Now, this comprobation will only be done if some record has been selected in Credit To Use grid.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0078216)
vmromanos   
2015-06-11 16:29   
Code review + testing OK
(0078225)
hudsonbot   
2015-06-11 22:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/559a6242635c [^]
Maturity status: Test
(0083808)
hgbot   
2016-02-02 09:35   
Repository: tools/automation/int
Changeset: 0bd4b1d3c8f4bdb75700196c1b33f31d24b52f75
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 25 09:42:47 2015 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/0bd4b1d3c8f4bdb75700196c1b33f31d24b52f75 [^]

Related to issue 30138: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression023.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRRegression024.java
---