Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030134Openbravo ERPA. Platformpublic2015-06-09 12:492022-09-05 09:37
Reporteraferraz 
Assigned ToNaroaIriarte 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR15Q3Fixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030134: Error when executing a Process Definition if a parameter has defined a numeric default value
DescriptionError when executing a Process Definition if a parameter has defined a numeric default value
Steps To ReproduceAs System Admin:

- Open "Set New Currency" in Process Definition window
  Open "Rate" in Parameter tab
  Realize default value is = 1 (if not, set it)

As F&B Admin:

- Select any record in Business Partner window
  Click on "Set New Currency" button
  Realize in chrome console the following exception is raised: "Uncaught TypeError: numberStr.match is not a function"
Proposed SolutionIn ob-utilities-number.js check if numberStr is a number instead of a string and in this case convert it to string before accessing to numberStr.match and to numberStr.substring
Additional Information
TagsNo tags attached.
Relationships
related to defect 00300773.0PR15Q4 closed aferraz Customer Balance not working properly with multicurrency credit 
Attached Filesdiff issue30134.diff (1,901) 2015-06-25 16:33
https://issues.openbravo.com/file_download.php?file_id=8230&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-09 12:49aferrazNew Issue
2015-06-09 12:49aferrazAssigned To => platform
2015-06-09 12:49aferrazOBNetwork customer => No
2015-06-09 12:49aferrazModules => Core
2015-06-09 12:49aferrazTriggers an Emergency Pack => No
2015-06-09 12:52aferrazRelationship addedrelated to 0030077
2015-06-18 09:18alostalePrioritynormal => high
2015-06-18 09:18alostaleStatusnew => acknowledged
2015-06-18 09:18alostaleAssigned Toplatform => NaroaIriarte
2015-06-24 19:10caristuStatusacknowledged => scheduled
2015-06-25 16:31NaroaIriarteIssue Monitored: alostale
2015-06-25 16:31NaroaIriarteReview Assigned To => alostale
2015-06-25 16:33NaroaIriarteFile Added: issue30134.diff
2015-06-26 14:16NaroaIriarteReview Assigned Toalostale => caristu
2015-06-26 14:16NaroaIriarteIssue Monitored: caristu
2015-06-26 14:25hgbotCheckin
2015-06-26 14:25hgbotNote Added: 0078538
2015-06-26 14:25hgbotStatusscheduled => resolved
2015-06-26 14:25hgbotResolutionopen => fixed
2015-06-26 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e28ea5f9e072de849b72e2b815c140cd5a2ae54f [^]
2015-06-26 14:25caristuFixed in Version => 3.0PR15Q3
2015-06-26 14:28caristuNote Added: 0078539
2015-06-26 14:28caristuStatusresolved => closed
2015-06-30 00:54hudsonbotCheckin
2015-06-30 00:54hudsonbotNote Added: 0078578
2022-09-05 09:37YukisanNote Added: 0140693
2022-09-05 12:04shuehnerNote Deleted: 0140693

Notes
(0078538)
hgbot   
2015-06-26 14:25   
Repository: erp/devel/pi
Changeset: e28ea5f9e072de849b72e2b815c140cd5a2ae54f
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Jun 25 16:37:07 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e28ea5f9e072de849b72e2b815c140cd5a2ae54f [^]

Fixed issue 30134: Error executing a process definition if a param. is numeric

The problem was that if a parameter was defined as default with a numeric value,
an error was got.

The problem was in the "ob-parameter-window-view.js", there is a function called
getTypeSafeValue which was not taking into account the fact of having the "value"
argument as a numeric value. That was why it was not working fine.

To fix this a new condition has been added. Now it is checked if the "value" parameter
is a number.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0078539)
caristu   
2015-06-26 14:28   
Code review + tested OK
(0078578)
hudsonbot   
2015-06-30 00:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d846f99ad0b [^]
Maturity status: Test