Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030129ModulesService Contract Managementpublic2015-06-08 18:202015-06-19 09:53
Reporterngarcia 
Assigned Tovmromanos 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0030129: Product filter of Contract Billing process is not taken into account for orders pending to be invoiced
DescriptionProduct filter of Contract Billing process is not taken into account for orders pending to be invoiced
Steps To ReproduceAs group admin role:
   Configure a Contract and complete it
   Create a Sales Order for the same business partner defined in the contract. Set the Invoice Terms as Contract Billing and assign the Contract
   Add a product different from the one defined in the contract
   Go to Contract Billing Process and set the product defined in the Contract in the product filter, select the From Order and From Contract checkboxes and launch it
   Check the Sales Order is invoiced although the product is not included in the filter
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-08 18:20ngarciaNew Issue
2015-06-08 18:20ngarciaAssigned To => Triage Finance
2015-06-08 18:20ngarciaResolution time => 1437343200
2015-06-08 18:20ngarciaIssue Monitored: networkb
2015-06-12 14:48vmromanosStatusnew => scheduled
2015-06-12 14:48vmromanosAssigned ToTriage Finance => vmromanos
2015-06-12 15:09hgbotCheckin
2015-06-12 15:09hgbotNote Added: 0078255
2015-06-12 15:09hgbotStatusscheduled => resolved
2015-06-12 15:09hgbotResolutionopen => fixed
2015-06-12 15:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/372fbb615c5c0de1bb081475b53dd5d7d3b3e340 [^]
2015-06-12 15:10vmromanosNote Added: 0078256
2015-06-15 12:41vmromanosNote Added: 0078295
2015-06-19 09:53vmromanosReview Assigned To => vmromanos
2015-06-19 09:53vmromanosNote Added: 0078386
2015-06-19 09:53vmromanosStatusresolved => closed

Notes
(0078255)
hgbot   
2015-06-12 15:09   
Repository: erp/pmods/org.openbravo.contract.services
Changeset: 372fbb615c5c0de1bb081475b53dd5d7d3b3e340
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Jun 12 15:07:10 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/372fbb615c5c0de1bb081475b53dd5d7d3b3e340 [^]

Fixed bug 30129: Product filter for Order billing

Transplanted changeset from spm* branches

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/contract/services/dao/ServicesContractDao.java
---
(0078256)
vmromanos   
2015-06-12 15:10   
Fixed in Service Contract Management 1.2.21 or higher
(0078295)
vmromanos   
2015-06-15 12:41   
Configuration steps:

Configure a Contract. Fill the necessary mandatory fields.
  Start date: 01-01-2015
  Duration: 1 year
  Invoice schedule: Monthly
Enter any product in the invoice plan.
  Start date: 01-01-2015
Complete the contract and generate the invoice plan.

Create a Sales Order for the same business partner defined in the contract.
  Order date: today
  Invoice Terms: Contract Billing
  Contract: the one defined before
Add a product different from the one defined in the contract
Book the order



Test plan I:

Go to Contract Billing Process:
   From Order = Y
   From Contract = Y
   Start Date = 01-01-2015
   End Date = 31-12-2015
   Product = Any Product different from the one included into the contract and the sales order
Verify no invoice is created.


Test plan II:

Go to Contract Billing Process:
   From Order = Y
   From Contract = Y
   Start Date = 01-01-2015
   End Date = 31-12-2015
   Product = product included into the sales order
Verify an invoice is created.
Do not complete the invoice proposal.


Test plan III:

Go to Contract Billing Process:
   From Order = Y
   From Contract = Y
   Start Date = 01-01-2015
   End Date = 31-12-2015
   Product = product included into the sales order and into the contract
Verify several invoices are created. In one of them, it will be included the normal invoice plan line + the product in the sales order.
Do not complete the invoice proposal.


Test plan IV:

Go to Contract Billing Process:
   From Order = Y
   From Contract = Y
   Start Date = 01-01-2015
   End Date = 31-12-2015
   Product = leave empty
Verify several invoices are created. In one of them, it will be included the normal invoice plan line + the product in the sales order.
(0078386)
vmromanos   
2015-06-19 09:53   
Closed because it's just a transplant from another branch