Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030112Openbravo ERPA. Platformpublic2015-06-05 10:442015-06-10 15:42
Reporterairaceburu 
Assigned ToNaroaIriarte 
PriorityimmediateSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-04-02
Regression introduced in release3.0MP12
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/588bdc741142 [^]
Triggers an Emergency PackNo
Summary0030112: When trying to save a data package with wrong java package the trigger shows a wrong ad_message
DescriptionWhen trying to save a data package with wrong java package the trigger shows a wrong ad_message '@20102@' -> "Saving failed. Cannot delete/change line with generated Invoice".

This happens when the java package of the module is not contained in the java package of the data package.

Also the trigger (ad_package_jp_trg) has a duplicated where condition:

   WHERE M.AD_MODULE_ID = new.AD_MODULE_ID
      AND instr(upper(new.javapackage), upper(M.javapackage)) = 1
      AND instr(upper(new.javapackage), upper(M.javapackage)) = 1;
Steps To ReproduceCreate a module

Create a data package whose java package does not contain the module java package
Proposed SolutionChange the ad_message code

Remove the repeated clause
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0012599 closed naiaramartinez Find and fix all RAISE_APPLICATION_ERROR with first parameter not being -20000 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-05 10:44airaceburuNew Issue
2015-06-05 10:44airaceburuAssigned To => platform
2015-06-05 10:44airaceburuModules => Core
2015-06-05 10:44airaceburuRegression level => Production - Confirmed Stable
2015-06-05 10:44airaceburuRegression date => 2012-04-02
2015-06-05 10:44airaceburuRegression introduced in release => 3.0MP12
2015-06-05 10:44airaceburuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/588bdc741142 [^]
2015-06-05 10:44airaceburuTriggers an Emergency Pack => No
2015-06-05 10:45airaceburuRelationship addedcaused by 0012599
2015-06-05 12:00alostaleStatusnew => scheduled
2015-06-05 12:00alostaleAssigned Toplatform => NaroaIriarte
2015-06-05 12:00alostalePrioritynormal => immediate
2015-06-08 12:59hgbotCheckin
2015-06-08 12:59hgbotNote Added: 0078145
2015-06-08 12:59hgbotStatusscheduled => resolved
2015-06-08 12:59hgbotResolutionopen => fixed
2015-06-08 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3ee5b64b9eab7fa476daec24dac96ae0d3636b2b [^]
2015-06-08 13:01NaroaIriarteIssue Monitored: alostale
2015-06-08 13:02NaroaIriarteReview Assigned To => alostale
2015-06-08 22:24hudsonbotCheckin
2015-06-08 22:24hudsonbotNote Added: 0078149
2015-06-10 15:42alostaleNote Added: 0078182
2015-06-10 15:42alostaleStatusresolved => closed
2015-06-10 15:42alostaleFixed in Version => 3.0PR15Q3

Notes
(0078145)
hgbot   
2015-06-08 12:59   
Repository: erp/devel/pi
Changeset: 3ee5b64b9eab7fa476daec24dac96ae0d3636b2b
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Jun 08 12:58:32 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3ee5b64b9eab7fa476daec24dac96ae0d3636b2b [^]

Fixed issue 30112: The message shown trying to save a datapackage isn't correct

The problem was that the message associated to the label "20102" was not correct in this case.
To fix this, a new message has been added to AD_MESSAGE, and now, the message
'The java package of the Data Package must be within the java package of its module.' is
shown when the java package of the module is not contained in the java package of the data
package.
Also, the duplicated where clause has been removed from the trigger.

This fix has been tested with postgres and also with oracle.

---
M src-db/database/model/triggers/AD_PACKAGE_JP_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0078149)
hudsonbot   
2015-06-08 22:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/eea55936e896 [^]
Maturity status: Test
(0078182)
alostale   
2015-06-10 15:42   
code reviewed + tested