Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030096Openbravo ERPA. Platformpublic2015-06-04 14:072015-06-15 09:21
Reporterngarcia 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36633
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030096: Cannot filter the business partner field by ' symbol in selector drop down
DescriptionCannot filter the business partner field by ' symbol
Steps To ReproduceAs group admin role:
   Create a Business Partner as Customer and set its name with '
   Go to Sales Order screen and check the business partner is not shown in the selector combo if you enter the ' value
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035956 closed alostale The numeric field filter does not work with operators in HQL based selectors 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-04 14:07ngarciaNew Issue
2015-06-04 14:07ngarciaAssigned To => platform
2015-06-04 14:07ngarciaOBNetwork customer => Yes
2015-06-04 14:07ngarciaModules => Core
2015-06-04 14:07ngarciaSupport ticket => 36633
2015-06-04 14:07ngarciaTriggers an Emergency Pack => No
2015-06-04 14:09ngarciaIssue Monitored: networkb
2015-06-05 08:59alostaleSummaryCannot filter the business partner field by ' symbol => Cannot filter the business partner field by ' symbol in selector drop down
2015-06-05 08:59alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8760#r8760
2015-06-05 09:02alostaleNote Added: 0078108
2015-06-05 09:03alostaleAssigned Toplatform => caristu
2015-06-05 09:03alostaleSeverityminor => major
2015-06-05 09:03alostaleStatusnew => scheduled
2015-06-10 09:06caristuIssue Monitored: alostale
2015-06-10 09:06caristuReview Assigned To => alostale
2015-06-10 09:07hgbotCheckin
2015-06-10 09:07hgbotNote Added: 0078167
2015-06-10 09:07hgbotStatusscheduled => resolved
2015-06-10 09:07hgbotResolutionopen => fixed
2015-06-10 09:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba6a63e37880800cc51ee2945a8996b35479dfbf [^]
2015-06-10 15:15hudsonbotCheckin
2015-06-10 15:15hudsonbotNote Added: 0078179
2015-06-15 09:21alostaleNote Added: 0078275
2015-06-15 09:21alostaleStatusresolved => closed
2015-06-15 09:21alostaleFixed in Version => 3.0PR15Q3
2017-05-25 09:03caristuRelationship addedrelated to 0035956

Notes
(0078108)
alostale   
2015-06-05 09:02   
Quote symbol ['] doesn't work in Sales Order window for:
* BP selector drop down
* BP selector popup filter

Though it works in Sales Order window for:
* Grid filter for BP and other FK fields
* Project selector drop down
* Project selector popup filter

The problem is in Custom Query Selector and the way filter parameters are handled for them.

See java stack traces when this occurs.
(0078167)
hgbot   
2015-06-10 09:07   
Repository: erp/devel/pi
Changeset: ba6a63e37880800cc51ee2945a8996b35479dfbf
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jun 10 09:05:57 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ba6a63e37880800cc51ee2945a8996b35479dfbf [^]

Fixes issue 30096: Cannot filter the bp field by ' symbol in selector drop down

The CustomQuerySelectorDatasource was not handling the parameters of the query properly. For that reason characters like ' were not replaced as expected.
Now the parameters are mapped into a list, and replaced in the query using the setParameter() method

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
---
(0078179)
hudsonbot   
2015-06-10 15:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ec9a491fe07d [^]
Maturity status: Test
(0078275)
alostale   
2015-06-15 09:21   
code reviewed

Tested:
-Custom query selectors: now parameters are properly used for HQL
-Standard selectors
-Table and TableDir references