Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030095Openbravo ERP09. Financial managementpublic2015-06-04 13:592015-06-18 18:32
Reporteraferraz 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2015-05-28
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/aed0c66779e9442c6c92010951125f28179c0e1e [^]
Triggers an Emergency PackNo
Summary0030095: BP current balance not properly updated when generating credit from Payment In/Out
DescriptionBusiness Partner current balance not properly updated when generating credit from Payment In/Out
Steps To ReproduceAs F&B Admin:

- Go to Client window.
  Move to Dimensions tab.
  Set "Show in Header" = Y for "AR Receipt" document, "Bus.Partner" dimension

- Login/Logout

- Go to Business Partner window and check current balance amount.

- Create a Payment In from "Alimentos y Supermercados" and amount = 20.
  Click on Add Details.
  Uncheck any record in Order/Invoice grid.
  Select "Process Received Payment(s) and Deposit" and "Leave the credit to be used later".
  Click on Done.

- Go to Business Partner window and realize the current balance amount has not been updated.

- The same happens if the flow is done from Payment Out.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00300983.0PR15Q2.2 closed aferraz BP current balance not properly updated when generating credit from Payment In 
depends on backport 00300993.0PR15Q1.5 closed aferraz BP current balance not properly updated when generating credit from Payment In 
caused by defect 0030007 closed aferraz Payment schedule amount incorrectly calculated when adding a payment from reconcile window to a sales order 
related to defect 00301663.0PR15Q3 closed aferraz Wrong order payment plan with isinvoicepaid feature 
blocks defect 00300773.0PR15Q4 closed aferraz Customer Balance not working properly with multicurrency credit 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-06-04 13:59aferrazNew Issue
2015-06-04 13:59aferrazAssigned To => aferraz
2015-06-04 13:59aferrazModules => Core
2015-06-04 13:59aferrazRegression level => Packaging and release
2015-06-04 13:59aferrazRegression date => 2015-05-28
2015-06-04 13:59aferrazRegression introduced in release => main
2015-06-04 13:59aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/aed0c66779e9442c6c92010951125f28179c0e1e [^]
2015-06-04 13:59aferrazTriggers an Emergency Pack => No
2015-06-04 14:00aferrazRelationship addedcaused by 0030007
2015-06-04 14:14aferrazRelationship addedblocks 0030077
2015-06-04 16:39aferrazStatusnew => scheduled
2015-06-04 17:26aferrazSeveritycritical => major
2015-06-04 17:58aferrazNote Added: 0078095
2015-06-04 18:18aferrazNote Edited: 0078095bug_revision_view_page.php?bugnote_id=0078095#r8754
2015-06-04 18:40aferrazSummaryBP current balance not properly updated when generating credit from Payment In => BP current balance not properly updated when generating credit from Payment In/Out
2015-06-04 18:40aferrazDescription Updatedbug_revision_view_page.php?rev_id=8756#r8756
2015-06-04 18:40aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=8758#r8758
2015-06-09 13:10hgbotCheckin
2015-06-09 13:10hgbotNote Added: 0078154
2015-06-09 13:10hgbotStatusscheduled => resolved
2015-06-09 13:10hgbotResolutionopen => fixed
2015-06-09 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/195dff67518973e72ac3a2bcbd255d132a9959f3 [^]
2015-06-09 13:12vmromanosReview Assigned To => vmromanos
2015-06-09 13:12vmromanosNote Added: 0078157
2015-06-09 13:12vmromanosStatusresolved => closed
2015-06-10 15:15hudsonbotCheckin
2015-06-10 15:15hudsonbotNote Added: 0078176
2015-06-17 14:42aferrazStatusclosed => new
2015-06-17 14:42aferrazResolutionfixed => open
2015-06-17 14:47aferrazRelationship addedrelated to 0030166
2015-06-18 12:21hgbotCheckin
2015-06-18 12:21hgbotNote Added: 0078365
2015-06-18 12:25aferrazReview Assigned Tovmromanos => aferraz
2015-06-18 12:25aferrazNote Added: 0078367
2015-06-18 12:25aferrazStatusnew => closed
2015-06-18 12:25aferrazResolutionopen => no change required
2015-06-18 18:32hudsonbotCheckin
2015-06-18 18:32hudsonbotNote Added: 0078381

Notes
(0078095)
aferraz   
2015-06-04 17:58   
(edited on: 2015-06-04 18:18)
Test plan:

As F&B Admin:

- Go to Client window.
  Move to Dimensions tab.
  Set "Show in Header" = Y for "AR Receipt" document, "Bus.Partner" dimension

- Login/Logout

- Go to Business Partner window and check current balance amount.

- Create a Payment In from "Alimentos y Supermercados" and amount = 20.
  Click on Add Details.
  Uncheck any record in Order/Invoice grid.
  Select "Process Received Payment(s) and Deposit" and "Leave the credit to be used later".
  Click on Done.

- Go to Business Partner window and realize the current balance amount has been properly updated.

- Create another Payment In from "Alimentos y Supermercados" and amount = 0.
  Click on Add Details.
  Select previous created credit in Credit To Use grid.
  Uncheck any record in Order/Invoice grid.
  Select "Process Received Payment(s) and Deposit" and "Refund amount to customer".
  Click on Done.

- Go to Business Partner window and realize the current balance amount has been properly updated.

- Repeat the same flow for Payment Out window.
(0078154)
hgbot   
2015-06-09 13:10   
Repository: erp/devel/pi
Changeset: 195dff67518973e72ac3a2bcbd255d132a9959f3
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 04 17:47:14 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/195dff67518973e72ac3a2bcbd255d132a9959f3 [^]

Fixes issue 30095: BP current balance not properly updated

Change condition in FIN_PaymentProcess to take into account when the paymend does not have order nor invoice related (when it only has a g/l item, when we are genereting credit or when we are refunding amount).

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0078157)
vmromanos   
2015-06-09 13:12   
Code review + testing OK
(0078176)
hudsonbot   
2015-06-10 15:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ec9a491fe07d [^]
Maturity status: Test
(0078365)
hgbot   
2015-06-18 12:21   
Repository: erp/devel/pi
Changeset: d5704e432670782dbc0bfd157e37f1a426bdd3af
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 17 13:49:30 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d5704e432670782dbc0bfd157e37f1a426bdd3af [^]

Related to issue 30095: Backout changeset 195dff675189

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0078367)
aferraz   
2015-06-18 12:25   
Backout done and issue rejected as is not longer reproducible since this other backout: https://code.openbravo.com/erp/devel/pi/rev/56e313660729ba9148ad01703190a43a604ae231 [^]
(0078381)
hudsonbot   
2015-06-18 18:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/42df4e2c6b02 [^]
Maturity status: Test