Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030084Retail ModulesWeb POSpublic2015-06-03 16:352015-09-25 13:14
Reporteraaroncalero 
Assigned Toaaroncalero 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030084: It is possible to skip the OBPOS_approval.deleteLine approval in several cases
DescriptionIs is possible to skip the approval to delete lines using different flows.
Steps To ReproduceHaving a manual role with the OBPOS_approval.deleteLine set to 'N'
Create a ticket in web POS and then:
a) Add a product > Undo
with normal tickets:
b) Line with negative qty/Return Line > button ‘+’ until qty = 0
c) Line with negative qty/Return Line > write qty > button ‘+’
d) Line with negative qty/Return Line > Add products until qty = 0
With return tickets:
e) Line with negative qty > button ‘-’ until qty = 0
f) Line with negative qty > Write qty > button ‘-’

Until 30075 is fixed, also:
g) Line with positive qty >button ‘+’ until qty = 0
h) Line with positive qty > Write qty > button ‘+’
i) Line with positive qty > Add products until qty = 0

All steps can be used to delete the line without the approval
Proposed SolutionAll mentiones cases should require approval if the user doesn't have permission to delete lines.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0030075pi closed aaroncalero Return tickets should not be able to contain positive lines 
blocks feature request 0030094 closed aaroncalero Be able to configure Web POS not to delete the receipts 
Attached Filesdiff issue30084.diff (5,804) 2015-06-04 12:49
https://issues.openbravo.com/file_download.php?file_id=8166&type=bug
diff Test30084.diff (14,357) 2015-06-04 12:49
https://issues.openbravo.com/file_download.php?file_id=8167&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-06-03 16:35aaroncaleroNew Issue
2015-06-03 16:35aaroncaleroAssigned To => aaroncalero
2015-06-03 16:35aaroncaleroOBNetwork customer => No
2015-06-03 16:35aaroncaleroTriggers an Emergency Pack => No
2015-06-03 17:11aaroncaleroRelationship addeddepends on 0030075
2015-06-04 12:49aaroncaleroFile Added: issue30084.diff
2015-06-04 12:49aaroncaleroFile Added: Test30084.diff
2015-06-04 13:44aaroncaleroRelationship addedblocks 0030094
2015-06-11 14:08eintelauIssue Monitored: eintelau
2015-09-04 09:16hgbotCheckin
2015-09-04 09:16hgbotNote Added: 0080065
2015-09-04 09:16hgbotStatusnew => resolved
2015-09-04 09:16hgbotResolutionopen => fixed
2015-09-04 09:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/417081417db5ed7cba8a98f4a656d9ee62a820e3 [^]
2015-09-04 09:29aaroncaleroReview Assigned To => marvintm
2015-09-04 09:30aaroncaleroNote Added: 0080081
2015-09-15 09:19hgbotCheckin
2015-09-15 09:19hgbotNote Added: 0080394
2015-09-25 13:14marvintmStatusresolved => closed
2015-09-25 13:14marvintmFixed in Version => RR15Q4

Notes
(0080065)
hgbot   
2015-09-04 09:16   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 417081417db5ed7cba8a98f4a656d9ee62a820e3
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Sep 01 16:34:22 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/417081417db5ed7cba8a98f4a656d9ee62a820e3 [^]

Fixed issue 30084: It is possible to skip the OBPOS_approval.deleteLine approval in several cases

Added the approval to delete lines where it was missing

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0080081)
aaroncalero   
2015-09-04 09:30   
Related commit:
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5a89f5cd698642c6d02f760e1f522387126ed628
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Sep 02 11:36:58 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a89f5cd698642c6d02f760e1f522387126ed628 [^] [^]
(0080394)
hgbot   
2015-09-15 09:19   
Repository: tools/automation/pi-mobile
Changeset: 5bcc3799b3702d9950d30276ee465f9dee9c6808
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Sep 15 09:17:29 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5bcc3799b3702d9950d30276ee465f9dee9c6808 [^]

Related to issue 30084: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I30084_DeleteLinesApprovalNotSkipped.java
---